From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 6/9] xfs: fix wrong err sign on xfs_set_acl()
Date: Tue, 13 May 2014 20:51:49 +0800 [thread overview]
Message-ID: <53721565.1030104@oracle.com> (raw)
In-Reply-To: <1399971373-6242-7-git-send-email-david@fromorbit.com>
On 05/13 2014 16:56 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/xfs_iops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index adfb18e..36d6303 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -173,12 +173,12 @@ xfs_generic_create(
>
> #ifdef CONFIG_XFS_POSIX_ACL
> if (default_acl) {
> - error = xfs_set_acl(inode, default_acl, ACL_TYPE_DEFAULT);
> + error = -xfs_set_acl(inode, default_acl, ACL_TYPE_DEFAULT);
> if (error)
> goto out_cleanup_inode;
> }
> if (acl) {
> - error = xfs_set_acl(inode, acl, ACL_TYPE_ACCESS);
> + error = -xfs_set_acl(inode, acl, ACL_TYPE_ACCESS);
> if (error)
> goto out_cleanup_inode;
> }
>
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Cheers,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-13 12:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 8:56 [PATCH 0/9] xfs: error sign fixes for 3.15-rc6 Dave Chinner
2014-05-13 8:56 ` [PATCH 1/9] xfs: xfs_dir_fsync() returns positive errno Dave Chinner
2014-05-13 12:46 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 2/9] xfs: fix incorrect error sign in xfs_file_aio_read Dave Chinner
2014-05-13 12:46 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 3/9] xfs: xfs_commit_metadata returns wrong errno Dave Chinner
2014-05-13 12:48 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 4/9] xfs: correct error sign on COLLAPSE_RANGE errors Dave Chinner
2014-05-13 12:49 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 5/9] xfs: fix wrong errno from xfs_initxattrs Dave Chinner
2014-05-13 12:51 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 6/9] xfs: fix wrong err sign on xfs_set_acl() Dave Chinner
2014-05-13 12:51 ` Jeff Liu [this message]
2014-05-13 8:56 ` [PATCH 7/9] xfs: negate mount workqueue init error value Dave Chinner
2014-05-13 12:56 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 8/9] xfs: negate xfs_icsb_init_counters " Dave Chinner
2014-05-13 12:58 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 9/9] xfs: list_lru_init returns a negative error Dave Chinner
2014-05-13 13:05 ` Jeff Liu
2014-05-14 7:28 ` [PATCH 0/9] xfs: error sign fixes for 3.15-rc6 Jeff Liu
2014-05-14 21:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53721565.1030104@oracle.com \
--to=jeff.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.