From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH] PM / OPP: discard duplicate OPP additions Date: Tue, 13 May 2014 14:02:50 +0100 Message-ID: <537217FA.1090200@arm.com> References: <1399966890-22926-1-git-send-email-k.chander@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:38439 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932401AbaEMNCz convert rfc822-to-8bit (ORCPT ); Tue, 13 May 2014 09:02:55 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Chander Kashyap , Viresh Kumar Cc: Sudeep Holla , Nishanth Menon , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "Rafael J. Wysocki" , Pavel Machek , "Brown, Len" , Greg Kroah-Hartman , Chander Kashyap , Inderpal Singh On 13/05/14 12:57, Chander Kashyap wrote: > On 13 May 2014 16:35, Viresh Kumar wrote: >> On 13 May 2014 16:00, Sudeep Holla wrote: >>> On Tue, May 13, 2014 at 9:22 AM, Viresh Kumar wrote: >>>> On 13 May 2014 13:11, [Chander Kashyap wrote: >>>> >>>> What happened to your name ? "[" >>>> >>>>> From: Chander Kashyap >>>>> >>>>> It may be possible to unregister and re-register the cpufreq driver. >>>>> One such example is arm big-little IKS cpufreq driver. While >>>>> re-registering the driver, same OPPs may get added again. >>>>> >>>>> This patch detects the duplicacy and discards them. >>>>> >>>>> Signed-off-by: Chander Kashyap >>>>> Signed-off-by: Inderpal Singh >>>>> --- >>>>> drivers/base/power/opp.c | 28 +++++++++++++++++++--------- >>>>> 1 file changed, 19 insertions(+), 9 deletions(-) >>>> >>>> I wouldn't say that this approach is particularly bad or wrong, but what >>>> about this instead? >>>> >>> >>> Yes I prefer this and this exactly what I had[1] in my OPP DT series which >>> we could not conclude on the bindings. You also need patch[2] for DT version. >> >> Ahh, I have just reinvented the wheel. Though I can see now that I have >> Acked those patches as well :) >> >> So, what are the plans for those patches then? As Chander also needs few >> of those. >> >> Probably split the series to get the non-blockers upstream Atleast ? >> >> Another thing that I thought later, though the problem can be fixed by >> your version of patches, the version from chander had something good as >> well. It would get rid of duplicate entries coming from dtb. Would it make >> sense to get that part in as well? > > This patch takes care for duplicate entries even without dt. Hence i > feel it can go as separate patch. > Sorry if I added any confusion. My original patch series addressed both the issues: 1. duplicate entries added by OPP library(same as addressed by your patch) and 2. another to avoid duplication in the devicetree for OPPs IIUC Exynos don't use ST for OPPs(yet), so you need to address only (1). But we still need (2) before any bL platforms use DT for OPPs and need CPUFreq support. And yes we can address this separately. Regards, Sudeep