From: Jeff Mahoney <jeffm@suse.com>
To: Jan Kara <jack@suse.cz>
Cc: ReiserFS Development List <reiserfs-devel@vger.kernel.org>,
Dave Jones <davej@redhat.com>
Subject: Re: [patch 00/29] reiserfs cleanup patchset
Date: Tue, 13 May 2014 10:15:29 -0400 [thread overview]
Message-ID: <53722901.9070008@suse.com> (raw)
In-Reply-To: <20140513141333.GF22070@quack.suse.cz>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 5/13/14, 10:13 AM, Jan Kara wrote:
> On Wed 23-04-14 10:00:33, Jeff Mahoney wrote:
>> Hi all -
>>
>> I've had this patchset kicking around for a while. After a
>> conversation this past week about code that was horrible to read
>> (using reiserfs's balance_leaf as the primary example) and
>> seeing that Dave Jones had scratched a bit of an itch, I decided
>> it was time to resync and push it out so I don't have to update
>> it forever.
>>
>> BTW, as I'm basically the only person with substantial patches
>> against reiserfs, I'm 100% ok with disrupting context to this
>> extent. :)
>>
>> This set consists of 29 patches in a few areas.
>>
>> 1 - Convert the commit workqueue to a per-fs workqueue 2 - Clean
>> up ugly accessor macros to use more readable names 3 - Clean up
>> comments to use the normal kernel style 4 - Remove the unused
>> nblocks argument from journal_end 5 - Remove superblock argument
>> from journal_end (it's in the trans handle) 6 - Remove superblock
>> argument from journal_mark_dirty (see #5) 7 - Remove blocks
>> argument from journal_join (it's always 1) 8 - Remove leading
>> whitespace from labels 9 - Remove unnecessary parents 10 - Clean
>> up dirent creation 11 - Clean up hash detection 12-29 - Clean up
>> balance_leaf - This 2500-line function goes through 6 easily
>> distinguishable stages, each with several sub-parts. The patch
>> set splits up the stages and then reformats them to keep the
>> split as obvious as possible. The final result is a whole lot
>> easier to follow and easier on the eyes.
> OK, I have merged all the patches into my tree.
>
Great, thanks!
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
iQIcBAEBAgAGBQJTcikBAAoJEB57S2MheeWy65oQAMJhBwLHNvuc11LEebg1049p
XX7o32ltQ22T7ER6YR4+IynNTe0XlJ8a/QtpuCiu3qWBdmHR47b+iVuN8Eu0Z3IY
qZMPx7jkJXVPAECF9/CWTh3YJ/HB9QkL1zp5BNfihQvXUmYs+wbHuQGHR0jh4vYH
Qj9kxoH76/eQMHnxIFSy1EEeGI3zjBscBM4qvjBZ3ahTiq0WV6xu6ru70Tue0fFv
ST2JjyGGAdJ/IpCUBnc10AzHqMNmEpRE7l5ama2mIV/cvNokvxTHwiycuYVz3p1m
wRE2IfSJ84Xue8mO57R3TXkgitz2WCIdah67x5oJtyHJUYq61MYcgnEr0SJSAJzr
KhO34qrJ2bQSVKnWwHrwnm+fbEBmcmkA25zNqaLNwJfS1y58M+GwxbYriarnZqgE
ndu1jB1m7o2vpDCxox+60MhAe5am4tfn95u8WvIuSLOyq3bo/WNZZpRlqL8xfm3+
5XOd+0jdQp3aIwofnt9QGOBZS5OFGnSR3yya1xuJ4KOv4bjbAKSLat4Tv62/VoFm
bYcEA7jV1TtzfgjvR2dA8M70fx1fKY0wntm7XupP5d4Y1BYIK4gbwrhTEc0Z2WNG
WSpnxRqOZTvV0E6sGNyYJYVWEkA2MplqeI3X7NeT8UN5/XmgaRsfB7OjJLk0gjN7
rWunXLnovNfP8AWkOS3I
=wYZx
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-05-13 14:15 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 14:00 [patch 00/29] reiserfs cleanup patchset Jeff Mahoney
2014-04-23 14:00 ` [patch 01/29] reiserfs: use per-fs commit workqueues Jeff Mahoney
2014-04-23 14:00 ` [patch 02/29] reiserfs: cleanup, rename key and item accessors to more friendly names Jeff Mahoney
2014-04-23 14:00 ` [patch 04/29] reiserfs: cleanup, remove nblocks argument from journal_end Jeff Mahoney
2014-04-23 14:00 ` [patch 05/29] reiserfs: cleanup, remove sb " Jeff Mahoney
2014-04-23 14:00 ` [patch 06/29] reiserfs: cleanup, remove sb argument from journal_mark_dirty Jeff Mahoney
2014-04-23 14:00 ` [patch 07/29] reiserfs: cleanup, remove blocks arg from journal_join Jeff Mahoney
2014-04-23 14:00 ` [patch 08/29] reiserfs: cleanup, remove leading whitespace from labels Jeff Mahoney
2014-04-23 14:00 ` [patch 09/29] reiserfs: cleanup, remove unnecessary parens Jeff Mahoney
2014-04-23 14:00 ` [patch 10/29] reiserfs: cleanup, remove unnecessary parens in dirent creation Jeff Mahoney
2014-04-23 14:00 ` [patch 11/29] reiserfs: cleanup, make hash detection saner Jeff Mahoney
2014-05-06 21:27 ` Jan Kara
2014-05-07 12:16 ` Jeff Mahoney
2014-05-07 15:50 ` Jan Kara
2014-04-23 14:00 ` [patch 12/29] reiserfs: balance_leaf refactor, reformat balance_leaf comments Jeff Mahoney
2014-04-23 14:00 ` [patch 13/29] reiserfs: balance_leaf refactor, move state variables into tree_balance Jeff Mahoney
2014-04-23 14:00 ` [patch 14/29] reiserfs: balance_leaf refactor, pull out balance_leaf_insert_left Jeff Mahoney
2014-04-23 14:00 ` [patch 15/29] reiserfs: balance_leaf refactor, pull out balance_leaf_paste_left Jeff Mahoney
2014-04-23 14:00 ` [patch 16/29] reiserfs: balance_leaf refactor, pull out balance_leaf_insert_right Jeff Mahoney
2014-04-23 14:00 ` [patch 17/29] reiserfs: balance_leaf refactor, pull out balance_leaf_paste_right Jeff Mahoney
2014-04-23 14:00 ` [patch 18/29] reiserfs: balance_leaf refactor, pull out balance_leaf_new_nodes_insert Jeff Mahoney
2014-04-23 14:00 ` [patch 19/29] reiserfs: balance_leaf refactor, pull out balance_leaf_new_nodes_paste Jeff Mahoney
2014-04-23 14:00 ` [patch 20/29] reiserfs: balance_leaf refactor pull out balance_leaf_finish_node_insert Jeff Mahoney
2014-04-23 14:00 ` [patch 21/29] reiserfs: balance_leaf refactor, pull out balance_leaf_finish_node_paste Jeff Mahoney
2014-04-23 14:00 ` [patch 22/29] reiserfs: balance_leaf refactor, pull out balance_leaf{left, right, new_nodes, finish_node} Jeff Mahoney
2014-04-23 14:00 ` [patch 23/29] reiserfs: balance_leaf refactor, format balance_leaf_insert_left Jeff Mahoney
2014-04-23 14:00 ` [patch 24/29] reiserfs: balance_leaf refactor, format balance_leaf_paste_left Jeff Mahoney
2014-04-23 14:00 ` [patch 25/29] reiserfs: balance_leaf refactor, format balance_leaf_insert_right Jeff Mahoney
2014-04-23 14:00 ` [patch 26/29] reiserfs: balance_leaf refactor, format balance_leaf_paste_right Jeff Mahoney
2014-04-23 14:01 ` [patch 27/29] reiserfs: balance_leaf refactor, format balance_leaf_new_nodes_paste Jeff Mahoney
2014-04-23 14:01 ` [patch 28/29] reiserfs: balance_leaf refactor, format balance_leaf_finish_node Jeff Mahoney
2014-04-23 14:01 ` [patch 29/29] reiserfs: balance_leaf refactor, split up balance_leaf_when_delete Jeff Mahoney
2014-04-26 3:46 ` [patch 00/29] reiserfs cleanup patchset doiggl
2014-04-26 15:14 ` Jeff Mahoney
2014-05-16 10:47 ` doiggl
2014-05-22 8:24 ` doiggl
2014-05-22 13:51 ` Jeff Mahoney
2014-05-26 4:12 ` doiggl
2014-05-26 18:24 ` Jeff Mahoney
2014-06-12 14:31 ` doiggl
2014-06-12 14:38 ` Jeff Mahoney
2014-06-13 4:20 ` doiggl
2014-06-13 4:25 ` Jeff Mahoney
2014-06-13 15:09 ` Jeff Mahoney
2014-05-13 14:13 ` Jan Kara
2014-05-13 14:15 ` Jeff Mahoney [this message]
2014-05-27 9:23 ` doiggl
2014-05-27 12:36 ` Jeff Mahoney
2014-06-05 3:21 ` Jose R R
[not found] ` <47aabceb9575031270f0940059da157c@mail.velocitynet.com.au>
2014-06-26 14:27 ` [patch 00/29] reiserfs cleanup patchset - 03/29 attached [reiserfs: cleanup, reformat comments to normal kernel style] Jose R R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53722901.9070008@suse.com \
--to=jeffm@suse.com \
--cc=davej@redhat.com \
--cc=jack@suse.cz \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.