From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>,
Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB: allows build of hw/ and ulp/ subdirectory independently
Date: Tue, 13 May 2014 17:12:18 +0200 [thread overview]
Message-ID: <53723652.7020100@acm.org> (raw)
In-Reply-To: <1395918633-26765-1-git-send-email-ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
On 03/27/14 12:10, Yann Droneaud wrote:
> It is not possible to build only drivers/infiniband/hw/ (and ulp/)
> subdirectory with command such as:
>
> $ make ARCH=x86_64 O=./obj-x86_64/ drivers/infiniband/hw/
>
> This fails with following error messages:
>
> make[2]: Nothing to be done for `all'.
> make[2]: Nothing to be done for `relocs'.
> CHK include/config/kernel.release
> Using /home/ydroneaud/src/linux as source for kernel
> GEN /home/ydroneaud/src/linux/obj-x86_64/Makefile
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> CALL /home/ydroneaud/src/linux/scripts/checksyscalls.sh
> /home/ydroneaud/src/linux/scripts/Makefile.build:44: /home/ydroneaud/src/linux/drivers/infiniband/hw/Makefile: No such file or directory
> make[2]: *** No rule to make target `/home/ydroneaud/src/linux/drivers/infiniband/hw/Makefile'. Stop.
> make[1]: *** [drivers/infiniband/hw/] Error 2
> make: *** [sub-make] Error 2
>
> This patch creates a Makefile in hw/ and ulp/ and moves
> each corresponding parts of drivers/infiniband/Makefile
> in the new Makefiles.
>
> It should not break build except if some hw/ drivers or ulp/
> were allowed previously to be built while CONFIG_INFINIBAND
> is set to 'n', but according to drivers/infiniband/Kconfig,
> it's not possible. So it should be safe to apply.
>
> Signed-off-by: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/infiniband/Makefile | 19 ++-----------------
> drivers/infiniband/hw/Makefile | 12 ++++++++++++
> drivers/infiniband/ulp/Makefile | 5 +++++
> 3 files changed, 19 insertions(+), 17 deletions(-)
> create mode 100644 drivers/infiniband/hw/Makefile
> create mode 100644 drivers/infiniband/ulp/Makefile
>
> diff --git a/drivers/infiniband/Makefile b/drivers/infiniband/Makefile
> index bf508b5550c4..dc21836b5a8d 100644
> --- a/drivers/infiniband/Makefile
> +++ b/drivers/infiniband/Makefile
> @@ -1,18 +1,3 @@
> obj-$(CONFIG_INFINIBAND) += core/
> -obj-$(CONFIG_INFINIBAND_MTHCA) += hw/mthca/
> -obj-$(CONFIG_INFINIBAND_IPATH) += hw/ipath/
> -obj-$(CONFIG_INFINIBAND_QIB) += hw/qib/
> -obj-$(CONFIG_INFINIBAND_EHCA) += hw/ehca/
> -obj-$(CONFIG_INFINIBAND_AMSO1100) += hw/amso1100/
> -obj-$(CONFIG_INFINIBAND_CXGB3) += hw/cxgb3/
> -obj-$(CONFIG_INFINIBAND_CXGB4) += hw/cxgb4/
> -obj-$(CONFIG_MLX4_INFINIBAND) += hw/mlx4/
> -obj-$(CONFIG_MLX5_INFINIBAND) += hw/mlx5/
> -obj-$(CONFIG_INFINIBAND_NES) += hw/nes/
> -obj-$(CONFIG_INFINIBAND_OCRDMA) += hw/ocrdma/
> -obj-$(CONFIG_INFINIBAND_USNIC) += hw/usnic/
> -obj-$(CONFIG_INFINIBAND_IPOIB) += ulp/ipoib/
> -obj-$(CONFIG_INFINIBAND_SRP) += ulp/srp/
> -obj-$(CONFIG_INFINIBAND_SRPT) += ulp/srpt/
> -obj-$(CONFIG_INFINIBAND_ISER) += ulp/iser/
> -obj-$(CONFIG_INFINIBAND_ISERT) += ulp/isert/
> +obj-$(CONFIG_INFINIBAND) += hw/
> +obj-$(CONFIG_INFINIBAND) += ulp/
> diff --git a/drivers/infiniband/hw/Makefile b/drivers/infiniband/hw/Makefile
> new file mode 100644
> index 000000000000..e900b03531a9
> --- /dev/null
> +++ b/drivers/infiniband/hw/Makefile
> @@ -0,0 +1,12 @@
> +obj-$(CONFIG_INFINIBAND_MTHCA) += mthca/
> +obj-$(CONFIG_INFINIBAND_IPATH) += ipath/
> +obj-$(CONFIG_INFINIBAND_QIB) += qib/
> +obj-$(CONFIG_INFINIBAND_EHCA) += ehca/
> +obj-$(CONFIG_INFINIBAND_AMSO1100) += amso1100/
> +obj-$(CONFIG_INFINIBAND_CXGB3) += cxgb3/
> +obj-$(CONFIG_INFINIBAND_CXGB4) += cxgb4/
> +obj-$(CONFIG_MLX4_INFINIBAND) += mlx4/
> +obj-$(CONFIG_MLX5_INFINIBAND) += mlx5/
> +obj-$(CONFIG_INFINIBAND_NES) += nes/
> +obj-$(CONFIG_INFINIBAND_OCRDMA) += ocrdma/
> +obj-$(CONFIG_INFINIBAND_USNIC) += usnic/
> diff --git a/drivers/infiniband/ulp/Makefile b/drivers/infiniband/ulp/Makefile
> new file mode 100644
> index 000000000000..f3c7dcf03098
> --- /dev/null
> +++ b/drivers/infiniband/ulp/Makefile
> @@ -0,0 +1,5 @@
> +obj-$(CONFIG_INFINIBAND_IPOIB) += ipoib/
> +obj-$(CONFIG_INFINIBAND_SRP) += srp/
> +obj-$(CONFIG_INFINIBAND_SRPT) += srpt/
> +obj-$(CONFIG_INFINIBAND_ISER) += iser/
> +obj-$(CONFIG_INFINIBAND_ISERT) += isert/
Reviewed-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-05-13 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 11:10 [PATCH] IB: allows build of hw/ and ulp/ subdirectory independently Yann Droneaud
[not found] ` <1395918633-26765-1-git-send-email-ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
2014-05-13 15:12 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53723652.7020100@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.