From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] exec-all.h: Don't use stl_p for patching x86 jumps
Date: Tue, 13 May 2014 09:19:10 -0700 [thread overview]
Message-ID: <537245FE.5060804@twiddle.net> (raw)
In-Reply-To: <CAFEAcA_QbOv_yR4VScTNLv1a-W8GVsRfRhuDF2L6PF9Rk+CvFw@mail.gmail.com>
On 05/13/2014 09:10 AM, Peter Maydell wrote:
> On 13 May 2014 17:05, Richard Henderson <rth@twiddle.net> wrote:
>> Partial revert of 86360ad71df0070283469b8ae59f33cdd013501d,
>> because get the "wrong" version of stl_p, the one that does
>> byte swapping appropriate for the target.
>
> Whoops. We could alternatively commit the patch renaming
> the bswap.h functions to use _he_ infixes and then use
> stl_he_p() here, yes?
Yes.
> Probably best to commit this as an immediate fix though.
That's what I was thinking.
r~
next prev parent reply other threads:[~2014-05-13 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 16:05 [Qemu-devel] [PATCH] exec-all.h: Don't use stl_p for patching x86 jumps Richard Henderson
2014-05-13 16:10 ` Peter Maydell
2014-05-13 16:19 ` Richard Henderson [this message]
2014-05-13 16:55 ` Paolo Bonzini
2014-05-13 16:59 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537245FE.5060804@twiddle.net \
--to=rth@twiddle.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.