From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH v2 0/9] SRP initiator patches for kernel 3.16 Date: Tue, 13 May 2014 19:50:43 +0300 Message-ID: <53724D63.3070307@dev.mellanox.co.il> References: <53722E4F.7070709@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53722E4F.7070709-HInyCGIudOg@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche , Roland Dreier Cc: Sagi Grimberg , Vu Pham , David Dillow , Sebastian Parschauer , linux-rdma List-Id: linux-rdma@vger.kernel.org On 5/13/2014 5:38 PM, Bart Van Assche wrote: > Changes compared to v1: > - Modified the FMR code such that one FMR pool is allocated per > connection instead of one pool per HCA. > - Dropped the patch "Make srp_alloc_req_data() reallocate request data". > - Moved introduction of the register_always kernel module parameter > into a separate patch. > - Removed the loop from around ib_create_fmr_pool() and > srp_create_fr_pool(). max_pages_per_mr is now computed from > max_mr_size and max_fast_reg_page_list_len. > - Reduced fast registration pool size from 1024 to scsi_host->can_queue. > - Added a patch that should fix a crash that had been reported by Sagi > but that I have not yet been able to reproduce myself. > > This patch series consists of the following nine patches: > > 0001-IB-srp-Fix-a-sporadic-crash-triggered-by-cable-pulli.patch > 0002-IB-srp-Fix-kernel-doc-warnings.patch > 0003-IB-srp-Introduce-an-additional-local-variable.patch > 0004-IB-srp-Introduce-srp_map_fmr.patch > 0005-IB-srp-Introduce-srp_finish_mapping.patch > 0006-IB-srp-Introduce-the-register_always-kernel-module-p.patch > 0007-IB-srp-One-FMR-pool-per-SRP-connection.patch > 0008-IB-srp-Rename-FMR-related-variables.patch > 0009-IB-srp-Add-fast-registration-support.patch Hey Bart, Thanks for the quick re-spin. I had a look, first 8 patches seems ok to me. I posted some comments on patch 9/9. Cheers, Sagi. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html