From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>,
sebastian.hesselbarth@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net
Cc: netdev@vger.kernel.org, Jiancheng Xue <xuejiancheng@huawei.com>
Subject: Re: [PATCH] net: phy: resume phydev when PHY_RESUMING
Date: Tue, 13 May 2014 22:51:05 +0400 [thread overview]
Message-ID: <53726999.4050103@cogentembedded.com> (raw)
In-Reply-To: <1399972998-21772-1-git-send-email-zhangfei.gao@linaro.org>
Hello.
On 05/13/2014 01:23 PM, Zhangfei Gao wrote:
> Commit be9dad1f9f26604fb suspend phydev when going to HALTED.
Please also specify that commit's summary line in parens.
> However not to resume phydev when going to RESUMING.
> BMCR_PDOWN remains set "ifconfig eth0 down" -> "ifconfig eth0 up".
> Unless phy_attach_direct is called in open function.
> Fix the issue via phy_resume in PHY_RESUMING
> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
WBR, Sergei
next prev parent reply other threads:[~2014-05-13 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 9:23 [PATCH] net: phy: resume phydev when PHY_RESUMING Zhangfei Gao
2014-05-13 18:51 ` Sergei Shtylyov [this message]
2014-05-13 19:46 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53726999.4050103@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=xuejiancheng@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.