From: Ben Greear <greearb@candelatech.com>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: ath10k <ath10k@lists.infradead.org>
Subject: Re: FYI: msdu-desc must be multiple of 8.
Date: Tue, 13 May 2014 15:50:15 -0700 [thread overview]
Message-ID: <5372A1A7.2080602@candelatech.com> (raw)
In-Reply-To: <CAHqTa-2OCz30cetjY3pALup-e0WL=YRLOkrB3Q6QmSyQBxdvhQ@mail.gmail.com>
On 05/13/2014 03:42 PM, Avery Pennarun wrote:
> On Tue, May 13, 2014 at 6:34 PM, Ben Greear <greearb@candelatech.com> wrote:
>> I just hit strange and wonderful crashes because I managed to use
>> an msdu-desc length that was not an even multiple of 8. Firmware
>> has assumption (bug, really) about this.
>>
>> Bug is only triggerable if you fill up tx-descs, so have to flood UDP
>> to hit easily. I was trying 812 buffers, but 808 works just fine.
>> (non CT firmware will not let you do less that 1024, no matter what you
>> request, btw).
>
> What chooses the msdu-desc length? Is there a chance that this would
> happen on an unmodified driver?
It would take someone mucking around in the driver like I was.
Mucking with the vow_config would likely have similar constraints,
but nothing is using that, and I'm not sure firmware even supports it.
See TARGET_10X_NUM_MSDU_DESC
As an aside, if you do manage to crash firmware in this manner, it also
takes down the host when it tries to clean up the stale tx buffers. Possibly
that bug is just due to some of my own patches, but might be worth investigating
some day when I have more time and a cleaner tree...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-05-13 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 22:34 FYI: msdu-desc must be multiple of 8 Ben Greear
2014-05-13 22:42 ` Avery Pennarun
2014-05-13 22:50 ` Ben Greear [this message]
2014-05-14 0:17 ` Avery Pennarun
2014-05-27 9:45 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5372A1A7.2080602@candelatech.com \
--to=greearb@candelatech.com \
--cc=apenwarr@gmail.com \
--cc=ath10k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.