From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hongyang Yang Subject: Re: [PATCH V9 06/12] remus: implement the API for checkpoint Date: Wed, 14 May 2014 09:46:28 +0800 Message-ID: <5372CAF4.5080902@cn.fujitsu.com> References: <1397540297-32184-1-git-send-email-yanghy@cn.fujitsu.com> <1397540297-32184-7-git-send-email-yanghy@cn.fujitsu.com> <21335.58503.278755.610267@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21335.58503.278755.610267@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: ian.campbell@citrix.com, wency@cn.fujitsu.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca, roger.pau@citrix.com, laijs@cn.fujitsu.com List-Id: xen-devel@lists.xenproject.org On 04/24/2014 12:04 AM, Ian Jackson wrote: > Yang Hongyang writes ("[PATCH V9 06/12] remus: implement the API for checkpoint"): >> +_hidden int libxl__remus_device_postsuspend(libxl__remus_state *remus_state); >> +_hidden int libxl__remus_device_preresume(libxl__remus_state *remus_state); >> +_hidden int libxl__remus_device_commit(libxl__remus_state *remus_state); > > This patch seems to introduce these functions with no callers. The > functions are then patched in a subsequent patch, again without any > callers. See my comments on the previous patch. Hi Ian, these functions are called in patch 11. I will restructure the patch to make it easy to review.(merge this func define and the caller) > > Thanks, > Ian. > . > -- Thanks, Yang.