From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Fantoni Subject: Re: [PATCH v5] libxl: add option for discard support to xl disk configuration Date: Wed, 14 May 2014 12:20:22 +0200 Message-ID: <53734366.7040600@m2r.biz> References: <1399637383-27742-1-git-send-email-olaf@aepfle.de> <20140509121846.GA28727@aepfle.de> <21360.55960.678251.506921@mariner.uk.xensource.com> <20140512143731.GA22214@aepfle.de> <53722941.6000701@m2r.biz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: Anthony Perard , Olaf Hering , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Il 13/05/2014 19:23, Stefano Stabellini ha scritto: > On Tue, 13 May 2014, Stefano Stabellini wrote: >> On Tue, 13 May 2014, Fabio Fantoni wrote: >>> Il 12/05/2014 17:44, Stefano Stabellini ha scritto: >>>> On Mon, 12 May 2014, Olaf Hering wrote: >>>>> On Mon, May 12, Ian Jackson wrote: >>>>> >>>>>> Olaf Hering writes ("Re: [PATCH v5] libxl: add option for discard >>>>>> support to xl disk configuration"): >>>>>>> Stefano, >>>>>>> please backport these changes from qemu.git to qemu-xen.git so that >>>>>>> discard: >>>>>>> 58da5b1e01a586eb5a52ba3eec342d6828269839 xen_disk: fix io accounting >>>>>>> f31352041bdde436c3f6d07e1525a42e48dec215 xen_disk: add discard support >>>>>> Do you mean you want these patches backported from our qemu upstream >>>>>> to the old ("traditional") xen qemu fork ? >>>>> I mean this copy, sorry if the wording was misleading: >>>>> git://xenbits.xen.org/qemu-upstream-unstable.git >>>>> >>>>> Looks like its state is currently at "1.6.2 + something". >>>> Right. I didn't reply but I agree. >>>> I think that we should upgrade qemu-upstream-unstable to QEMU v2.0, plus >>>> this series: >>>> >>>> http://marc.info/?l=qemu-devel&m=139948451916847&w=2 >>>> >>>> but I haven't had the time to do it yet. >>> If nobody does it before, I'll prepare andtest and the qemu 2.0.0 + xen missed >>> patches as soon as I have time and I'll post iton github where you can easily >>> do a pull. >>> Or anything else "special" are needed? >> No, that would be all. >> Make sure to only have these commits on top of v2.0.0: >> >> f31352041bdde436c3f6d07e1525a42e48dec215 xen_disk: add discard support >> 8b6bb0ad17ab776239ba2bfc99ff107ada01c506 pass an inclusive address range to xc_domain_pin_memory_cacheattr >> 04b0de0ee83fe464487406064afe14de27decc24 xen: factor out common functions >> ad3f7e31bfc148135d93c176d1c9197933fa8344 xen: move Xen HVM files under hw/i386/xen >> d5fdb85e3d2c319603f87f3205689ed5659f621d xen: move Xen PV machine files to hw/xenpv >> c976437c7dba9c7444fb41df45468968aaa326ad qemu-xen: free all the pirqs for msi/msix when driver unload >> fe680d0dac85e0f2d6c3b53838c250f6e0b1f49b exec: Limit translation limiting in address_space_translate to xen >> >> And please test the updated QEMU with PV (qdisk) and HVM guests. >> If everything works as expected, I can just pull your tree. > I had few minutes and I prepared a branch: > > git://xenbits.xen.org/people/sstabellini/qemu-dm.git qemu-xen-for-4.5 > > however your help testing QEMU with HVM and PV guests would still be > very much appreciated and save me a lot of time! I did some fast tests with pv and hvm domUs (both with qdisk's disks) and I not found regression for now. Note: for not add regression in some cases before (or when) push the use of qemu 2.0 in xen-unstable there must also be this serie: [PATCH 0/2] tools: update to SeaBIOS 1.7.4