Re: [PATCH v13 2/2] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

[Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Hi,

On 05/14/2014 02:03 PM, Ulf Hansson wrote:
> On 12 May 2014 15:00, Arend van Spriel <arend-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> wrote:
>> On 05/12/2014 02:04 PM, Hans de Goede wrote:
>>>
>>> From: David Lanzendörfer<david.lanzendoerfer-Z7Kmv9EsliU@public.gmane.org>
>>>
>>> The Allwinner sunxi mmc host uses dma in bus-master mode using a built-in
>>> designware idmac controller, which is identical to the one found in the
>>> mmc-dw
>>> hosts. However the rest of the host is not identical to mmc-dw, it deals
>>> with
>>> sending stop commands in hardware which makes it significantly different
>>> from the mmc-dw devices.
>>>
>>> HdG: Various cleanups and fixes.
>>
>>
>> Just nitpicking, but usually the above line should be added below the
>> original signoff, so:
>>
>>> Signed-off-by: David Lanzendörfer<david.lanzendoerfer-Z7Kmv9EsliU@public.gmane.org>
>>
>> [hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org: various cleanups and fixes]
>>
>>> Signed-off-by: Hans de Goede<hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>
>>
>> As is documented in SubmittingPatches.
>>
>> Gr. AvS
> 
> 
> This looks good to me, thanks Hans!
> 
> I will include this in the next PR I send to Chris, I will also take
> the liberty to fixup the commit msg as pointed out by Arend.

Great, thanks!

Regards,

Hans

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.