From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 1/4] x86/nmi: remove spurious local_irq_enable from check_nmi_watchdog() Date: Wed, 14 May 2014 14:31:41 +0100 Message-ID: <5373703D.2030308@citrix.com> References: <1400072299-2285-1-git-send-email-david.vrabel@citrix.com> <1400072299-2285-2-git-send-email-david.vrabel@citrix.com> <53738B020200007800012311@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WkZHe-0006wK-Nh for xen-devel@lists.xenproject.org; Wed, 14 May 2014 13:31:46 +0000 In-Reply-To: <53738B020200007800012311@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Keir Fraser List-Id: xen-devel@lists.xenproject.org On 14/05/14 14:25, Jan Beulich wrote: >>>> On 14.05.14 at 14:58, wrote: >> All callers of check_nmi_watchdog() already have local irqs enabled so >> remove the unpaired local_irq_enable(). >> >> Signed-off-by: David Vrabel >> --- >> xen/arch/x86/nmi.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c >> index 526020b..18d3820 100644 >> --- a/xen/arch/x86/nmi.c >> +++ b/xen/arch/x86/nmi.c >> @@ -126,7 +126,6 @@ int __init check_nmi_watchdog (void) >> >> for_each_online_cpu ( cpu ) >> prev_nmi_count[cpu] = nmi_count(cpu); >> - local_irq_enable(); > > I guess this will want to be replaced by a suitable ASSERT(), to make > sure eventual new callers adhere to the described rule. smp_call_function() and on_selected_cpus() which is where this matters already has such an ASSERT() so I don't think another one needs to be added here. David