All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: <netdev@vger.kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	<kvm@vger.kernel.org>, Eric Dumazet <eric.dumazet@gmail.com>,
	David Miller <davem@davemloft.net>
Subject: Moving frags and SKBTX_DEV_ZEROCOPY skbs
Date: Wed, 14 May 2014 14:40:54 +0100	[thread overview]
Message-ID: <53737266.5040601@citrix.com> (raw)

Hi,

Recently I've investigated issues around SKBTX_DEV_ZEROCOPY skbs where 
the frags list were modified. I came across this function skb_shift(), 
which moves frags between skbs. And there are a lot more of such kind, 
skb_split or skb_try_coalesce, for example.
It could be a dangerous thing if a frag is referenced from an skb which 
doesn't have the original destructor_arg, and to avoid that 
skb_orphan_frags should be called. Although probably these functions are 
not normally touched in usual usecases, I think it would be useful to 
review core skb functions proactively and add an skb_orphan_frags 
everywhere where the frags could be referenced from other places.
Any opinion about this?

Regards,

Zoltan

             reply	other threads:[~2014-05-14 13:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 13:40 Zoltan Kiss [this message]
2014-05-14 14:23 ` Moving frags and SKBTX_DEV_ZEROCOPY skbs Eric Dumazet
2014-05-14 14:23 ` Eric Dumazet
2014-05-14 17:42   ` David Miller
2014-05-14 17:52     ` Eric Dumazet
2014-05-14 17:52     ` Eric Dumazet
2014-05-14 17:42   ` David Miller
2014-05-14 19:41   ` Zoltan Kiss
2014-05-14 19:41   ` Zoltan Kiss
2014-05-14 19:52     ` Eric Dumazet
2014-05-14 19:52     ` Eric Dumazet
2014-05-15 17:14     ` Zoltan Kiss
2014-05-15 17:14     ` Zoltan Kiss
  -- strict thread matches above, loose matches on Subject: below --
2014-05-14 13:40 Zoltan Kiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53737266.5040601@citrix.com \
    --to=zoltan.kiss@citrix.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.