From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: libxl: default behavior when libxl fail to map an
	IRQ
Date: Wed, 14 May 2014 17:48:05 +0100
Message-ID: <53739E45.9090903@linaro.org>
References: <53739AFB.3020909@linaro.org>
	<1400085827.26934.18.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1400085827.26934.18.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 05/14/2014 05:43 PM, Ian Campbell wrote:
> On Wed, 2014-05-14 at 17:34 +0100, Julien Grall wrote:
>> Hello all,
>>
>> It seems that libxl continue to create the domain even when the function
>> domcreate_launch (tools/libxl/libxl_create.c) fails to map an IRQ to a
>> domain.
>>
>> I looked at the code and libxl only prints an error message when an
>> error occurred. It's the same thing for MMIO and ioport.
>>
>> Shouldn't we stop to create the domain when something is failing?
> 
> yeah, it seems like all three of those loops are missing a goto
> error_out.

Thanks for you answer. I will write a patch to add a goto in theses loop.

Regards,

-- 
Julien Grall