From: Helge Deller <deller@gmx.de>
To: Carlos O'Donell <carlos@systemhalted.org>,
John David Anglin <dave.anglin@bell.net>
Cc: linux-parisc List <linux-parisc@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH] parisc: Improve LWS-CAS performance
Date: Wed, 14 May 2014 21:12:41 +0200 [thread overview]
Message-ID: <5373C029.8080504@gmx.de> (raw)
In-Reply-To: <CAE2sS1i7gDUwq+bRoSNhw+kCBsA-cDAzHs4O03yHuWUxqJE-wQ@mail.gmail.com>
On 05/14/2014 05:31 AM, Carlos O'Donell wrote:
> On Sun, May 11, 2014 at 6:40 PM, John David Anglin <dave.anglin@bell.net> wrote:
>> 2) Removes the lock code on UP systems where it is not needed, and
>
> This is wrong. The locking was originally only for SMP, but at one
> point it was discovered that you could COW during the CAS operation
> and if you didn't take the lock in UP, you could re-enter the CAS via
> another task and thus incorrectly carry out the CAS in two different
> threads and corrupt the state. While we attempt our best to prevent
> the task running the CAS from being scheduled off, the COW operation
> trap and subsequent scheduling is not something I could find an easy
> way to prevent. Therefore the solution was to use locks for both UP
> and SMP.
If so, could one of you please send an updated patch to the list...?
Currently I've scheduled http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next&id=f4030047d92c79344ac4ca6ad4c6e3e22ceb5a55
for inclusion into the next kernel (hopefully 3.15).
Helge
next prev parent reply other threads:[~2014-05-14 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 22:40 [PATCH] parisc: Improve LWS-CAS performance John David Anglin
2014-05-12 6:11 ` Rolf Eike Beer
2014-05-12 14:33 ` John David Anglin
2014-05-12 15:04 ` Aw: " Helge Deller
2014-05-14 3:31 ` Carlos O'Donell
2014-05-14 19:12 ` Helge Deller [this message]
2014-05-14 19:28 ` John David Anglin
2014-05-15 12:33 ` [PATCH] parisc: Improve LWS-CAS performance (take 2) John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5373C029.8080504@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=carlos@systemhalted.org \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.