Re: [PATCH 1/3] bus: add Broadcom GISB bus arbiter timeout/error handler

[Randy Dunlap <rdunlap@infradead.org>]

On 05/14/2014 12:10 PM, Florian Fainelli wrote:
> This patch adds support for the Broadcom GISB arbiter bus timeout/error
> handler. GISB is a proprietary bus used by Broadcom Set Top Box
> System-on-a-chip devices (BCM7xxx) which allows multiple masters and
> clients to be interfaced with each other.
> 
> The bus arbiter offers support for generating two interrupts towards the
> host CPU, thus allowing us to "catch" clock gated masters, or masters
> being volontarily blocked for powersaving purposes, or do general system
> troubleshooting.
> 
> We also register a hook with the ARM fault exception handling to allow
> printing a more informative message than "imprecise external abort at
> 0x00000000" for instance.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/bus/Kconfig        |  11 +-
>  drivers/bus/Makefile       |   1 +
>  drivers/bus/brcmstb_gisb.c | 289 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 300 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/bus/brcmstb_gisb.c
> 
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 552373c4e362..985db51c0b11 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -40,5 +40,14 @@ config ARM_CCI
>  	depends on ARM
>  	help
>  	  Driver supporting the CCI cache coherent interconnect for ARM
> -	  platforms.
> +	  kplatforms.

Is that a typo?  if not, what are kplatforms?

> +
> +config BRCMSTB_GISB_ARB
> +	bool "Broadcom STB GISB bus arbiter"
> +	depends on ARM
> +	help
> +	  Driver for the Broadcom Set Top Box System-on-a-chip internal bus
> +	  arbiter. This driver provides timeout and target abort error handling
> +	  and internal bus master decoding.
> +
>  endmenu


-- 
~Randy