From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCHv5 4/5] dt-bindings: add documentation for Exynos3250 clock controller Date: Thu, 15 May 2014 04:46:48 +0900 Message-ID: <5373C828.1010804@samsung.com> References: <1399986308-23744-1-git-send-email-cw00.choi@samsung.com> <1399986308-23744-5-git-send-email-cw00.choi@samsung.com> <5373C589.9080405@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f50.google.com ([209.85.220.50]:65362 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbaENTq5 (ORCPT ); Wed, 14 May 2014 15:46:57 -0400 In-Reply-To: <5373C589.9080405@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tomasz Figa Cc: Chanwoo Choi , kgene.kim@samsung.com, t.figa@samsung.com, Mark Rutland , Randy Dunlap , tushar.behera@linaro.org, sajjan.linux@gmail.com, linux-samsung-soc@vger.kernel.org, linux@arm.linux.org.uk, arnd@arndb.de, sachin.kamat@linaro.org, thomas.abraham@linaro.org, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , marc.zyngier@arm.com, inki.dae@samsung.com, Rob Herring , ben-linux@fluff.org, Mike Turquette , linux-arm-kernel@lists.infradead.org, hyunhee.kim@samsung.com, sw0312.kim@samsung.com, linux-kernel@vger.kernel.org, yj44.cho@samsung.com, kyungmin.park@samsung.com, Kumar Gala , olof@lixom.net, chanho61.park@samsung.com On 05/15/14 04:35, Tomasz Figa wrote: > Hi, > > On 13.05.2014 15:05, Chanwoo Choi wrote: >> The Exynos3250 clocks are statically listed and registered using the >> Samsung specific common clock helper functions. Both device tree based >> clock lookup and clkdev based clock lookups are supported. >> >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Tomasz Figa >> Acked-by: Kyungmin Park >> Cc: Mike Turquette >> Cc: Kukjin Kim >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Ian Campbell >> Cc: Kumar Gala >> Cc: Randy Dunlap >> Cc: Tomasz Figa >> --- >> .../devicetree/bindings/clock/exynos3250-clock.txt | 41 ++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/exynos3250-clock.txt >> >> diff --git a/Documentation/devicetree/bindings/clock/exynos3250-clock.txt b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt >> new file mode 100644 >> index 0000000..aadc9c5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt >> @@ -0,0 +1,41 @@ >> +* Samsung Exynos3250 Clock Controller >> + >> +The Exynos3250 clock controller generates and supplies clock to various >> +controllers within the Exynos3250 SoC. >> + >> +Required Properties: >> + >> +- compatible: should be one of the following. >> + - "samsung,exynos3250-cmu" - controller compatible with Exynos3250 SoC. >> + >> +- reg: physical base address of the controller and length of memory mapped >> + region. >> + >> +- #clock-cells: should be 1. >> + >> +Each clock is assigned an identifier and client nodes can use this identifier >> +to specify the clock which they consume. >> + >> +All available clocks are defined as preprocessor macros in >> +dt-bindings/clock/exynos3250.h header and can be used in device >> +tree sources. >> + >> +Example 1: An example of a clock controller node is listed below. >> + >> + cmu: clock-controller@10030000 { >> + compatible = "samsung,exynos3250-cmu"; >> + reg =<0x10030000 0x20000>; >> + #clock-cells =<1>; >> + }; >> + >> +Example 2: UART controller node that consumes the clock generated by the clock >> + controller. Refer to the standard clock bindings for information >> + about 'clocks' and 'clock-names' property. >> + >> + serial@13800000 { >> + compatible = "samsung,exynos4210-uart"; >> + reg =<0x13800000 0x100>; >> + interrupts =<0 109 0>; >> + clocks =<&cmu CLK_UART0>,<&cmu CLK_SCLK_UART0>; >> + clock-names = "uart", "clk_uart_baud0"; >> + }; >> > > Oops, I've forgotten to apply this one. Since it doesn't have any > dependencies, Kukjin, could you apply it on top of my pull requests with > my Ack? Thanks in advance. > > Acked-by: Tomasz Figa > Sure, I will do it on your 4/4 pull-request after pulling it into samsung tree. Thanks, Kukjin From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Thu, 15 May 2014 04:46:48 +0900 Subject: [PATCHv5 4/5] dt-bindings: add documentation for Exynos3250 clock controller In-Reply-To: <5373C589.9080405@gmail.com> References: <1399986308-23744-1-git-send-email-cw00.choi@samsung.com> <1399986308-23744-5-git-send-email-cw00.choi@samsung.com> <5373C589.9080405@gmail.com> Message-ID: <5373C828.1010804@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/15/14 04:35, Tomasz Figa wrote: > Hi, > > On 13.05.2014 15:05, Chanwoo Choi wrote: >> The Exynos3250 clocks are statically listed and registered using the >> Samsung specific common clock helper functions. Both device tree based >> clock lookup and clkdev based clock lookups are supported. >> >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Tomasz Figa >> Acked-by: Kyungmin Park >> Cc: Mike Turquette >> Cc: Kukjin Kim >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Ian Campbell >> Cc: Kumar Gala >> Cc: Randy Dunlap >> Cc: Tomasz Figa >> --- >> .../devicetree/bindings/clock/exynos3250-clock.txt | 41 ++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/exynos3250-clock.txt >> >> diff --git a/Documentation/devicetree/bindings/clock/exynos3250-clock.txt b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt >> new file mode 100644 >> index 0000000..aadc9c5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt >> @@ -0,0 +1,41 @@ >> +* Samsung Exynos3250 Clock Controller >> + >> +The Exynos3250 clock controller generates and supplies clock to various >> +controllers within the Exynos3250 SoC. >> + >> +Required Properties: >> + >> +- compatible: should be one of the following. >> + - "samsung,exynos3250-cmu" - controller compatible with Exynos3250 SoC. >> + >> +- reg: physical base address of the controller and length of memory mapped >> + region. >> + >> +- #clock-cells: should be 1. >> + >> +Each clock is assigned an identifier and client nodes can use this identifier >> +to specify the clock which they consume. >> + >> +All available clocks are defined as preprocessor macros in >> +dt-bindings/clock/exynos3250.h header and can be used in device >> +tree sources. >> + >> +Example 1: An example of a clock controller node is listed below. >> + >> + cmu: clock-controller at 10030000 { >> + compatible = "samsung,exynos3250-cmu"; >> + reg =<0x10030000 0x20000>; >> + #clock-cells =<1>; >> + }; >> + >> +Example 2: UART controller node that consumes the clock generated by the clock >> + controller. Refer to the standard clock bindings for information >> + about 'clocks' and 'clock-names' property. >> + >> + serial at 13800000 { >> + compatible = "samsung,exynos4210-uart"; >> + reg =<0x13800000 0x100>; >> + interrupts =<0 109 0>; >> + clocks =<&cmu CLK_UART0>,<&cmu CLK_SCLK_UART0>; >> + clock-names = "uart", "clk_uart_baud0"; >> + }; >> > > Oops, I've forgotten to apply this one. Since it doesn't have any > dependencies, Kukjin, could you apply it on top of my pull requests with > my Ack? Thanks in advance. > > Acked-by: Tomasz Figa > Sure, I will do it on your 4/4 pull-request after pulling it into samsung tree. Thanks, Kukjin