From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5373D66F.4080801@cogentembedded.com> Date: Thu, 15 May 2014 00:47:43 +0400 From: Sergei Shtylyov MIME-Version: 1.0 References: <1400080168-16625-1-git-send-email-vyasevic@redhat.com> <1400080168-16625-4-git-send-email-vyasevic@redhat.com> In-Reply-To: <1400080168-16625-4-git-send-email-vyasevic@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next 3/8] bridge: Add functionality to sync static fdb entries to hw List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vlad Yasevich , netdev@vger.kernel.org Cc: john.r.fastabend@intel.com, shemminger@vyatta.com, bridge@lists.linux-foundation.org, jhs@mojatatu.com, mst@redhat.com On 05/14/2014 07:09 PM, Vlad Yasevich wrote: > Add code that allows static fdb entires to be synced to the > hw list for a specified port. This will be used later to > program ports that can function in non-promiscuous mode. > Signed-off-by: Vlad Yasevich > --- > net/bridge/br_fdb.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++ > net/bridge/br_private.h | 2 ++ > 2 files changed, 58 insertions(+) > diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c > index 9203d5a..9759b61 100644 > --- a/net/bridge/br_fdb.c > +++ b/net/bridge/br_fdb.c > @@ -874,3 +874,59 @@ int br_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[], > out: > return err; > } > + > +int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p) > +{ > + struct net_bridge_fdb_entry *fdb, *tmp = NULL; Again, initializer doesn't seem to be needed. > + int i; > + int err = 0; This one as well. [...] WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next 3/8] bridge: Add functionality to sync static fdb entries to hw Date: Thu, 15 May 2014 00:47:43 +0400 Message-ID: <5373D66F.4080801@cogentembedded.com> References: <1400080168-16625-1-git-send-email-vyasevic@redhat.com> <1400080168-16625-4-git-send-email-vyasevic@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: john.r.fastabend@intel.com, shemminger@vyatta.com, bridge@lists.linux-foundation.org, jhs@mojatatu.com, mst@redhat.com To: Vlad Yasevich , netdev@vger.kernel.org Return-path: In-Reply-To: <1400080168-16625-4-git-send-email-vyasevic@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 05/14/2014 07:09 PM, Vlad Yasevich wrote: > Add code that allows static fdb entires to be synced to the > hw list for a specified port. This will be used later to > program ports that can function in non-promiscuous mode. > Signed-off-by: Vlad Yasevich > --- > net/bridge/br_fdb.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++ > net/bridge/br_private.h | 2 ++ > 2 files changed, 58 insertions(+) > diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c > index 9203d5a..9759b61 100644 > --- a/net/bridge/br_fdb.c > +++ b/net/bridge/br_fdb.c > @@ -874,3 +874,59 @@ int br_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[], > out: > return err; > } > + > +int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p) > +{ > + struct net_bridge_fdb_entry *fdb, *tmp = NULL; Again, initializer doesn't seem to be needed. > + int i; > + int err = 0; This one as well. [...] WBR, Sergei