All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Grover <agrover@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH] block: Export REQ_FLUSH status via sysfs
Date: Wed, 14 May 2014 17:29:16 -0700	[thread overview]
Message-ID: <53740A5C.1040103@redhat.com> (raw)
In-Reply-To: <1400112663.7127.64.camel@haakon3.risingtidesystems.com>

On 05/14/2014 05:11 PM, Nicholas A. Bellinger wrote:
> On Wed, 2014-05-14 at 15:51 -0700, Andy Grover wrote:
>> Whether this is set or not is important for whether good performance is
>> possible, when using the block device as a backstore for the kernel
>> target. Exposing this will let kernel target configuration tools provide
>> this information to the user when configuring LIO targets.
>>
>
> The whole point is that IBLOCK detects if WCE is enabled on the
> underlying block_device at creation time using these same flags, and
> sets its own WCE bit automatically without any user interaction.
>
> The user should not be allowed to change the WCE bit to something
> different from what the underlying block_device is reporting.
>
> That said, I don't see the point of this patch for target related logic.

My understanding is that a LIO target backed by a block device that 
doesn't support REQ_FLUSH will have subpar performance.

Userspace configuration tools could potentially warn the user if this is 
the case.

This information doesn't appear to be currently available to userspace.

Regards -- Andy

      reply	other threads:[~2014-05-15  0:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 22:51 [PATCH] block: Export REQ_FLUSH status via sysfs Andy Grover
2014-05-15  0:11 ` Nicholas A. Bellinger
2014-05-15  0:29   ` Andy Grover [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53740A5C.1040103@redhat.com \
    --to=agrover@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.