From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.active-venture.com ([67.228.131.205]:63099 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbaEOEor (ORCPT ); Thu, 15 May 2014 00:44:47 -0400 Message-ID: <53744636.8080104@roeck-us.net> Date: Wed, 14 May 2014 21:44:38 -0700 From: Guenter Roeck MIME-Version: 1.0 To: Viresh Kumar , wim@iguana.be CC: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arun.ramamurthy@broadcom.com, stable@vger.kernel.org Subject: Re: [PATCH] watchdog: sp805: Set watchdog_device->timeout from ->set_timeout() References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 05/14/2014 09:31 PM, Viresh Kumar wrote: > Implementation of ->set_timeout() is supposed to set 'timeout' field of 'struct > watchdog_device' passed to it. sp805 was rather setting this in a local > variable. Fix it. > > Cc: # 2.6.36+ > Reported-by: Arun Ramamurthy > Signed-off-by: Viresh Kumar Reviewed-by: Guenter Roeck From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Wed, 14 May 2014 21:44:38 -0700 Subject: [PATCH] watchdog: sp805: Set watchdog_device->timeout from ->set_timeout() In-Reply-To: References: Message-ID: <53744636.8080104@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/14/2014 09:31 PM, Viresh Kumar wrote: > Implementation of ->set_timeout() is supposed to set 'timeout' field of 'struct > watchdog_device' passed to it. sp805 was rather setting this in a local > variable. Fix it. > > Cc: # 2.6.36+ > Reported-by: Arun Ramamurthy > Signed-off-by: Viresh Kumar Reviewed-by: Guenter Roeck