From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Thu, 15 May 2014 07:47:48 +0200
Subject: [U-Boot] [PATCH v2 1/4] bootm: make use of legacy image format
	configurable
In-Reply-To: <53735086.5060901@monstr.eu>
References: <1400064863-32085-1-git-send-email-hs@denx.de>
	<1400064863-32085-2-git-send-email-hs@denx.de>
	<53735086.5060901@monstr.eu>
Message-ID: <53745504.2030709@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Michal,

Am 14.05.2014 13:16, schrieb Michal Simek:
> On 05/14/2014 12:54 PM, Heiko Schocher wrote:
>> make the use of legacy image format configurable through
>> the config define CONFIG_IMAGE_FORMAT_LEGACY.
>>
>> When relying on signed FIT images with required signature check
>> the legacy image format should be disabled. Therefore introduce
>> this new define and enable legacy image format if CONFIG_FIT_SIGNATURE
>> is not set. If CONFIG_FIT_SIGNATURE is set disable per default
>> the legacy image format.
>>
>> Signed-off-by: Heiko Schocher<hs@denx.de>
>> Cc: Simon Glass<sjg@chromium.org>
>> Cc: Lars Steubesand<lars.steubesand@philips.com>
>> Cc: Mike Pearce<mike@kaew.be>
>> Cc: Wolfgang Denk<wd@denx.de>
>> Cc: Tom Rini<trini@ti.com>
>> Cc: Michal Simek<monstr@monstr.eu>
>> Cc: Michael Conrad<Michael.Conrad@ids.de>
>>
>> ---
>> - changes for v2:
>>    - make the legacy image format configurable through
>>      the define CONFIG_IMAGE_FORMAT_LEGACY.
>>
>>      Default:
>>      if not CONFIG_FIT_SIGNATURE is defined it is enabled,
>>      else disabled.
>>
>>      Disable it with CONFIG_DISABLE_IMAGE_LEGACY if
>>      CONFIG_FIT_SIGNATURE is not defined.
>
> Just a note that ifdef CONFIG_IMAGE_FORMAT_LEGACY
> should be also used in SPL code.

I think thats the case, as I did the default settings in
include/config_defaults.h and a MAKEALL for arm and powerpc
dropped no compiler errors/warnings.

This is just a first step to deactivate legacy image format.
A complete remove patch of it needs more work/time ...

> But that means that FIT image with signature feature
> should be enabled for SPL.

Why?

> If possible please also enable CONFIG_IMAGE_FORMAT_LEGACY
> for zynq because we are using legacy formats too.

You mean in "include/configs/zynq-common.h" ?
Prepared this for v3, but I could not test it...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany