All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: of: display_timing: remove two unsafe error messages
Date: Thu, 15 May 2014 10:47:30 +0000	[thread overview]
Message-ID: <53749B42.2090605@ti.com> (raw)
In-Reply-To: <1399985901-30756-1-git-send-email-l.stach@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

On 13/05/14 15:58, Lucas Stach wrote:
> The error message would try to dereference the pointer that
> just has been tested to be NULL. As those messages don't
> really add any value without the info that the np could
> provide, just remove them.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/video/of_display_timing.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

Thanks, queued for 3.16.

 Tomi




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-05-15 10:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 12:58 [PATCH] video: of: display_timing: remove two unsafe error messages Lucas Stach
2014-05-15 10:47 ` Tomi Valkeinen [this message]
2018-02-19 21:47 ` [PATCH] video: of: display_timing: Remove of_display_timings_exist() function Vladimir Zapolskiy
2018-02-19 21:47   ` Vladimir Zapolskiy
2018-03-12 15:48   ` Bartlomiej Zolnierkiewicz
2018-03-12 15:48     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53749B42.2090605@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.