From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WkvOx-0003A6-DG
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:08:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WkvOp-0001eg-Sy
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:08:47 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43853 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WkvOp-0001eO-Nd
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:08:39 -0400
Message-ID: <5374BC55.9020301@suse.de>
Date: Thu, 15 May 2014 15:08:37 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1400095810-27684-1-git-send-email-ehabkost@redhat.com>	<1400095810-27684-17-git-send-email-ehabkost@redhat.com>
	<8738gb9r2d.fsf@elfo.mitica>
In-Reply-To: <8738gb9r2d.fsf@elfo.mitica>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for
 migratability status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org

Am 15.05.2014 14:14, schrieb Juan Quintela:
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>> From: Marcelo Tosatti <mtosatti@redhat.com>
>>
>> Check vmsd for unmigratable field, allowing migratibility status
>> to be modified after vmstate_register.
>>
>> Cc: Juan Quintela <quintela@redhat.com>
>> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>=20
> I agree with the patch spirt, but what happens if we want to disable
> migration in a device that has no VMSD?

As the patch shows, no non-VMSD device setting no_migrate exists today.
Do you expect any to appear? I'm rather seeing more and more devices
getting converted to VMSD.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg