From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leonid Yegoshin Subject: Re: [PATCH 16/27] mips: Use common bits from generic tlb.h Date: Thu, 15 May 2014 11:02:17 -0700 Message-ID: <53750129.6060902@imgtec.com> References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-17-git-send-email-richard@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailapp01.imgtec.com ([195.59.15.196]:59974 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752916AbaEOSCY (ORCPT ); Thu, 15 May 2014 14:02:24 -0400 In-Reply-To: <1400093999-18703-17-git-send-email-richard@nod.at> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Richard Weinberger Cc: linux-arch@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, Ralf Baechle , John Crispin , Markos Chandras , linux-mips@linux-mips.org On 05/14/2014 11:59 AM, Richard Weinberger wrote: > It is no longer needed to define them on our own. > > Cc: Ralf Baechle > Cc: John Crispin > Cc: Markos Chandras > Cc: Leonid Yegoshin > Cc: Richard Weinberger > Cc: linux-mips@linux-mips.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Richard Weinberger > --- > arch/mips/include/asm/tlb.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/mips/include/asm/tlb.h b/arch/mips/include/asm/tlb.h > index 4a23493..5ea43ca 100644 > --- a/arch/mips/include/asm/tlb.h > +++ b/arch/mips/include/asm/tlb.h > @@ -10,13 +10,6 @@ > if (!tlb->fullmm) \ > flush_cache_range(vma, vma->vm_start, vma->vm_end); \ > } while (0) > -#define tlb_end_vma(tlb, vma) do { } while (0) > -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) > - > -/* > - * .. because we flush the whole mm when it fills up. > - */ > -#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm) > > #define UNIQUE_ENTRYHI(idx) \ > ((CKSEG0 + ((idx) << (PAGE_SHIFT + 1))) | \ I would like to know why these functions are eliminated (don't find any clue). Is it just because there will be a generic one or the calls would be eliminated? And if there are generic - can I tune it later? Explanation of Q: MIPS R6 architecture has now TLBINV instruction which eliminates TLB elements only for specific ASID (read here - "mm_struct") and I would like to use it for efficiency in tlb_flush()/flush_tlb_mm. (Not sure about tlb_end_vma()/ __tlb_remove_tlb_entry() yet) - Leonid. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 15 May 2014 20:02:35 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:15645 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6854768AbaEOSC2NvC2B (ORCPT ); Thu, 15 May 2014 20:02:28 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 91F83FA7975DA; Thu, 15 May 2014 19:02:18 +0100 (IST) Received: from KLMAIL02.kl.imgtec.org (192.168.5.97) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.181.6; Thu, 15 May 2014 19:02:21 +0100 Received: from BAMAIL02.ba.imgtec.org (192.168.66.28) by klmail02.kl.imgtec.org (192.168.5.97) with Microsoft SMTP Server (TLS) id 14.3.181.6; Thu, 15 May 2014 19:02:21 +0100 Received: from [192.168.65.146] (192.168.65.146) by bamail02.ba.imgtec.org (192.168.66.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 15 May 2014 11:02:18 -0700 Message-ID: <53750129.6060902@imgtec.com> Date: Thu, 15 May 2014 11:02:17 -0700 From: Leonid Yegoshin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Richard Weinberger CC: , , , Ralf Baechle , "John Crispin" , Markos Chandras , Subject: Re: [PATCH 16/27] mips: Use common bits from generic tlb.h References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-17-git-send-email-richard@nod.at> In-Reply-To: <1400093999-18703-17-git-send-email-richard@nod.at> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.65.146] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 40114 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Leonid.Yegoshin@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 05/14/2014 11:59 AM, Richard Weinberger wrote: > It is no longer needed to define them on our own. > > Cc: Ralf Baechle > Cc: John Crispin > Cc: Markos Chandras > Cc: Leonid Yegoshin > Cc: Richard Weinberger > Cc: linux-mips@linux-mips.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Richard Weinberger > --- > arch/mips/include/asm/tlb.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/mips/include/asm/tlb.h b/arch/mips/include/asm/tlb.h > index 4a23493..5ea43ca 100644 > --- a/arch/mips/include/asm/tlb.h > +++ b/arch/mips/include/asm/tlb.h > @@ -10,13 +10,6 @@ > if (!tlb->fullmm) \ > flush_cache_range(vma, vma->vm_start, vma->vm_end); \ > } while (0) > -#define tlb_end_vma(tlb, vma) do { } while (0) > -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) > - > -/* > - * .. because we flush the whole mm when it fills up. > - */ > -#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm) > > #define UNIQUE_ENTRYHI(idx) \ > ((CKSEG0 + ((idx) << (PAGE_SHIFT + 1))) | \ I would like to know why these functions are eliminated (don't find any clue). Is it just because there will be a generic one or the calls would be eliminated? And if there are generic - can I tune it later? Explanation of Q: MIPS R6 architecture has now TLBINV instruction which eliminates TLB elements only for specific ASID (read here - "mm_struct") and I would like to use it for efficiency in tlb_flush()/flush_tlb_mm. (Not sure about tlb_end_vma()/ __tlb_remove_tlb_entry() yet) - Leonid.