From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
ARM kernel mailing list
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 9/9] cgroup: use cgroup->self.refcnt for cgroup refcnting
Date: Thu, 15 May 2014 13:07:14 -0600 [thread overview]
Message-ID: <53751062.2050401@wwwdotorg.org> (raw)
In-Reply-To: <1399670015-23463-10-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On 05/09/2014 03:13 PM, Tejun Heo wrote:
> Currently cgroup implements refcnting separately using atomic_t
> cgroup->refcnt. The destruction paths of cgroup and css are rather
> complex and bear a lot of similiarities including the use of RCU and
> bouncing to a work item.
>
> This patch makes cgroup use the refcnt of self css for refcnting
> instead of using its own. This makes cgroup refcnting use css's
> percpu refcnt and share the destruction mechanism.
>...
In next-20150515, this patch causes silent boot failures on NVIDIA Tegra
ARM systems. There isn't even any earlyprintk. Reverting this one patch
solves this.
I was a bit surprised that cgroups would cause such an issue, but
looking at a normal kernel boot, I guess cgroup does get initialized
very early:
Uncompressing Linux... done, booting the kernel.
[ 0.000000] Booting Linux on physical CPU 0x0
[ 0.000000] Initializing cgroup subsys cpu
[ 0.000000] Initializing cgroup subsys cpuacct
Anyway, I'll try to track down what the problem is, but if someone
familiar with this patch could give it a look, that'd be very useful,
since I'm not at all familiar with this code or feature.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/9] cgroup: use cgroup->self.refcnt for cgroup refcnting
Date: Thu, 15 May 2014 13:07:14 -0600 [thread overview]
Message-ID: <53751062.2050401@wwwdotorg.org> (raw)
In-Reply-To: <1399670015-23463-10-git-send-email-tj@kernel.org>
On 05/09/2014 03:13 PM, Tejun Heo wrote:
> Currently cgroup implements refcnting separately using atomic_t
> cgroup->refcnt. The destruction paths of cgroup and css are rather
> complex and bear a lot of similiarities including the use of RCU and
> bouncing to a work item.
>
> This patch makes cgroup use the refcnt of self css for refcnting
> instead of using its own. This makes cgroup refcnting use css's
> percpu refcnt and share the destruction mechanism.
>...
In next-20150515, this patch causes silent boot failures on NVIDIA Tegra
ARM systems. There isn't even any earlyprintk. Reverting this one patch
solves this.
I was a bit surprised that cgroups would cause such an issue, but
looking at a normal kernel boot, I guess cgroup does get initialized
very early:
Uncompressing Linux... done, booting the kernel.
[ 0.000000] Booting Linux on physical CPU 0x0
[ 0.000000] Initializing cgroup subsys cpu
[ 0.000000] Initializing cgroup subsys cpuacct
Anyway, I'll try to track down what the problem is, but if someone
familiar with this patch could give it a look, that'd be very useful,
since I'm not at all familiar with this code or feature.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Tejun Heo <tj@kernel.org>, lizefan@huawei.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
ARM kernel mailing list <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 9/9] cgroup: use cgroup->self.refcnt for cgroup refcnting
Date: Thu, 15 May 2014 13:07:14 -0600 [thread overview]
Message-ID: <53751062.2050401@wwwdotorg.org> (raw)
In-Reply-To: <1399670015-23463-10-git-send-email-tj@kernel.org>
On 05/09/2014 03:13 PM, Tejun Heo wrote:
> Currently cgroup implements refcnting separately using atomic_t
> cgroup->refcnt. The destruction paths of cgroup and css are rather
> complex and bear a lot of similiarities including the use of RCU and
> bouncing to a work item.
>
> This patch makes cgroup use the refcnt of self css for refcnting
> instead of using its own. This makes cgroup refcnting use css's
> percpu refcnt and share the destruction mechanism.
>...
In next-20150515, this patch causes silent boot failures on NVIDIA Tegra
ARM systems. There isn't even any earlyprintk. Reverting this one patch
solves this.
I was a bit surprised that cgroups would cause such an issue, but
looking at a normal kernel boot, I guess cgroup does get initialized
very early:
Uncompressing Linux... done, booting the kernel.
[ 0.000000] Booting Linux on physical CPU 0x0
[ 0.000000] Initializing cgroup subsys cpu
[ 0.000000] Initializing cgroup subsys cpuacct
Anyway, I'll try to track down what the problem is, but if someone
familiar with this patch could give it a look, that'd be very useful,
since I'm not at all familiar with this code or feature.
next prev parent reply other threads:[~2014-05-15 19:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 21:13 [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 2/9] cgroup: rename cgroup->dummy_css to ->self and move it to the top Tejun Heo
2014-05-09 21:13 ` [PATCH 4/9] cgroup: move check_for_release(parent) call to the end of cgroup_destroy_locked() Tejun Heo
[not found] ` <1399670015-23463-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-09 21:13 ` [PATCH 1/9] cgroup: use restart_syscall() for mount retries Tejun Heo
2014-05-09 21:13 ` Tejun Heo
[not found] ` <1399670015-23463-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-14 2:53 ` Li Zefan
2014-05-14 2:53 ` Li Zefan
2014-05-14 13:12 ` [PATCH v2 " Tejun Heo
2014-05-14 13:12 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 3/9] cgroup: separate out cgroup_has_live_children() from cgroup_destroy_locked() Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 5/9] cgroup: move cgroup->sibling unlinking to cgroup_put() Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 8/9] cgroup: enable refcnting for root csses Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-14 3:15 ` [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Li Zefan
2014-05-14 3:15 ` Li Zefan
2014-05-14 17:04 ` Tejun Heo
2014-05-14 17:04 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 6/9] cgroup: remove cgroup_destory_css_killed() Tejun Heo
2014-05-09 21:13 ` [PATCH 7/9] cgroup: bounce css release through css->destroy_work Tejun Heo
2014-05-09 21:13 ` [PATCH 9/9] cgroup: use cgroup->self.refcnt for cgroup refcnting Tejun Heo
[not found] ` <1399670015-23463-10-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-15 19:07 ` Stephen Warren [this message]
2014-05-15 19:07 ` Stephen Warren
2014-05-15 19:07 ` Stephen Warren
2014-05-15 21:56 ` Stephen Warren
2014-05-15 21:56 ` Stephen Warren
2014-05-16 14:37 ` Tejun Heo
2014-05-16 14:37 ` Tejun Heo
[not found] ` <20140516143718.GA5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 15:43 ` [PATCH cgroup/for-3.16] cgroup: introduce CSS_NO_REF and skip refcnting on normal root csses Tejun Heo
2014-05-16 15:43 ` Tejun Heo
2014-05-16 15:43 ` Tejun Heo
[not found] ` <20140516154330.GB5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 16:59 ` Stephen Warren
2014-05-16 16:59 ` Stephen Warren
2014-05-16 16:59 ` Stephen Warren
[not found] ` <537643F9.1030303-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-16 17:09 ` [PATCH v2 " Tejun Heo
2014-05-16 17:09 ` Tejun Heo
2014-05-16 17:09 ` Tejun Heo
[not found] ` <20140516170959.GG5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 17:19 ` Stephen Warren
2014-05-16 17:19 ` Stephen Warren
2014-05-16 17:19 ` Stephen Warren
[not found] ` <5376489C.9010902-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-16 17:23 ` Tejun Heo
2014-05-16 17:23 ` Tejun Heo
2014-05-16 17:23 ` Tejun Heo
2014-05-13 16:59 ` [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53751062.2050401@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.