Re: [Xenomai] RTDM rework (2)

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2014-05-15 20:40, Gilles Chanteperdrix wrote:
> On 05/14/2014 04:30 PM, Jan Kiszka wrote:
>> Hi Gilles,
>>
>> On 2014-05-10 18:11, Gilles Chanteperdrix wrote:
>>> Hi Jan,
>>>
>>> I have pushed a new version which addresses your comments in the
>>> "for-forge-rtdm-rework" branch.
>>>
>>> You can ignore the "whitespace cleanup" commit, it is just there to
>>> allow me to simply commit without whitespace issues, it will be removed
>>> later on.
>>>
>>> Note that analogy has not been updated to the API change, I will address
>>> this later, if you agree with the current version.
>>
>> Looks good.
>>
>> Minor note on rtdm_device::open/socket doc: They are running
>> non-real-time context, and the documentation should mention this clearly
>> (compare to the regular file ops with their two variants).
>>
>> I can't look at the implementation, unfortunately.
> 
> I have submitted the pull request in order to move forward, but we can
> still do some changes afterward.

Ack.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux