Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On 05/15/2014 01:13 PM, Luiz Capitulino wrote:
> On Wed, 14 May 2014 16:07:49 +0200
> Benoît Canet <benoit.canet@irqsave.net> wrote:
> 
>> The purpose of this change is to help create a json file containing
>> common definitions; each bit of generated C code must be emitted
>> only one time.
>>
>> A second history global to all QAPISchema instances has been added
>> to detect when a file is included more than one time and skip these
>> includes.
>> It does not act as a stack and the changes made to it by the
>> __init__ function are propagated back to the caller so it's really
>> a global state.
> 
> Shouldn't this behavior be noted somewhere? Eg. in writing-qmp-commands.txt
> or qapi-code-gen.txt?

dosc/qapi-code-gen.txt already covers the {'include':'file'} syntax, so
yes, that should be updated to mention that multiple includes of the
same file are now safe.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]