From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl3t6-0005NF-Uh for qemu-devel@nongnu.org; Thu, 15 May 2014 18:12:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wl3sz-0000MA-Eb for qemu-devel@nongnu.org; Thu, 15 May 2014 18:12:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53766 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl3sz-0000Kb-7x for qemu-devel@nongnu.org; Thu, 15 May 2014 18:12:21 -0400 Message-ID: <53753BC2.1090604@suse.de> Date: Fri, 16 May 2014 00:12:18 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1398876525-28831-1-git-send-email-ehabkost@redhat.com> <1398876525-28831-15-git-send-email-ehabkost@redhat.com> <53751931.4000503@suse.de> <20140515202626.GX3302@otherpad.lan.raisama.net> In-Reply-To: <20140515202626.GX3302@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Igor Mammedov , Paolo Bonzini , Aurelien Jarno , Richard Henderson Am 15.05.2014 22:26, schrieb Eduardo Habkost: > On Thu, May 15, 2014 at 09:44:49PM +0200, Andreas F=E4rber wrote: >> Am 30.04.2014 18:48, schrieb Eduardo Habkost: >>> This flag will allow the user to choose between two modes: >>> * All flags that can be enabled on the host, even if unmigratable >>> (migratable=3Dno); >>> * All flags that can be enabled on the host, known to QEMU, >>> and migratable (migratable=3Dyes). >>> >>> The default is still migratable=3Dfalse, to keep current behavior, bu= t >>> this will be changed to migratable=3Dtrue by another patch. >>> >>> My plan was to support the "migratable" flag on all CPU classes, but >>> have the default to "false" on all CPU models except "host". However, >>> DeviceClass has no mechanism to allow a child class to have a differe= nt >>> property default from the parent class yet, so by now only the "host" >>> CPU model will support the "migratable" flag. >> >> Just set the new default in the derived type's instance_init? >=20 > That would work. I am still assuming that one day we will allow > management to query for class property defaults without instantiating > objects. But even if we do it, "host" is already an exception (because > the defaults depend on KVM initialization), so in this case it will be > OK. >=20 > So, this patch can be dropped because it will be replaced. I will also > implement the other changes you requested for this patch. Before you make yourself too much work, have a peek at qom-cpu. :) I should have all except 15 and 18, with some cleanups TBD. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg