Re: [PATCH] ethdev: remove experimental flag of ports enumeration

[Thomas Monjalon <thomas@monjalon.net>]

25/04/2018 12:21, Ferruh Yigit:
> On 4/24/2018 3:15 AM, Thomas Monjalon wrote:
> > The basic operations for ports enumeration should not be
> > considered as experimental in DPDK 18.05.
> > 
> > The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
> > It uses the function the rte_eth_find_next_owned_by() to get
> > only ownerless ports. Its API can be considered stable.
> > So the flag experimental is removed from rte_eth_find_next_owned_by().
> > 
> > The flag experimental is removed from rte_eth_dev_count_avail()
> > which is the new name of the old function rte_eth_dev_count().
> > 
> > The flag experimental is set to rte_eth_dev_count_total()
> > in the .c file for consistency with the declaration in the .h file.
> > 
> > A lot of internal applications are fixed to not allow experimental API.
> > 
> > Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> > Fixes: d9a42a69febf ("ethdev: deprecate port count function")
> > Fixes: e70e26861eaf ("net/mvpp2: fix build")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Getting some build errors [1], it seems some samples are using some other
> experimental APIs so that we can't remove the flag for them.
> 
> 
> [1]
> .../dpdk/examples/tep_termination/main.c: In function ‘main’:
> .../dpdk/examples/tep_termination/main.c:1209:3: error: ‘rte_ctrl_thread_create’
> is deprecated: Symbol is not yet part of stable ABI
> [-Werror=deprecated-declarations]
>    ret = rte_ctrl_thread_create(&tid, "print-stats", NULL,
>    ^~~
> 
> .../dpdk/examples/vhost/main.c: In function ‘main’:
> .../dpdk/examples/vhost/main.c:1497:3: error: ‘rte_ctrl_thread_create’ is
> deprecated: Symbol is not yet part of stable ABI [-Werror=deprecated-declarations]
>    ret = rte_ctrl_thread_create(&tid, "print-stats", NULL,
>    ^~~

Ah sorry, I think it is due to a change in next-net.
I have prepared this patch on master.

Please can you fix it when applying?