All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] tools: bpf_jit_disasm: ignore image address for disasm
Date: Fri, 16 May 2014 11:34:58 +0200	[thread overview]
Message-ID: <5375DBC2.4040307@redhat.com> (raw)
In-Reply-To: <1400194599-5247-2-git-send-email-ast@plumgrid.com>

On 05/16/2014 12:56 AM, Alexei Starovoitov wrote:
> seccomp filters use kernel JIT image addresses, so bpf_jit_enable=2 prints
> [ 20.146438] flen=3 proglen=82 pass=0 image=0000000000000000
> [ 20.146442] JIT code: 00000000: 55 48 89 e5 48 81 ec 28 02 00 00 ...
>
> ignore image address, so that seccomp filters can be disassembled
>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>

Looks good to me! Thanks for using bpf_jit_disasm, hope it was of
great help. ;)

Acked-by: Daniel Borkmann <dborkman@redhat.com>

  reply	other threads:[~2014-05-16  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 22:56 [PATCH net-next 0/2] tools: bpf_jit_disasm: trivial fixes Alexei Starovoitov
2014-05-15 22:56 ` [PATCH net-next 1/2] tools: bpf_jit_disasm: ignore image address for disasm Alexei Starovoitov
2014-05-16  9:34   ` Daniel Borkmann [this message]
2014-05-15 22:56 ` [PATCH net-next 2/2] tools: bpf_jit_disasm: increase image buffer size Alexei Starovoitov
2014-05-16  9:35   ` Daniel Borkmann
2014-05-16 20:44 ` [PATCH net-next 0/2] tools: bpf_jit_disasm: trivial fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5375DBC2.4040307@redhat.com \
    --to=dborkman@redhat.com \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.