Re: [PATCH v6 1/6] xen/arm: IRQ: Store IRQ type in arch_irq_desc

[Julien Grall <julien.grall@linaro.org>]

On 05/16/2014 11:16 AM, Ian Campbell wrote:
> On Thu, 2014-05-15 at 18:03 +0100, Julien Grall wrote:
>> On 05/15/2014 04:45 PM, Ian Campbell wrote:
>>>> +int irq_set_type(unsigned int spi, unsigned int type)
>>>> +{
>>>> +    unsigned long flags;
>>>> +    struct irq_desc *desc = irq_to_desc(spi);
>>>> +    int ret = -EBUSY;
>>>> +
>>>> +    /* This function should not be used for other than SPIs */
>>>
>>> Perhaps name the function irq_set_spi_type or something then?
>>>
>>>> +    for_each_cpu( cpu, &cpu_online_map )
>>>> +    {
>>>> +        desc = &per_cpu(local_irq_desc, cpu)[irq];
>>>> +        spin_lock_irqsave(&desc->lock, flags);
>>>> +        desc->arch.type = type;
>>>
>>> Don't you need to write ICFGR on each CPU?
>>
>> This function will bail out if local_irqs_type[irq] == DT_IRQ_TYPE_INVALID.
> 
> Did you mean != ?

Yes. We only want to configure IRQs that as not been configured.

Regards,

-- 
Julien Grall