From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v1 RFC 0/6] KVM: s390: cpu model implementation Date: Fri, 16 May 2014 13:32:09 +0200 Message-ID: <5375F739.2090903@de.ibm.com> References: <1399993114-15333-1-git-send-email-mimu@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1399993114-15333-1-git-send-email-mimu@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Michael Mueller , qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Cornelia Huck , Alexander Graf , Gleb Natapov , Paolo Bonzini , Richard Henderson , Andreas Faerber , "Jason J. Herne" List-ID: On 13/05/14 16:58, Michael Mueller wrote: > The proposed patch set implements S390 cpu model support in kvm. A cpu > model is defined by a triple comprizing the cpu type , the cpu facility > set and instruction blocking control. A consumer requests a feasible > combination of that that triple before vcpu creation. All subsequently > created vcpu's will use this cpu configuration. > > Michael Mueller (6): > s390/sclp: add sclp_get_ibc function > KVM: s390: split SIE state guest prefix field > KVM: s390: use facilities and cpu_id per KVM > KVM: s390: add ibc api > KVM: s390: initial implementation of soft facilities > KVM: s390: add cpu model support > > arch/s390/include/asm/kvm_host.h | 13 +- > arch/s390/include/asm/sclp.h | 1 + > arch/s390/include/uapi/asm/kvm.h | 23 ++++ > arch/s390/kvm/Makefile | 2 +- > arch/s390/kvm/diag.c | 2 +- > arch/s390/kvm/gaccess.c | 4 +- > arch/s390/kvm/gaccess.h | 8 +- > arch/s390/kvm/ibc.c | 29 +++++ > arch/s390/kvm/kvm-s390.c | 263 +++++++++++++++++++++++++++++++++------ > arch/s390/kvm/kvm-s390.h | 43 ++++++- > arch/s390/kvm/priv.c | 16 ++- > arch/s390/kvm/softfac.c | 38 ++++++ > drivers/s390/char/sclp_early.c | 12 +- > 13 files changed, 397 insertions(+), 57 deletions(-) > create mode 100644 arch/s390/kvm/ibc.c > create mode 100644 arch/s390/kvm/softfac.c > I will add patch 1 and 2 to the next KVM: s390: pull request as there does not seem to be potential for discussion / interface changes. Everything else looks ok, but I want to wait if additional feedback about the overall design comes in. Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlGNF-0005e4-Cw for qemu-devel@nongnu.org; Fri, 16 May 2014 07:32:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlGN6-0006ZC-AZ for qemu-devel@nongnu.org; Fri, 16 May 2014 07:32:25 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:40338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlGN6-0006Z0-1x for qemu-devel@nongnu.org; Fri, 16 May 2014 07:32:16 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 May 2014 12:32:14 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B271517D8056 for ; Fri, 16 May 2014 12:33:20 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4GBWBCQ21299298 for ; Fri, 16 May 2014 11:32:11 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4GBWAKK017315 for ; Fri, 16 May 2014 05:32:10 -0600 Message-ID: <5375F739.2090903@de.ibm.com> Date: Fri, 16 May 2014 13:32:09 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1399993114-15333-1-git-send-email-mimu@linux.vnet.ibm.com> In-Reply-To: <1399993114-15333-1-git-send-email-mimu@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 RFC 0/6] KVM: s390: cpu model implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Mueller , qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Gleb Natapov , Alexander Graf , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson On 13/05/14 16:58, Michael Mueller wrote: > The proposed patch set implements S390 cpu model support in kvm. A cpu > model is defined by a triple comprizing the cpu type , the cpu facility > set and instruction blocking control. A consumer requests a feasible > combination of that that triple before vcpu creation. All subsequently > created vcpu's will use this cpu configuration. > > Michael Mueller (6): > s390/sclp: add sclp_get_ibc function > KVM: s390: split SIE state guest prefix field > KVM: s390: use facilities and cpu_id per KVM > KVM: s390: add ibc api > KVM: s390: initial implementation of soft facilities > KVM: s390: add cpu model support > > arch/s390/include/asm/kvm_host.h | 13 +- > arch/s390/include/asm/sclp.h | 1 + > arch/s390/include/uapi/asm/kvm.h | 23 ++++ > arch/s390/kvm/Makefile | 2 +- > arch/s390/kvm/diag.c | 2 +- > arch/s390/kvm/gaccess.c | 4 +- > arch/s390/kvm/gaccess.h | 8 +- > arch/s390/kvm/ibc.c | 29 +++++ > arch/s390/kvm/kvm-s390.c | 263 +++++++++++++++++++++++++++++++++------ > arch/s390/kvm/kvm-s390.h | 43 ++++++- > arch/s390/kvm/priv.c | 16 ++- > arch/s390/kvm/softfac.c | 38 ++++++ > drivers/s390/char/sclp_early.c | 12 +- > 13 files changed, 397 insertions(+), 57 deletions(-) > create mode 100644 arch/s390/kvm/ibc.c > create mode 100644 arch/s390/kvm/softfac.c > I will add patch 1 and 2 to the next KVM: s390: pull request as there does not seem to be potential for discussion / interface changes. Everything else looks ok, but I want to wait if additional feedback about the overall design comes in. Christian