Re: [Qemu-devel] [PATCH v4] qapi: skip redundant includes

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

On 05/16/2014 04:51 AM, Benoît Canet wrote:
> The purpose of this change is to help create a json file containing
> common definitions; each bit of generated C code must be emitted
> only one time.
> 
> A second history global to all QAPISchema instances has been added
> to detect when a file is included more than one time and skip these
> includes.
> It does not act as a stack and the changes made to it by the
> __init__ function are propagated back to the caller so it's really
> a global state.
> 
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  docs/qapi-code-gen.txt                        |  2 +-

Looks like the only addition.

> +++ b/docs/qapi-code-gen.txt
> @@ -48,7 +48,7 @@ The QAPI schema definitions can be modularized using the 'include' directive:
>   { 'include': 'path/to/file.json'}
>  
>  The directive is evaluated recursively, and include paths are relative to the
> -file using the directive.
> +file using the directive. Multiple includes of the same file are safe.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]