From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WlHou-0001R2-1t for ath10k@lists.infradead.org; Fri, 16 May 2014 13:05:05 +0000 Message-ID: <53760CEA.1000500@candelatech.com> Date: Fri, 16 May 2014 06:04:42 -0700 From: Ben Greear MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: fix rssi reporting. References: <1400178894-26206-1-git-send-email-greearb@candelatech.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Janusz Dziedzic Cc: "ath10k@lists.infradead.org" On 05/16/2014 05:18 AM, Janusz Dziedzic wrote: > On 15 May 2014 20:34, wrote: >> From: Ben Greear >> >> When the driver cannot provide proper rssi, mark >> status with RX_FLAG_NO_SIGNAL_VAL so that stack >> properly ignores it. >> > I think we should skip this one while we know rssi/rates. > They are correct for all packets between START_VALID and END_VALID flags. Skip what, the patch? With current code, you are sending packets up the tree without signal being set and yet without the flag set that says to ignore the (unset) signal value. Thanks, Ben > > BR > Janusz > >> Signed-off-by: Ben Greear >> --- >> >> Patch is against my tree, hopefully will apply OK against upstream >> but have not tested that yet. >> >> drivers/net/wireless/ath/ath10k/htt_rx.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c >> index 0c83ffb..d8ec8dd 100644 >> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c >> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c >> @@ -1216,11 +1216,12 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt, >> mpdu_ranges = htt_rx_ind_get_mpdu_ranges(rx); >> >> /* Fill this once, while this is per-ppdu */ >> - if (rx->ppdu.info0 & HTT_RX_INDICATION_INFO0_START_VALID) { >> - memset(rx_status, 0, sizeof(*rx_status)); >> + memset(rx_status, 0, sizeof(*rx_status)); >> + if (rx->ppdu.info0 & HTT_RX_INDICATION_INFO0_START_VALID) >> rx_status->signal = ATH10K_DEFAULT_NOISE_FLOOR + >> rx->ppdu.combined_rssi; >> - } >> + else >> + rx_status->flag |= RX_FLAG_NO_SIGNAL_VAL; >> >> if (rx->ppdu.info0 & HTT_RX_INDICATION_INFO0_END_VALID) { >> /* TSF available only in 32-bit */ >> -- >> 1.7.11.7 >> >> >> _______________________________________________ >> ath10k mailing list >> ath10k@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/ath10k > -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k