From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 18/19] block/sheepdog: Fix silent sd_open(), sd_create() failures
Date: Fri, 16 May 2014 07:06:47 -0600 [thread overview]
Message-ID: <53760D67.2020909@redhat.com> (raw)
In-Reply-To: <1400230826-18009-19-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
On 05/16/2014 03:00 AM, Markus Armbruster wrote:
> Open and create methods must set an error when they fail.
>
> Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> block/sheepdog.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-16 13:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 9:00 [Qemu-devel] [PATCH v2 00/19] block: Purge qerror_report() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 01/19] blockdev: Don't use qerror_report_err() in drive_init() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 02/19] blockdev: Don't use qerror_report() in do_drive_del() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 03/19] qemu-nbd: Don't use qerror_report() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 04/19] block/rbd: Propagate errors to open and create methods Markus Armbruster
2014-05-16 12:06 ` Eric Blake
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 05/19] block/ssh: Drop superfluous libssh2_session_last_errno() calls Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 06/19] block/ssh: Propagate errors through check_host_key() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 07/19] block/ssh: Propagate errors through authenticate() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 08/19] block/ssh: Propagate errors through connect_to_ssh() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 09/19] block/ssh: Propagate errors to open and create methods Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 10/19] block/vvfat: Propagate errors through enable_write_target() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 11/19] block/vvfat: Propagate errors through init_directories() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 12/19] block/sheepdog: Propagate errors through connect_to_sdog() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 13/19] block/sheepdog: Propagate errors through get_sheep_fd() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 14/19] block/sheepdog: Propagate errors through sd_prealloc() Markus Armbruster
2014-05-16 13:05 ` Eric Blake
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 15/19] block/sheepdog: Propagate errors through do_sd_create() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 16/19] block/sheepdog: Propagate errors through find_vdi_name() Markus Armbruster
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 17/19] block/sheepdog: Propagate errors to open and create methods Markus Armbruster
2014-05-16 13:06 ` Eric Blake
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 18/19] block/sheepdog: Fix silent sd_open(), sd_create() failures Markus Armbruster
2014-05-16 13:06 ` Eric Blake [this message]
2014-05-16 9:00 ` [Qemu-devel] [PATCH v2 19/19] block/sheepdog: Don't use qerror_report() Markus Armbruster
2014-05-23 15:40 ` [Qemu-devel] [PATCH v2 00/19] block: Purge qerror_report() Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53760D67.2020909@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.