From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ming Lei <tom.leiming@gmail.com>,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] virtio_blk: fix race between start and stop queue
Date: Fri, 16 May 2014 08:58:33 -0600 [thread overview]
Message-ID: <53762799.2080403@kernel.dk> (raw)
In-Reply-To: <20140516145450.GA5939@infradead.org>
On 2014-05-16 08:54, Christoph Hellwig wrote:
> On Fri, May 16, 2014 at 08:53:22AM -0600, Jens Axboe wrote:
>>> This patch fixes the problem by starting/stopping blk-mq
>>> with holding vq_lock.
>>
>> Why not just use blk_mq_start_hw_queues()?
>
> That would kick off a work item on every I/O completion, something
> you didn't particularly like in scsi-mq :)
It would suck, I sent a followup after that one :-)
And yes, it still needs improving in scsi-mq too.
--
Jens Axboe
next prev parent reply other threads:[~2014-05-16 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 12:33 [PATCH] virtio_blk: fix race between start and stop queue Ming Lei
2014-05-16 1:59 ` Rusty Russell
2014-05-19 0:26 ` Ming Lei
2014-05-16 14:53 ` Jens Axboe
2014-05-16 14:54 ` Christoph Hellwig
2014-05-16 14:58 ` Jens Axboe [this message]
2014-05-16 14:57 ` Jens Axboe
2014-05-16 15:15 ` Ming Lei
2014-05-16 15:17 ` Jens Axboe
2014-05-16 15:22 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53762799.2080403@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.