Re: [Qemu-devel] [PATCH] doc: add "setup" to list of migration states

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

On 05/16/2014 08:40 AM, peter@gridcentric.ca wrote:
> From: Peter Feiner <peter@gridcentric.ca>
> 
> On a slow VM (e.g., nested), you see the "setup" state when you query the
> migration status.
> 
> Signed-off-by: Peter Feiner <peter@gridcentric.ca>
> ---
>  qapi-schema.json |    2 +-
>  qmp-commands.hx  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 36cb964..f4ffede 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -691,7 +691,7 @@
>  # Information about current migration process.
>  #
>  # @status: #optional string describing the current migration status.
> -#          As of 0.14.0 this can be 'active', 'completed', 'failed' or
> +#          As of 0.14.0 this can be 'setup', 'active', 'completed', 'failed' or

You know, it would be even nicer to convert from an open-coded 'str' to
a finite enum of valid strings; it would be self-documenting, and make
it that much easier to guarantee the code doesn't add new states without
documenting when they were added.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]