From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel.a@redhat.com>
Cc: mst@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com,
jcmvbkbc@gmail.com, edgar.iglesias@gmail.com,
gxt@mprc.pku.edu.cn, Rob Herring <robh@kernel.org>,
proljc@gmail.com, agraf@suse.de, scottwood@freescale.com,
borntraeger@de.ibm.com, hpoussin@reactos.org,
aliguori@amazon.com, lersek@redhat.com, chouteau@adacore.com,
jan.kiszka@web.de, stefanha@redhat.com, pbonzini@redhat.com,
cornelia.huck@de.ibm.com, lcapitulino@redhat.com,
peter.crosthwaite@xilinx.com, armbru@redhat.com,
michael@walle.cc, qemu-ppc@nongnu.org, peter.chubb@nicta.com.au,
aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState
Date: Fri, 16 May 2014 20:33:26 +0200 [thread overview]
Message-ID: <537659F6.3090705@suse.de> (raw)
In-Reply-To: <20140516163959.7583df51@thinkpad>
[-- Attachment #1: Type: text/plain, Size: 2108 bytes --]
Am 16.05.2014 16:39, schrieb Igor Mammedov:
> On Wed, 7 May 2014 17:42:57 +0300
> Marcel Apfelbaum <marcel.a@redhat.com> wrote:
>
>> Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields
>> are copied into MachineState. Removed duplicated fields from MachineState.
>>
>> All the other changes are only mechanical refactoring, no semantic changes.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
>> ---
>> - I am perfectly aware that patches touching a lot of files
>> are not desirable, but this one is a very simple replacement
>> patch:
>> QEMUMachineInitArgs -> MachineState
>> args -> ms
>> - This is the simplest way to get rid of QEMUMachineInitArgs fast.
>>
> Patch doesn't apply cleanly on current master
patch -p1 applied all hunks ...
>
> [...]
>
>>
>> #define PC_Q35_MACHINE_OPTIONS \
>> diff --git a/hw/i386/xen_machine_pv.c b/hw/i386/xen_machine_pv.c
>> index 9adb57f..fb7a817 100644
>> --- a/hw/i386/xen_machine_pv.c
>> +++ b/hw/i386/xen_machine_pv.c
>> @@ -28,11 +28,11 @@
> ^^^ file was moved
... and prompted for the hw/xenpv/xen_machine_pv.c path.
> I've reviewed all targets, it looks good.
> +1 to afaerber's comment s/ms/machine/
4 "args->" were missed in exynos4_boards.c debug output.
for f in hw/*/*.c; do
sed -i 's/*ms\\)/*machine\\)/g' $f
sed -i 's/*ms,/*machine,/g' $f
sed -i 's/ ms->/ machine->/g' $f
sed -i 's/(ms->/(machine->/g' $f
sed -i 's/!ms->/!machine->/g' $f
sed -i 's/(ms)/(machine)/g' $f
sed -i 's/(ms,/(machine,/g' $f
sed -i 's/ ms,/ machine,/g' $f
sed -i 's/, ms)/, machine)/g' $f
done
git checkout -- hw/ppc/ppc4xx_pci.c # false "(ms," positive
highbank.c had a conflicting "machine" argument -> machine_id.
e500.c needed tweaking due to passing ms in a struct. And it was
shallow-copying *ms, which must not be done for QOM. Passing the pointer
instead.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[-- Attachment #2: ms_machine.diff --]
[-- Type: text/x-patch, Size: 97310 bytes --]
diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
index ab4647a..b178a03 100644
--- a/hw/alpha/dp264.c
+++ b/hw/alpha/dp264.c
@@ -43,13 +43,13 @@ static int clipper_pci_map_irq(PCIDevice *d, int irq_num)
return (slot + 1) * 4 + irq_num;
}
-static void clipper_init(MachineState *ms)
+static void clipper_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
AlphaCPU *cpus[4];
PCIBus *pci_bus;
ISABus *isa_bus;
diff --git a/hw/arm/collie.c b/hw/arm/collie.c
index 59715e1..ed7851f 100644
--- a/hw/arm/collie.c
+++ b/hw/arm/collie.c
@@ -23,12 +23,12 @@ static struct arm_boot_info collie_binfo = {
.ram_size = 0x20000000,
};
-static void collie_init(MachineState *ms)
+static void collie_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
StrongARMState *s;
DriveInfo *dinfo;
MemoryRegion *sysmem = get_system_memory();
diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c
index ea4c2ab..e2260e3 100644
--- a/hw/arm/cubieboard.c
+++ b/hw/arm/cubieboard.c
@@ -30,7 +30,7 @@ typedef struct CubieBoardState {
MemoryRegion sdram;
} CubieBoardState;
-static void cubieboard_init(MachineState *ms)
+static void cubieboard_init(MachineState *machine)
{
CubieBoardState *s = g_new(CubieBoardState, 1);
Error *err = NULL;
@@ -63,14 +63,15 @@ static void cubieboard_init(MachineState *ms)
exit(1);
}
- memory_region_init_ram(&s->sdram, NULL, "cubieboard.ram", ms->ram_size);
+ memory_region_init_ram(&s->sdram, NULL, "cubieboard.ram",
+ machine->ram_size);
vmstate_register_ram_global(&s->sdram);
memory_region_add_subregion(get_system_memory(), AW_A10_SDRAM_BASE,
&s->sdram);
- cubieboard_binfo.ram_size = ms->ram_size;
- cubieboard_binfo.kernel_filename = ms->kernel_filename;
- cubieboard_binfo.kernel_cmdline = ms->kernel_cmdline;
+ cubieboard_binfo.ram_size = machine->ram_size;
+ cubieboard_binfo.kernel_filename = machine->kernel_filename;
+ cubieboard_binfo.kernel_cmdline = machine->kernel_cmdline;
arm_load_kernel(&s->a10->cpu, &cubieboard_binfo);
}
diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
index cb905f9..d1424ee 100644
--- a/hw/arm/digic_boards.c
+++ b/hw/arm/digic_boards.c
@@ -143,7 +143,7 @@ static DigicBoard digic4_board_canon_a1100 = {
.rom1_def_filename = "canon-a1100-rom1.bin",
};
-static void canon_a1100_init(MachineState *ms)
+static void canon_a1100_init(MachineState *machine)
{
digic4_board_init(&digic4_board_canon_a1100);
}
diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c
index 688f117..d644db1 100644
--- a/hw/arm/exynos4_boards.c
+++ b/hw/arm/exynos4_boards.c
@@ -94,7 +94,7 @@ static void lan9215_init(uint32_t base, qemu_irq irq)
}
}
-static Exynos4210State *exynos4_boards_init_common(MachineState *ms,
+static Exynos4210State *exynos4_boards_init_common(MachineState *machine,
Exynos4BoardType board_type)
{
if (smp_cpus != EXYNOS4210_NCPUS && !qtest_enabled()) {
@@ -108,9 +108,9 @@ static Exynos4210State *exynos4_boards_init_common(MachineState *ms,
exynos4_board_binfo.board_id = exynos4_board_id[board_type];
exynos4_board_binfo.smp_bootreg_addr =
exynos4_board_smp_bootreg_addr[board_type];
- exynos4_board_binfo.kernel_filename = ms->kernel_filename;
- exynos4_board_binfo.initrd_filename = ms->initrd_filename;
- exynos4_board_binfo.kernel_cmdline = ms->kernel_cmdline;
+ exynos4_board_binfo.kernel_filename = machine->kernel_filename;
+ exynos4_board_binfo.initrd_filename = machine->initrd_filename;
+ exynos4_board_binfo.kernel_cmdline = machine->kernel_cmdline;
exynos4_board_binfo.gic_cpu_if_addr =
EXYNOS4210_SMP_PRIVATE_BASE_ADDR + 0x100;
@@ -120,24 +120,24 @@ static Exynos4210State *exynos4_boards_init_common(MachineState *ms,
" initrd_filename: %s\n",
exynos4_board_ram_size[board_type] / 1048576,
exynos4_board_ram_size[board_type],
- args->kernel_filename,
- args->kernel_cmdline,
- args->initrd_filename);
+ machine->kernel_filename,
+ machine->kernel_cmdline,
+ machine->initrd_filename);
return exynos4210_init(get_system_memory(),
exynos4_board_ram_size[board_type]);
}
-static void nuri_init(MachineState *ms)
+static void nuri_init(MachineState *machine)
{
- exynos4_boards_init_common(ms, EXYNOS4_BOARD_NURI);
+ exynos4_boards_init_common(machine, EXYNOS4_BOARD_NURI);
arm_load_kernel(ARM_CPU(first_cpu), &exynos4_board_binfo);
}
-static void smdkc210_init(MachineState *ms)
+static void smdkc210_init(MachineState *machine)
{
- Exynos4210State *s = exynos4_boards_init_common(ms,
+ Exynos4210State *s = exynos4_boards_init_common(machine,
EXYNOS4_BOARD_SMDKC210);
lan9215_init(SMDK_LAN9118_BASE_ADDR,
diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c
index 9caf554..3f8465e 100644
--- a/hw/arm/gumstix.c
+++ b/hw/arm/gumstix.c
@@ -46,7 +46,7 @@
static const int sector_len = 128 * 1024;
-static void connex_init(MachineState *ms)
+static void connex_init(MachineState *machine)
{
PXA2xxState *cpu;
DriveInfo *dinfo;
@@ -83,9 +83,9 @@ static void connex_init(MachineState *ms)
qdev_get_gpio_in(cpu->gpio, 36));
}
-static void verdex_init(MachineState *ms)
+static void verdex_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
+ const char *cpu_model = machine->cpu_model;
PXA2xxState *cpu;
DriveInfo *dinfo;
int be;
diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index 423496f..8340434 100644
--- a/hw/arm/highbank.c
+++ b/hw/arm/highbank.c
@@ -199,13 +199,13 @@ enum cxmachines {
* 32-bit host, set the reg value of memory to 0xf7ff00000 in the
* device tree and pass -m 2047 to QEMU.
*/
-static void calxeda_init(MachineState *ms, enum cxmachines machine)
+static void calxeda_init(MachineState *machine, enum cxmachines machine_id)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
DeviceState *dev = NULL;
SysBusDevice *busdev;
qemu_irq pic[128];
@@ -217,7 +217,7 @@ static void calxeda_init(MachineState *ms, enum cxmachines machine)
char *sysboot_filename;
if (!cpu_model) {
- switch (machine) {
+ switch (machine_id) {
case CALXEDA_HIGHBANK:
cpu_model = "cortex-a9";
break;
@@ -274,7 +274,7 @@ static void calxeda_init(MachineState *ms, enum cxmachines machine)
}
}
- switch (machine) {
+ switch (machine_id) {
case CALXEDA_HIGHBANK:
dev = qdev_create(NULL, "l2x0");
qdev_init_nofail(dev);
@@ -359,14 +359,14 @@ static void calxeda_init(MachineState *ms, enum cxmachines machine)
arm_load_kernel(ARM_CPU(first_cpu), &highbank_binfo);
}
-static void highbank_init(MachineState *ms)
+static void highbank_init(MachineState *machine)
{
- calxeda_init(ms, CALXEDA_HIGHBANK);
+ calxeda_init(machine, CALXEDA_HIGHBANK);
}
-static void midway_init(MachineState *ms)
+static void midway_init(MachineState *machine)
{
- calxeda_init(ms, CALXEDA_MIDWAY);
+ calxeda_init(machine, CALXEDA_MIDWAY);
}
static QEMUMachine highbank_machine = {
diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c
index 05884e4..0e476c3 100644
--- a/hw/arm/integratorcp.c
+++ b/hw/arm/integratorcp.c
@@ -461,13 +461,13 @@ static struct arm_boot_info integrator_binfo = {
.board_id = 0x113,
};
-static void integratorcp_init(MachineState *ms)
+static void integratorcp_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
ARMCPU *cpu;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
diff --git a/hw/arm/kzm.c b/hw/arm/kzm.c
index dca3b74..0555d12 100644
--- a/hw/arm/kzm.c
+++ b/hw/arm/kzm.c
@@ -70,13 +70,13 @@ static struct arm_boot_info kzm_binfo = {
.board_id = 1722,
};
-static void kzm_init(MachineState *ms)
+static void kzm_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
ARMCPU *cpu;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c
index de1cdcb..44f1873 100644
--- a/hw/arm/mainstone.c
+++ b/hw/arm/mainstone.c
@@ -105,7 +105,7 @@ static struct arm_boot_info mainstone_binfo = {
};
static void mainstone_common_init(MemoryRegion *address_space_mem,
- MachineState *ms,
+ MachineState *machine,
enum mainstone_model_e model, int arm_id)
{
uint32_t sector_len = 256 * 1024;
@@ -116,7 +116,7 @@ static void mainstone_common_init(MemoryRegion *address_space_mem,
int i;
int be;
MemoryRegion *rom = g_new(MemoryRegion, 1);
- const char *cpu_model = ms->cpu_model;
+ const char *cpu_model = machine->cpu_model;
if (!cpu_model)
cpu_model = "pxa270-c5";
@@ -175,16 +175,16 @@ static void mainstone_common_init(MemoryRegion *address_space_mem,
smc91c111_init(&nd_table[0], MST_ETH_PHYS,
qdev_get_gpio_in(mst_irq, ETHERNET_IRQ));
- mainstone_binfo.kernel_filename = ms->kernel_filename;
- mainstone_binfo.kernel_cmdline = ms->kernel_cmdline;
- mainstone_binfo.initrd_filename = ms->initrd_filename;
+ mainstone_binfo.kernel_filename = machine->kernel_filename;
+ mainstone_binfo.kernel_cmdline = machine->kernel_cmdline;
+ mainstone_binfo.initrd_filename = machine->initrd_filename;
mainstone_binfo.board_id = arm_id;
arm_load_kernel(mpu->cpu, &mainstone_binfo);
}
-static void mainstone_init(MachineState *ms)
+static void mainstone_init(MachineState *machine)
{
- mainstone_common_init(get_system_memory(), ms, mainstone, 0x196);
+ mainstone_common_init(get_system_memory(), machine, mainstone, 0x196);
}
static QEMUMachine mainstone2_machine = {
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
index 0b95ca5..6a134f2 100644
--- a/hw/arm/musicpal.c
+++ b/hw/arm/musicpal.c
@@ -1569,12 +1569,12 @@ static struct arm_boot_info musicpal_binfo = {
.board_id = 0x20e,
};
-static void musicpal_init(MachineState *ms)
+static void musicpal_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
ARMCPU *cpu;
qemu_irq pic[32];
DeviceState *dev;
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index ae097d6..82772c6 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -1278,14 +1278,14 @@ static int n810_atag_setup(const struct arm_boot_info *info, void *p)
return n8x0_atag_setup(p, 810);
}
-static void n8x0_init(MachineState *ms,
+static void n8x0_init(MachineState *machine,
struct arm_boot_info *binfo, int model)
{
MemoryRegion *sysmem = get_system_memory();
struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s));
int sdram_size = binfo->ram_size;
- s->mpu = omap2420_mpu_init(sysmem, sdram_size, ms->cpu_model);
+ s->mpu = omap2420_mpu_init(sysmem, sdram_size, machine->cpu_model);
/* Setup peripherals
*
@@ -1329,18 +1329,18 @@ static void n8x0_init(MachineState *ms,
n8x0_usb_setup(s);
}
- if (ms->kernel_filename) {
+ if (machine->kernel_filename) {
/* Or at the linux loader. */
- binfo->kernel_filename = ms->kernel_filename;
- binfo->kernel_cmdline = ms->kernel_cmdline;
- binfo->initrd_filename = ms->initrd_filename;
+ binfo->kernel_filename = machine->kernel_filename;
+ binfo->kernel_cmdline = machine->kernel_cmdline;
+ binfo->initrd_filename = machine->initrd_filename;
arm_load_kernel(s->mpu->cpu, binfo);
qemu_register_reset(n8x0_boot_init, s);
}
if (option_rom[0].name &&
- (ms->boot_order[0] == 'n' || !ms->kernel_filename)) {
+ (machine->boot_order[0] == 'n' || !machine->kernel_filename)) {
uint8_t nolo_tags[0x10000];
/* No, wait, better start at the ROM. */
s->mpu->cpu->env.regs[15] = OMAP2_Q2_BASE + 0x400000;
@@ -1382,14 +1382,14 @@ static struct arm_boot_info n810_binfo = {
.atag_board = n810_atag_setup,
};
-static void n800_init(MachineState *ms)
+static void n800_init(MachineState *machine)
{
- return n8x0_init(ms, &n800_binfo, 800);
+ return n8x0_init(machine, &n800_binfo, 800);
}
-static void n810_init(MachineState *ms)
+static void n810_init(MachineState *machine)
{
- return n8x0_init(ms, &n810_binfo, 810);
+ return n8x0_init(machine, &n810_binfo, 810);
}
static QEMUMachine n800_machine = {
diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c
index 75b414b..b4f6da6 100644
--- a/hw/arm/omap_sx1.c
+++ b/hw/arm/omap_sx1.c
@@ -98,7 +98,7 @@ static struct arm_boot_info sx1_binfo = {
.board_id = 0x265,
};
-static void sx1_init(MachineState *ms, const int version)
+static void sx1_init(MachineState *machine, const int version)
{
struct omap_mpu_state_s *mpu;
MemoryRegion *address_space = get_system_memory();
@@ -118,7 +118,8 @@ static void sx1_init(MachineState *ms, const int version)
flash_size = flash2_size;
}
- mpu = omap310_mpu_init(address_space, sx1_binfo.ram_size, ms->cpu_model);
+ mpu = omap310_mpu_init(address_space, sx1_binfo.ram_size,
+ machine->cpu_model);
/* External Flash (EMIFS) */
memory_region_init_ram(flash, NULL, "omap_sx1.flash0-0", flash_size);
@@ -189,29 +190,29 @@ static void sx1_init(MachineState *ms, const int version)
OMAP_CS1_BASE, &cs[1]);
}
- if (!ms->kernel_filename && !fl_idx && !qtest_enabled()) {
+ if (!machine->kernel_filename && !fl_idx && !qtest_enabled()) {
fprintf(stderr, "Kernel or Flash image must be specified\n");
exit(1);
}
/* Load the kernel. */
- sx1_binfo.kernel_filename = ms->kernel_filename;
- sx1_binfo.kernel_cmdline = ms->kernel_cmdline;
- sx1_binfo.initrd_filename = ms->initrd_filename;
+ sx1_binfo.kernel_filename = machine->kernel_filename;
+ sx1_binfo.kernel_cmdline = machine->kernel_cmdline;
+ sx1_binfo.initrd_filename = machine->initrd_filename;
arm_load_kernel(mpu->cpu, &sx1_binfo);
/* TODO: fix next line */
//~ qemu_console_resize(ds, 640, 480);
}
-static void sx1_init_v1(MachineState *ms)
+static void sx1_init_v1(MachineState *machine)
{
- sx1_init(ms, 1);
+ sx1_init(machine, 1);
}
-static void sx1_init_v2(MachineState *ms)
+static void sx1_init_v2(MachineState *machine)
{
- sx1_init(ms, 2);
+ sx1_init(machine, 2);
}
static QEMUMachine sx1_machine_v2 = {
diff --git a/hw/arm/palm.c b/hw/arm/palm.c
index 1e1f47d..e61995f 100644
--- a/hw/arm/palm.c
+++ b/hw/arm/palm.c
@@ -191,12 +191,12 @@ static struct arm_boot_info palmte_binfo = {
.board_id = 0x331,
};
-static void palmte_init(MachineState *ms)
+static void palmte_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
MemoryRegion *address_space_mem = get_system_memory();
struct omap_mpu_state_s *mpu;
int flash_size = 0x00800000;
diff --git a/hw/arm/realview.c b/hw/arm/realview.c
index 8b2fe38..64b9251 100644
--- a/hw/arm/realview.c
+++ b/hw/arm/realview.c
@@ -45,7 +45,7 @@ static const int realview_board_id[] = {
0x76d
};
-static void realview_init(MachineState *ms,
+static void realview_init(MachineState *machine,
enum realview_board_type board_type)
{
ARMCPU *cpu = NULL;
@@ -71,7 +71,7 @@ static void realview_init(MachineState *ms,
uint32_t proc_id = 0;
uint32_t sys_id;
ram_addr_t low_ram_size;
- ram_addr_t ram_size = ms->ram_size;
+ ram_addr_t ram_size = machine->ram_size;
hwaddr periphbase = 0;
switch (board_type) {
@@ -91,7 +91,7 @@ static void realview_init(MachineState *ms,
break;
}
- cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, ms->cpu_model);
+ cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, machine->cpu_model);
if (!cpu_oc) {
fprintf(stderr, "Unable to find CPU definition\n");
exit(1);
@@ -342,45 +342,45 @@ static void realview_init(MachineState *ms,
memory_region_add_subregion(sysmem, SMP_BOOT_ADDR, ram_hack);
realview_binfo.ram_size = ram_size;
- realview_binfo.kernel_filename = ms->kernel_filename;
- realview_binfo.kernel_cmdline = ms->kernel_cmdline;
- realview_binfo.initrd_filename = ms->initrd_filename;
+ realview_binfo.kernel_filename = machine->kernel_filename;
+ realview_binfo.kernel_cmdline = machine->kernel_cmdline;
+ realview_binfo.initrd_filename = machine->initrd_filename;
realview_binfo.nb_cpus = smp_cpus;
realview_binfo.board_id = realview_board_id[board_type];
realview_binfo.loader_start = (board_type == BOARD_PB_A8 ? 0x70000000 : 0);
arm_load_kernel(ARM_CPU(first_cpu), &realview_binfo);
}
-static void realview_eb_init(MachineState *ms)
+static void realview_eb_init(MachineState *machine)
{
- if (!ms->cpu_model) {
- ms->cpu_model = "arm926";
+ if (!machine->cpu_model) {
+ machine->cpu_model = "arm926";
}
- realview_init(ms, BOARD_EB);
+ realview_init(machine, BOARD_EB);
}
-static void realview_eb_mpcore_init(MachineState *ms)
+static void realview_eb_mpcore_init(MachineState *machine)
{
- if (!ms->cpu_model) {
- ms->cpu_model = "arm11mpcore";
+ if (!machine->cpu_model) {
+ machine->cpu_model = "arm11mpcore";
}
- realview_init(ms, BOARD_EB_MPCORE);
+ realview_init(machine, BOARD_EB_MPCORE);
}
-static void realview_pb_a8_init(MachineState *ms)
+static void realview_pb_a8_init(MachineState *machine)
{
- if (!ms->cpu_model) {
- ms->cpu_model = "cortex-a8";
+ if (!machine->cpu_model) {
+ machine->cpu_model = "cortex-a8";
}
- realview_init(ms, BOARD_PB_A8);
+ realview_init(machine, BOARD_PB_A8);
}
-static void realview_pbx_a9_init(MachineState *ms)
+static void realview_pbx_a9_init(MachineState *machine)
{
- if (!ms->cpu_model) {
- ms->cpu_model = "cortex-a9";
+ if (!machine->cpu_model) {
+ machine->cpu_model = "cortex-a9";
}
- realview_init(ms, BOARD_PBX_A9);
+ realview_init(machine, BOARD_PBX_A9);
}
static QEMUMachine realview_eb_machine = {
diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c
index b116f00..5455dbf 100644
--- a/hw/arm/spitz.c
+++ b/hw/arm/spitz.c
@@ -887,14 +887,14 @@ static struct arm_boot_info spitz_binfo = {
.ram_size = 0x04000000,
};
-static void spitz_common_init(MachineState *ms,
+static void spitz_common_init(MachineState *machine,
enum spitz_model_e model, int arm_id)
{
PXA2xxState *mpu;
DeviceState *scp0, *scp1 = NULL;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *rom = g_new(MemoryRegion, 1);
- const char *cpu_model = ms->cpu_model;
+ const char *cpu_model = machine->cpu_model;
if (!cpu_model)
cpu_model = (model == terrier) ? "pxa270-c5" : "pxa270-c0";
@@ -935,32 +935,32 @@ static void spitz_common_init(MachineState *ms,
/* A 4.0 GB microdrive is permanently sitting in CF slot 0. */
spitz_microdrive_attach(mpu, 0);
- spitz_binfo.kernel_filename = ms->kernel_filename;
- spitz_binfo.kernel_cmdline = ms->kernel_cmdline;
- spitz_binfo.initrd_filename = ms->initrd_filename;
+ spitz_binfo.kernel_filename = machine->kernel_filename;
+ spitz_binfo.kernel_cmdline = machine->kernel_cmdline;
+ spitz_binfo.initrd_filename = machine->initrd_filename;
spitz_binfo.board_id = arm_id;
arm_load_kernel(mpu->cpu, &spitz_binfo);
sl_bootparam_write(SL_PXA_PARAM_BASE);
}
-static void spitz_init(MachineState *ms)
+static void spitz_init(MachineState *machine)
{
- spitz_common_init(ms, spitz, 0x2c9);
+ spitz_common_init(machine, spitz, 0x2c9);
}
-static void borzoi_init(MachineState *ms)
+static void borzoi_init(MachineState *machine)
{
- spitz_common_init(ms, borzoi, 0x33f);
+ spitz_common_init(machine, borzoi, 0x33f);
}
-static void akita_init(MachineState *ms)
+static void akita_init(MachineState *machine)
{
- spitz_common_init(ms, akita, 0x2e8);
+ spitz_common_init(machine, akita, 0x2e8);
}
-static void terrier_init(MachineState *ms)
+static void terrier_init(MachineState *machine)
{
- spitz_common_init(ms, terrier, 0x33f);
+ spitz_common_init(machine, terrier, 0x33f);
}
static QEMUMachine akitapda_machine = {
diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
index 2350fab..3b7a27a 100644
--- a/hw/arm/stellaris.c
+++ b/hw/arm/stellaris.c
@@ -1333,17 +1333,17 @@ static void stellaris_init(const char *kernel_filename, const char *cpu_model,
}
/* FIXME: Figure out how to generate these from stellaris_boards. */
-static void lm3s811evb_init(MachineState *ms)
+static void lm3s811evb_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
stellaris_init(kernel_filename, cpu_model, &stellaris_boards[0]);
}
-static void lm3s6965evb_init(MachineState *ms)
+static void lm3s6965evb_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
stellaris_init(kernel_filename, cpu_model, &stellaris_boards[1]);
}
diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c
index 2fbeaf5..abc0f2a 100644
--- a/hw/arm/tosa.c
+++ b/hw/arm/tosa.c
@@ -211,12 +211,12 @@ static struct arm_boot_info tosa_binfo = {
.ram_size = 0x04000000,
};
-static void tosa_init(MachineState *ms)
+static void tosa_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *rom = g_new(MemoryRegion, 1);
PXA2xxState *mpu;
diff --git a/hw/arm/versatilepb.c b/hw/arm/versatilepb.c
index acca596..dea5fc7 100644
--- a/hw/arm/versatilepb.c
+++ b/hw/arm/versatilepb.c
@@ -173,7 +173,7 @@ static int vpb_sic_init(SysBusDevice *sbd)
static struct arm_boot_info versatile_binfo;
-static void versatile_init(MachineState *ms, int board_id)
+static void versatile_init(MachineState *machine, int board_id)
{
ARMCPU *cpu;
MemoryRegion *sysmem = get_system_memory();
@@ -190,15 +190,15 @@ static void versatile_init(MachineState *ms, int board_id)
int done_smc = 0;
DriveInfo *dinfo;
- if (!ms->cpu_model) {
- ms->cpu_model = "arm926";
+ if (!machine->cpu_model) {
+ machine->cpu_model = "arm926";
}
- cpu = cpu_arm_init(ms->cpu_model);
+ cpu = cpu_arm_init(machine->cpu_model);
if (!cpu) {
fprintf(stderr, "Unable to find CPU definition\n");
exit(1);
}
- memory_region_init_ram(ram, NULL, "versatile.ram", ms->ram_size);
+ memory_region_init_ram(ram, NULL, "versatile.ram", machine->ram_size);
vmstate_register_ram_global(ram);
/* ??? RAM should repeat to fill physical memory space. */
/* SDRAM at address zero. */
@@ -344,22 +344,22 @@ static void versatile_init(MachineState *ms, int board_id)
fprintf(stderr, "qemu: Error registering flash memory.\n");
}
- versatile_binfo.ram_size = ms->ram_size;
- versatile_binfo.kernel_filename = ms->kernel_filename;
- versatile_binfo.kernel_cmdline = ms->kernel_cmdline;
- versatile_binfo.initrd_filename = ms->initrd_filename;
+ versatile_binfo.ram_size = machine->ram_size;
+ versatile_binfo.kernel_filename = machine->kernel_filename;
+ versatile_binfo.kernel_cmdline = machine->kernel_cmdline;
+ versatile_binfo.initrd_filename = machine->initrd_filename;
versatile_binfo.board_id = board_id;
arm_load_kernel(cpu, &versatile_binfo);
}
-static void vpb_init(MachineState *ms)
+static void vpb_init(MachineState *machine)
{
- versatile_init(ms, 0x183);
+ versatile_init(machine, 0x183);
}
-static void vab_init(MachineState *ms)
+static void vab_init(MachineState *machine)
{
- versatile_init(ms, 0x25e);
+ versatile_init(machine, 0x25e);
}
static QEMUMachine versatilepb_machine = {
diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c
index 1051387..33ff422 100644
--- a/hw/arm/vexpress.c
+++ b/hw/arm/vexpress.c
@@ -509,7 +509,7 @@ static pflash_t *ve_pflash_cfi01_register(hwaddr base, const char *name,
}
static void vexpress_common_init(VEDBoardInfo *daughterboard,
- MachineState *ms)
+ MachineState *machine)
{
DeviceState *dev, *sysctl, *pl041;
qemu_irq pic[64];
@@ -525,7 +525,8 @@ static void vexpress_common_init(VEDBoardInfo *daughterboard,
const hwaddr *map = daughterboard->motherboard_map;
int i;
- daughterboard->init(daughterboard, ms->ram_size, ms->cpu_model, pic);
+ daughterboard->init(daughterboard, machine->ram_size, machine->cpu_model,
+ pic);
/* Motherboard peripherals: the wiring is the same but the
* addresses vary between the legacy and A-Series memory maps.
@@ -639,10 +640,10 @@ static void vexpress_common_init(VEDBoardInfo *daughterboard,
pic[40 + i]);
}
- daughterboard->bootinfo.ram_size = ms->ram_size;
- daughterboard->bootinfo.kernel_filename = ms->kernel_filename;
- daughterboard->bootinfo.kernel_cmdline = ms->kernel_cmdline;
- daughterboard->bootinfo.initrd_filename = ms->initrd_filename;
+ daughterboard->bootinfo.ram_size = machine->ram_size;
+ daughterboard->bootinfo.kernel_filename = machine->kernel_filename;
+ daughterboard->bootinfo.kernel_cmdline = machine->kernel_cmdline;
+ daughterboard->bootinfo.initrd_filename = machine->initrd_filename;
daughterboard->bootinfo.nb_cpus = smp_cpus;
daughterboard->bootinfo.board_id = VEXPRESS_BOARD_ID;
daughterboard->bootinfo.loader_start = daughterboard->loader_start;
@@ -653,14 +654,14 @@ static void vexpress_common_init(VEDBoardInfo *daughterboard,
arm_load_kernel(ARM_CPU(first_cpu), &daughterboard->bootinfo);
}
-static void vexpress_a9_init(MachineState *ms)
+static void vexpress_a9_init(MachineState *machine)
{
- vexpress_common_init(&a9_daughterboard, ms);
+ vexpress_common_init(&a9_daughterboard, machine);
}
-static void vexpress_a15_init(MachineState *ms)
+static void vexpress_a15_init(MachineState *machine)
{
- vexpress_common_init(&a15_daughterboard, ms);
+ vexpress_common_init(&a15_daughterboard, machine);
}
static QEMUMachine vexpress_a9_machine = {
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 8399e81..3b55a4b 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -383,13 +383,13 @@ static void *machvirt_dtb(const struct arm_boot_info *binfo, int *fdt_size)
return board->fdt;
}
-static void machvirt_init(MachineState *ms)
+static void machvirt_init(MachineState *machine)
{
qemu_irq pic[NUM_IRQS];
MemoryRegion *sysmem = get_system_memory();
int n;
MemoryRegion *ram = g_new(MemoryRegion, 1);
- const char *cpu_model = ms->cpu_model;
+ const char *cpu_model = machine->cpu_model;
VirtBoardInfo *vbi;
if (!cpu_model) {
@@ -415,7 +415,7 @@ static void machvirt_init(MachineState *ms)
exit(1);
}
- if (ms->ram_size > vbi->memmap[VIRT_MEM].size) {
+ if (machine->ram_size > vbi->memmap[VIRT_MEM].size) {
error_report("mach-virt: cannot model more than 30GB RAM");
exit(1);
}
@@ -447,7 +447,7 @@ static void machvirt_init(MachineState *ms)
}
fdt_add_cpu_nodes(vbi);
- memory_region_init_ram(ram, NULL, "mach-virt.ram", ms->ram_size);
+ memory_region_init_ram(ram, NULL, "mach-virt.ram", machine->ram_size);
vmstate_register_ram_global(ram);
memory_region_add_subregion(sysmem, vbi->memmap[VIRT_MEM].base, ram);
@@ -461,10 +461,10 @@ static void machvirt_init(MachineState *ms)
*/
create_virtio_devices(vbi, pic);
- vbi->bootinfo.ram_size = ms->ram_size;
- vbi->bootinfo.kernel_filename = ms->kernel_filename;
- vbi->bootinfo.kernel_cmdline = ms->kernel_cmdline;
- vbi->bootinfo.initrd_filename = ms->initrd_filename;
+ vbi->bootinfo.ram_size = machine->ram_size;
+ vbi->bootinfo.kernel_filename = machine->kernel_filename;
+ vbi->bootinfo.kernel_cmdline = machine->kernel_cmdline;
+ vbi->bootinfo.initrd_filename = machine->initrd_filename;
vbi->bootinfo.nb_cpus = smp_cpus;
vbi->bootinfo.board_id = -1;
vbi->bootinfo.loader_start = vbi->memmap[VIRT_MEM].base;
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index bf64968..bae0416 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -101,13 +101,13 @@ static inline void zynq_init_spi_flashes(uint32_t base_addr, qemu_irq irq,
}
-static void zynq_init(MachineState *ms)
+static void zynq_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
ObjectClass *cpu_oc;
ARMCPU *cpu;
MemoryRegion *address_space_mem = get_system_memory();
diff --git a/hw/arm/z2.c b/hw/arm/z2.c
index bdab03a..ab9e4c9 100644
--- a/hw/arm/z2.c
+++ b/hw/arm/z2.c
@@ -300,12 +300,12 @@ static const TypeInfo aer915_info = {
.class_init = aer915_class_init,
};
-static void z2_init(MachineState *ms)
+static void z2_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
MemoryRegion *address_space_mem = get_system_memory();
uint32_t sector_len = 0x10000;
PXA2xxState *mpu;
diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
index 6409bea..1ec7c3b 100644
--- a/hw/core/null-machine.c
+++ b/hw/core/null-machine.c
@@ -15,7 +15,7 @@
#include "hw/hw.h"
#include "hw/boards.h"
-static void machine_none_init(MachineState *ms)
+static void machine_none_init(MachineState *machine)
{
}
diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c
index e20161e..1849338 100644
--- a/hw/cris/axis_dev88.c
+++ b/hw/cris/axis_dev88.c
@@ -243,12 +243,12 @@ static const MemoryRegionOps gpio_ops = {
static struct cris_load_info li;
static
-void axisdev88_init(MachineState *ms)
+void axisdev88_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
CRISCPU *cpu;
CPUCRISState *env;
DeviceState *dev;
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 4fbdaaa..f0c1e46 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -69,7 +69,7 @@ static bool smbios_legacy_mode;
static bool gigabyte_align = true;
/* PC hardware initialisation */
-static void pc_init1(MachineState *ms,
+static void pc_init1(MachineState *machine,
int pci_enabled,
int kvmclock_enabled)
{
@@ -106,7 +106,7 @@ static void pc_init1(MachineState *ms,
object_property_add_child(qdev_get_machine(), "icc-bridge",
OBJECT(icc_bridge), NULL);
- pc_cpus_init(ms->cpu_model, icc_bridge);
+ pc_cpus_init(machine->cpu_model, icc_bridge);
if (kvm_enabled() && kvmclock_enabled) {
kvmclock_create();
@@ -119,13 +119,13 @@ static void pc_init1(MachineState *ms,
* For old machine types, use whatever split we used historically to avoid
* breaking migration.
*/
- if (ms->ram_size >= 0xe0000000) {
+ if (machine->ram_size >= 0xe0000000) {
ram_addr_t lowmem = gigabyte_align ? 0xc0000000 : 0xe0000000;
- above_4g_mem_size = ms->ram_size - lowmem;
+ above_4g_mem_size = machine->ram_size - lowmem;
below_4g_mem_size = lowmem;
} else {
above_4g_mem_size = 0;
- below_4g_mem_size = ms->ram_size;
+ below_4g_mem_size = machine->ram_size;
}
if (pci_enabled) {
@@ -147,14 +147,14 @@ static void pc_init1(MachineState *ms,
if (smbios_defaults) {
/* These values are guest ABI, do not change */
smbios_set_defaults("QEMU", "Standard PC (i440FX + PIIX, 1996)",
- ms->machine->name, smbios_legacy_mode);
+ machine->machine->name, smbios_legacy_mode);
}
/* allocate ram and load rom/bios */
if (!xen_enabled()) {
fw_cfg = pc_memory_init(system_memory,
- ms->kernel_filename, ms->kernel_cmdline,
- ms->initrd_filename,
+ machine->kernel_filename, machine->kernel_cmdline,
+ machine->initrd_filename,
below_4g_mem_size, above_4g_mem_size,
rom_memory, &ram_memory, guest_info);
}
@@ -170,7 +170,7 @@ static void pc_init1(MachineState *ms,
if (pci_enabled) {
pci_bus = i440fx_init(&i440fx_state, &piix3_devfn, &isa_bus, gsi,
- system_memory, system_io, ms->ram_size,
+ system_memory, system_io, machine->ram_size,
below_4g_mem_size,
above_4g_mem_size,
pci_memory, ram_memory);
@@ -235,7 +235,7 @@ static void pc_init1(MachineState *ms,
}
}
- pc_cmos_init(below_4g_mem_size, above_4g_mem_size, ms->boot_order,
+ pc_cmos_init(below_4g_mem_size, above_4g_mem_size, machine->boot_order,
floppy, idebus[0], idebus[1], rtc_state);
if (pci_enabled && usb_enabled(false)) {
@@ -258,131 +258,131 @@ static void pc_init1(MachineState *ms,
}
}
-static void pc_init_pci(MachineState *ms)
+static void pc_init_pci(MachineState *machine)
{
- pc_init1(ms, 1, 1);
+ pc_init1(machine, 1, 1);
}
-static void pc_compat_2_0(MachineState *ms)
+static void pc_compat_2_0(MachineState *machine)
{
smbios_legacy_mode = true;
}
-static void pc_compat_1_7(MachineState *ms)
+static void pc_compat_1_7(MachineState *machine)
{
- pc_compat_2_0(ms);
+ pc_compat_2_0(machine);
smbios_defaults = false;
gigabyte_align = false;
option_rom_has_mr = true;
x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC);
}
-static void pc_compat_1_6(MachineState *ms)
+static void pc_compat_1_6(MachineState *machine)
{
- pc_compat_1_7(ms);
+ pc_compat_1_7(machine);
has_pci_info = false;
rom_file_has_mr = false;
has_acpi_build = false;
}
-static void pc_compat_1_5(MachineState *ms)
+static void pc_compat_1_5(MachineState *machine)
{
- pc_compat_1_6(ms);
+ pc_compat_1_6(machine);
}
-static void pc_compat_1_4(MachineState *ms)
+static void pc_compat_1_4(MachineState *machine)
{
- pc_compat_1_5(ms);
+ pc_compat_1_5(machine);
x86_cpu_compat_set_features("n270", FEAT_1_ECX, 0, CPUID_EXT_MOVBE);
x86_cpu_compat_set_features("Westmere", FEAT_1_ECX, 0, CPUID_EXT_PCLMULQDQ);
}
-static void pc_compat_1_3(MachineState *ms)
+static void pc_compat_1_3(MachineState *machine)
{
- pc_compat_1_4(ms);
+ pc_compat_1_4(machine);
enable_compat_apic_id_mode();
}
/* PC compat function for pc-0.14 to pc-1.2 */
-static void pc_compat_1_2(MachineState *ms)
+static void pc_compat_1_2(MachineState *machine)
{
- pc_compat_1_3(ms);
+ pc_compat_1_3(machine);
x86_cpu_compat_disable_kvm_features(FEAT_KVM, KVM_FEATURE_PV_EOI);
}
-static void pc_init_pci_2_0(MachineState *ms)
+static void pc_init_pci_2_0(MachineState *machine)
{
- pc_compat_2_0(ms);
- pc_init_pci(ms);
+ pc_compat_2_0(machine);
+ pc_init_pci(machine);
}
-static void pc_init_pci_1_7(MachineState *ms)
+static void pc_init_pci_1_7(MachineState *machine)
{
- pc_compat_1_7(ms);
- pc_init_pci(ms);
+ pc_compat_1_7(machine);
+ pc_init_pci(machine);
}
-static void pc_init_pci_1_6(MachineState *ms)
+static void pc_init_pci_1_6(MachineState *machine)
{
- pc_compat_1_6(ms);
- pc_init_pci(ms);
+ pc_compat_1_6(machine);
+ pc_init_pci(machine);
}
-static void pc_init_pci_1_5(MachineState *ms)
+static void pc_init_pci_1_5(MachineState *machine)
{
- pc_compat_1_5(ms);
- pc_init_pci(ms);
+ pc_compat_1_5(machine);
+ pc_init_pci(machine);
}
-static void pc_init_pci_1_4(MachineState *ms)
+static void pc_init_pci_1_4(MachineState *machine)
{
- pc_compat_1_4(ms);
- pc_init_pci(ms);
+ pc_compat_1_4(machine);
+ pc_init_pci(machine);
}
-static void pc_init_pci_1_3(MachineState *ms)
+static void pc_init_pci_1_3(MachineState *machine)
{
- pc_compat_1_3(ms);
- pc_init_pci(ms);
+ pc_compat_1_3(machine);
+ pc_init_pci(machine);
}
/* PC machine init function for pc-0.14 to pc-1.2 */
-static void pc_init_pci_1_2(MachineState *ms)
+static void pc_init_pci_1_2(MachineState *machine)
{
- pc_compat_1_2(ms);
- pc_init_pci(ms);
+ pc_compat_1_2(machine);
+ pc_init_pci(machine);
}
/* PC init function for pc-0.10 to pc-0.13, and reused by xenfv */
-static void pc_init_pci_no_kvmclock(MachineState *ms)
+static void pc_init_pci_no_kvmclock(MachineState *machine)
{
has_pci_info = false;
has_acpi_build = false;
smbios_defaults = false;
x86_cpu_compat_disable_kvm_features(FEAT_KVM, KVM_FEATURE_PV_EOI);
enable_compat_apic_id_mode();
- pc_init1(ms, 1, 0);
+ pc_init1(machine, 1, 0);
}
-static void pc_init_isa(MachineState *ms)
+static void pc_init_isa(MachineState *machine)
{
has_pci_info = false;
has_acpi_build = false;
smbios_defaults = false;
- if (!ms->cpu_model) {
- ms->cpu_model = "486";
+ if (!machine->cpu_model) {
+ machine->cpu_model = "486";
}
x86_cpu_compat_disable_kvm_features(FEAT_KVM, KVM_FEATURE_PV_EOI);
enable_compat_apic_id_mode();
- pc_init1(ms, 0, 1);
+ pc_init1(machine, 0, 1);
}
#ifdef CONFIG_XEN
-static void pc_xen_hvm_init(MachineState *ms)
+static void pc_xen_hvm_init(MachineState *machine)
{
PCIBus *bus;
- pc_init_pci(ms);
+ pc_init_pci(machine);
bus = pci_find_primary_bus();
if (bus != NULL) {
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 315cfe5..8d0a728 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -59,7 +59,7 @@ static bool smbios_legacy_mode;
static bool gigabyte_align = true;
/* PC hardware initialisation */
-static void pc_q35_init(MachineState *ms)
+static void pc_q35_init(MachineState *machine)
{
ram_addr_t below_4g_mem_size, above_4g_mem_size;
Q35PCIHost *q35_host;
@@ -93,7 +93,7 @@ static void pc_q35_init(MachineState *ms)
object_property_add_child(qdev_get_machine(), "icc-bridge",
OBJECT(icc_bridge), NULL);
- pc_cpus_init(ms->cpu_model, icc_bridge);
+ pc_cpus_init(machine->cpu_model, icc_bridge);
pc_acpi_init("q35-acpi-dsdt.aml");
kvmclock_create();
@@ -107,13 +107,13 @@ static void pc_q35_init(MachineState *ms)
* For old machine types, use whatever split we used historically to avoid
* breaking migration.
*/
- if (ms->ram_size >= 0xb0000000) {
+ if (machine->ram_size >= 0xb0000000) {
ram_addr_t lowmem = gigabyte_align ? 0x80000000 : 0xb0000000;
- above_4g_mem_size = ms->ram_size - lowmem;
+ above_4g_mem_size = machine->ram_size - lowmem;
below_4g_mem_size = lowmem;
} else {
above_4g_mem_size = 0;
- below_4g_mem_size = ms->ram_size;
+ below_4g_mem_size = machine->ram_size;
}
/* pci enabled */
@@ -134,14 +134,14 @@ static void pc_q35_init(MachineState *ms)
if (smbios_defaults) {
/* These values are guest ABI, do not change */
smbios_set_defaults("QEMU", "Standard PC (Q35 + ICH9, 2009)",
- ms->machine->name, smbios_legacy_mode);
+ machine->machine->name, smbios_legacy_mode);
}
/* allocate ram and load rom/bios */
if (!xen_enabled()) {
pc_memory_init(get_system_memory(),
- ms->kernel_filename, ms->kernel_cmdline,
- ms->initrd_filename,
+ machine->kernel_filename, machine->kernel_cmdline,
+ machine->initrd_filename,
below_4g_mem_size, above_4g_mem_size,
rom_memory, &ram_memory, guest_info);
}
@@ -230,7 +230,7 @@ static void pc_q35_init(MachineState *ms)
0xb100),
8, NULL, 0);
- pc_cmos_init(below_4g_mem_size, above_4g_mem_size, ms->boot_order,
+ pc_cmos_init(below_4g_mem_size, above_4g_mem_size, machine->boot_order,
floppy, idebus[0], idebus[1], rtc_state);
/* the rest devices to which pci devfn is automatically assigned */
@@ -241,68 +241,68 @@ static void pc_q35_init(MachineState *ms)
}
}
-static void pc_compat_2_0(MachineState *ms)
+static void pc_compat_2_0(MachineState *machine)
{
smbios_legacy_mode = true;
}
-static void pc_compat_1_7(MachineState *ms)
+static void pc_compat_1_7(MachineState *machine)
{
- pc_compat_2_0(ms);
+ pc_compat_2_0(machine);
smbios_defaults = false;
gigabyte_align = false;
option_rom_has_mr = true;
x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC);
}
-static void pc_compat_1_6(MachineState *ms)
+static void pc_compat_1_6(MachineState *machine)
{
- pc_compat_1_7(ms);
+ pc_compat_1_7(machine);
has_pci_info = false;
rom_file_has_mr = false;
has_acpi_build = false;
}
-static void pc_compat_1_5(MachineState *ms)
+static void pc_compat_1_5(MachineState *machine)
{
- pc_compat_1_6(ms);
+ pc_compat_1_6(machine);
}
-static void pc_compat_1_4(MachineState *ms)
+static void pc_compat_1_4(MachineState *machine)
{
- pc_compat_1_5(ms);
+ pc_compat_1_5(machine);
x86_cpu_compat_set_features("n270", FEAT_1_ECX, 0, CPUID_EXT_MOVBE);
x86_cpu_compat_set_features("Westmere", FEAT_1_ECX, 0, CPUID_EXT_PCLMULQDQ);
}
-static void pc_q35_init_2_0(MachineState *ms)
+static void pc_q35_init_2_0(MachineState *machine)
{
- pc_compat_2_0(ms);
- pc_q35_init(ms);
+ pc_compat_2_0(machine);
+ pc_q35_init(machine);
}
-static void pc_q35_init_1_7(MachineState *ms)
+static void pc_q35_init_1_7(MachineState *machine)
{
- pc_compat_1_7(ms);
- pc_q35_init(ms);
+ pc_compat_1_7(machine);
+ pc_q35_init(machine);
}
-static void pc_q35_init_1_6(MachineState *ms)
+static void pc_q35_init_1_6(MachineState *machine)
{
- pc_compat_1_6(ms);
- pc_q35_init(ms);
+ pc_compat_1_6(machine);
+ pc_q35_init(machine);
}
-static void pc_q35_init_1_5(MachineState *ms)
+static void pc_q35_init_1_5(MachineState *machine)
{
- pc_compat_1_5(ms);
- pc_q35_init(ms);
+ pc_compat_1_5(machine);
+ pc_q35_init(machine);
}
-static void pc_q35_init_1_4(MachineState *ms)
+static void pc_q35_init_1_4(MachineState *machine)
{
- pc_compat_1_4(ms);
- pc_q35_init(ms);
+ pc_compat_1_4(machine);
+ pc_q35_init(machine);
}
#define PC_Q35_MACHINE_OPTIONS \
diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c
index fb66f67..0e01340 100644
--- a/hw/lm32/lm32_boards.c
+++ b/hw/lm32/lm32_boards.c
@@ -69,10 +69,10 @@ static void main_cpu_reset(void *opaque)
env->deba = reset_info->flash_base;
}
-static void lm32_evr_init(MachineState *ms)
+static void lm32_evr_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
LM32CPU *cpu;
CPULM32State *env;
DriveInfo *dinfo;
@@ -162,12 +162,12 @@ static void lm32_evr_init(MachineState *ms)
qemu_register_reset(main_cpu_reset, reset_info);
}
-static void lm32_uclinux_init(MachineState *ms)
+static void lm32_uclinux_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
LM32CPU *cpu;
CPULM32State *env;
DriveInfo *dinfo;
diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
index 7438a79..81c3933 100644
--- a/hw/lm32/milkymist.c
+++ b/hw/lm32/milkymist.c
@@ -74,12 +74,12 @@ static void main_cpu_reset(void *opaque)
}
static void
-milkymist_init(MachineState *ms)
+milkymist_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
LM32CPU *cpu;
CPULM32State *env;
int kernel_size;
diff --git a/hw/m68k/an5206.c b/hw/m68k/an5206.c
index 7814dc9..684496a 100644
--- a/hw/m68k/an5206.c
+++ b/hw/m68k/an5206.c
@@ -20,11 +20,11 @@
/* Board init. */
-static void an5206_init(MachineState *ms)
+static void an5206_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
M68kCPU *cpu;
CPUM68KState *env;
int kernel_size;
diff --git a/hw/m68k/dummy_m68k.c b/hw/m68k/dummy_m68k.c
index e87f8b6..6db1b71 100644
--- a/hw/m68k/dummy_m68k.c
+++ b/hw/m68k/dummy_m68k.c
@@ -16,11 +16,11 @@
/* Board init. */
-static void dummy_m68k_init(MachineState *ms)
+static void dummy_m68k_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
CPUM68KState *env;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
index 26c6ee9..2ef617f 100644
--- a/hw/m68k/mcf5208.c
+++ b/hw/m68k/mcf5208.c
@@ -188,11 +188,11 @@ static void mcf5208_sys_init(MemoryRegion *address_space, qemu_irq *pic)
}
}
-static void mcf5208evb_init(MachineState *ms)
+static void mcf5208evb_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
M68kCPU *cpu;
CPUM68KState *env;
int kernel_size;
diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c
index 1b3d3ed..496330c 100644
--- a/hw/microblaze/petalogix_ml605_mmu.c
+++ b/hw/microblaze/petalogix_ml605_mmu.c
@@ -79,9 +79,9 @@ static void machine_cpu_reset(MicroBlazeCPU *cpu)
}
static void
-petalogix_ml605_init(MachineState *ms)
+petalogix_ml605_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
+ ram_addr_t ram_size = machine->ram_size;
MemoryRegion *address_space_mem = get_system_memory();
DeviceState *dev, *dma, *eth0;
Object *ds, *cs;
@@ -202,7 +202,7 @@ petalogix_ml605_init(MachineState *ms)
}
microblaze_load_kernel(cpu, ddr_base, ram_size,
- ms->initrd_filename,
+ machine->initrd_filename,
BINARY_DEVICE_TREE_FILE,
machine_cpu_reset);
diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c b/hw/microblaze/petalogix_s3adsp1800_mmu.c
index 683f7b3..49dc6d1 100644
--- a/hw/microblaze/petalogix_s3adsp1800_mmu.c
+++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c
@@ -59,10 +59,10 @@ static void machine_cpu_reset(MicroBlazeCPU *cpu)
}
static void
-petalogix_s3adsp1800_init(MachineState *ms)
+petalogix_s3adsp1800_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
DeviceState *dev;
MicroBlazeCPU *cpu;
DriveInfo *dinfo;
@@ -128,7 +128,7 @@ petalogix_s3adsp1800_init(MachineState *ms)
sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq[ETHLITE_IRQ]);
microblaze_load_kernel(cpu, ddr_base, ram_size,
- ms->initrd_filename,
+ machine->initrd_filename,
BINARY_DEVICE_TREE_FILE,
machine_cpu_reset);
}
diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index b236ae9..5ad7a41 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -259,13 +259,13 @@ static void cpu_request_exit(void *opaque, int irq, int level)
}
}
-static void mips_fulong2e_init(MachineState *ms)
+static void mips_fulong2e_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
char *filename;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c
index 53cad58..c113a80 100644
--- a/hw/mips/mips_jazz.c
+++ b/hw/mips/mips_jazz.c
@@ -329,19 +329,19 @@ static void mips_jazz_init(MemoryRegion *address_space,
}
static
-void mips_magnum_init(MachineState *ms)
+void mips_magnum_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
mips_jazz_init(get_system_memory(), get_system_io(),
ram_size, cpu_model, JAZZ_MAGNUM);
}
static
-void mips_pica61_init(MachineState *ms)
+void mips_pica61_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
mips_jazz_init(get_system_memory(), get_system_io(),
ram_size, cpu_model, JAZZ_PICA61);
}
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index a16ee92..9fe775e 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -875,13 +875,13 @@ static void cpu_request_exit(void *opaque, int irq, int level)
}
static
-void mips_malta_init(MachineState *ms)
+void mips_malta_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
char *filename;
pflash_t *fl;
MemoryRegion *system_memory = get_system_memory();
diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c
index 7254adf..413e64d 100644
--- a/hw/mips/mips_mipssim.c
+++ b/hw/mips/mips_mipssim.c
@@ -133,13 +133,13 @@ static void mipsnet_init(int base, qemu_irq irq, NICInfo *nd)
}
static void
-mips_mipssim_init(MachineState *ms)
+mips_mipssim_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
char *filename;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *isa = g_new(MemoryRegion, 1);
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index 7a69514..7120293 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -153,13 +153,13 @@ static void main_cpu_reset(void *opaque)
static const int sector_len = 32 * 1024;
static
-void mips_r4k_init(MachineState *ms)
+void mips_r4k_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
char *filename;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesim.c
index 6114478..f4357cf 100644
--- a/hw/moxie/moxiesim.c
+++ b/hw/moxie/moxiesim.c
@@ -107,14 +107,14 @@ moxie_intc_create(hwaddr base, qemu_irq irq, int kind_of_intr)
return dev;
}
-static void moxiesim_init(MachineState *ms)
+static void moxiesim_init(MachineState *machine)
{
MoxieCPU *cpu = NULL;
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
CPUMoxieState *env;
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c
index 24bd3c3..b2b4f9b 100644
--- a/hw/openrisc/openrisc_sim.c
+++ b/hw/openrisc/openrisc_sim.c
@@ -90,11 +90,11 @@ static void cpu_openrisc_load_kernel(ram_addr_t ram_size,
}
}
-static void openrisc_sim_init(MachineState *ms)
+static void openrisc_sim_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
OpenRISCCPU *cpu = NULL;
MemoryRegion *ram;
int n;
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 0c378ce..223bab9 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -123,7 +123,7 @@ static void dt_serial_create(void *fdt, unsigned long long offset,
}
}
-static int ppce500_load_device_tree(MachineState *ms,
+static int ppce500_load_device_tree(MachineState *machine,
PPCE500Params *params,
hwaddr addr,
hwaddr initrd_base,
@@ -132,7 +132,7 @@ static int ppce500_load_device_tree(MachineState *ms,
{
CPUPPCState *env = first_cpu->env_ptr;
int ret = -1;
- uint64_t mem_reg_property[] = { 0, cpu_to_be64(ms->ram_size) };
+ uint64_t mem_reg_property[] = { 0, cpu_to_be64(machine->ram_size) };
int fdt_size;
void *fdt;
uint8_t hypercall[16];
@@ -207,7 +207,7 @@ static int ppce500_load_device_tree(MachineState *ms,
}
ret = qemu_fdt_setprop_string(fdt, "/chosen", "bootargs",
- ms->kernel_cmdline);
+ machine->kernel_cmdline);
if (ret < 0)
fprintf(stderr, "couldn't set /chosen/bootargs\n");
@@ -387,7 +387,7 @@ out:
}
typedef struct DeviceTreeParams {
- MachineState ms;
+ MachineState *machine;
PPCE500Params params;
hwaddr addr;
hwaddr initrd_base;
@@ -397,18 +397,18 @@ typedef struct DeviceTreeParams {
static void ppce500_reset_device_tree(void *opaque)
{
DeviceTreeParams *p = opaque;
- ppce500_load_device_tree(&p->ms, &p->params, p->addr, p->initrd_base,
+ ppce500_load_device_tree(p->machine, &p->params, p->addr, p->initrd_base,
p->initrd_size, false);
}
-static int ppce500_prep_device_tree(MachineState *ms,
+static int ppce500_prep_device_tree(MachineState *machine,
PPCE500Params *params,
hwaddr addr,
hwaddr initrd_base,
hwaddr initrd_size)
{
DeviceTreeParams *p = g_new(DeviceTreeParams, 1);
- p->ms = *ms;
+ p->machine = machine;
p->params = *params;
p->addr = addr;
p->initrd_base = initrd_base;
@@ -417,7 +417,7 @@ static int ppce500_prep_device_tree(MachineState *ms,
qemu_register_reset(ppce500_reset_device_tree, p);
/* Issue the device tree loader once, so that we get the size of the blob */
- return ppce500_load_device_tree(ms, params, addr, initrd_base,
+ return ppce500_load_device_tree(machine, params, addr, initrd_base,
initrd_size, true);
}
@@ -597,7 +597,7 @@ static qemu_irq *ppce500_init_mpic(PPCE500Params *params, MemoryRegion *ccsr,
return mpic;
}
-void ppce500_init(MachineState *ms, PPCE500Params *params)
+void ppce500_init(MachineState *machine, PPCE500Params *params)
{
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
@@ -622,8 +622,8 @@ void ppce500_init(MachineState *ms, PPCE500Params *params)
PPCE500CCSRState *ccsr;
/* Setup CPUs */
- if (ms->cpu_model == NULL) {
- ms->cpu_model = "e500v2_v30";
+ if (machine->cpu_model == NULL) {
+ machine->cpu_model = "e500v2_v30";
}
irqs = g_malloc0(smp_cpus * sizeof(qemu_irq *));
@@ -633,7 +633,7 @@ void ppce500_init(MachineState *ms, PPCE500Params *params)
CPUState *cs;
qemu_irq *input;
- cpu = cpu_ppc_init(ms->cpu_model);
+ cpu = cpu_ppc_init(machine->cpu_model);
if (cpu == NULL) {
fprintf(stderr, "Unable to initialize CPU!\n");
exit(1);
@@ -672,7 +672,7 @@ void ppce500_init(MachineState *ms, PPCE500Params *params)
/* Fixup Memory size on a alignment boundary */
ram_size &= ~(RAM_SIZES_ALIGN - 1);
- ms->ram_size = ram_size;
+ machine->ram_size = ram_size;
/* Register Memory */
memory_region_init_ram(ram, NULL, "mpc8544ds.ram", ram_size);
@@ -739,11 +739,11 @@ void ppce500_init(MachineState *ms, PPCE500Params *params)
sysbus_create_simple("e500-spin", MPC8544_SPIN_BASE, NULL);
/* Load kernel. */
- if (ms->kernel_filename) {
- kernel_size = load_uimage(ms->kernel_filename, &entry,
+ if (machine->kernel_filename) {
+ kernel_size = load_uimage(machine->kernel_filename, &entry,
&loadaddr, NULL);
if (kernel_size < 0) {
- kernel_size = load_elf(ms->kernel_filename, NULL, NULL,
+ kernel_size = load_elf(machine->kernel_filename, NULL, NULL,
&elf_entry, &elf_lowaddr, NULL, 1,
ELF_MACHINE, 0);
entry = elf_entry;
@@ -752,7 +752,7 @@ void ppce500_init(MachineState *ms, PPCE500Params *params)
/* XXX try again as binary */
if (kernel_size < 0) {
fprintf(stderr, "qemu: could not load kernel '%s'\n",
- ms->kernel_filename);
+ machine->kernel_filename);
exit(1);
}
@@ -764,14 +764,14 @@ void ppce500_init(MachineState *ms, PPCE500Params *params)
}
/* Load initrd. */
- if (ms->initrd_filename) {
+ if (machine->initrd_filename) {
initrd_base = (cur_base + INITRD_LOAD_PAD) & ~INITRD_PAD_MASK;
- initrd_size = load_image_targphys(ms->initrd_filename, initrd_base,
+ initrd_size = load_image_targphys(machine->initrd_filename, initrd_base,
ram_size - initrd_base);
if (initrd_size < 0) {
fprintf(stderr, "qemu: could not load initial ram disk '%s'\n",
- ms->initrd_filename);
+ machine->initrd_filename);
exit(1);
}
@@ -779,11 +779,11 @@ void ppce500_init(MachineState *ms, PPCE500Params *params)
}
/* If we're loading a kernel directly, we must load the device tree too. */
- if (ms->kernel_filename) {
+ if (machine->kernel_filename) {
struct boot_info *boot_info;
int dt_size;
- dt_size = ppce500_prep_device_tree(ms, params, dt_base,
+ dt_size = ppce500_prep_device_tree(machine, params, dt_base,
initrd_base, initrd_size);
if (dt_size < 0) {
fprintf(stderr, "couldn't load device tree\n");
diff --git a/hw/ppc/e500plat.c b/hw/ppc/e500plat.c
index 71e93d3..27df31d 100644
--- a/hw/ppc/e500plat.c
+++ b/hw/ppc/e500plat.c
@@ -28,7 +28,7 @@ static void e500plat_fixup_devtree(PPCE500Params *params, void *fdt)
sizeof(compatible));
}
-static void e500plat_init(MachineState *ms)
+static void e500plat_init(MachineState *machine)
{
PPCE500Params params = {
.pci_first_slot = 0x1,
@@ -43,7 +43,7 @@ static void e500plat_init(MachineState *ms)
params.mpic_version = OPENPIC_MODEL_FSL_MPIC_20;
}
- ppce500_init(ms, ¶ms);
+ ppce500_init(machine, ¶ms);
}
static QEMUMachine e500plat_machine = {
diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index 4e9000d..4bdaa8d 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
@@ -140,14 +140,14 @@ static void ppc_core99_reset(void *opaque)
}
/* PowerPC Mac99 hardware initialisation */
-static void ppc_core99_init(MachineState *ms)
+static void ppc_core99_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
- const char *boot_device = ms->boot_order;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
+ const char *boot_device = machine->boot_order;
PowerPCCPU *cpu = NULL;
CPUPPCState *env = NULL;
char *filename;
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
index 465fd37..77598e4 100644
--- a/hw/ppc/mac_oldworld.c
+++ b/hw/ppc/mac_oldworld.c
@@ -71,14 +71,14 @@ static void ppc_heathrow_reset(void *opaque)
cpu_reset(CPU(cpu));
}
-static void ppc_heathrow_init(MachineState *ms)
+static void ppc_heathrow_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
- const char *boot_device = ms->boot_order;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
+ const char *boot_device = machine->boot_order;
MemoryRegion *sysmem = get_system_memory();
PowerPCCPU *cpu = NULL;
CPUPPCState *env = NULL;
diff --git a/hw/ppc/mpc8544ds.c b/hw/ppc/mpc8544ds.c
index 2f6b1e3..b99f74a 100644
--- a/hw/ppc/mpc8544ds.c
+++ b/hw/ppc/mpc8544ds.c
@@ -26,7 +26,7 @@ static void mpc8544ds_fixup_devtree(PPCE500Params *params, void *fdt)
sizeof(compatible));
}
-static void mpc8544ds_init(MachineState *ms)
+static void mpc8544ds_init(MachineState *machine)
{
PPCE500Params params = {
.pci_first_slot = 0x11,
@@ -35,7 +35,7 @@ static void mpc8544ds_init(MachineState *ms)
.mpic_version = OPENPIC_MODEL_FSL_MPIC_20,
};
- ppce500_init(ms, ¶ms);
+ ppce500_init(machine, ¶ms);
}
diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c
index b925343..98ad2d7 100644
--- a/hw/ppc/ppc405_boards.c
+++ b/hw/ppc/ppc405_boards.c
@@ -172,12 +172,12 @@ static void ref405ep_fpga_init(MemoryRegion *sysmem, uint32_t base)
qemu_register_reset(&ref405ep_fpga_reset, fpga);
}
-static void ref405ep_init(MachineState *ms)
+static void ref405ep_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
char *filename;
ppc4xx_bd_info_t bd;
CPUPPCState *env;
@@ -499,11 +499,11 @@ static void taihu_cpld_init(MemoryRegion *sysmem, uint32_t base)
qemu_register_reset(&taihu_cpld_reset, cpld);
}
-static void taihu_405ep_init(MachineState *ms)
+static void taihu_405ep_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *kernel_filename = ms->kernel_filename;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *initrd_filename = machine->initrd_filename;
char *filename;
qemu_irq *pic;
MemoryRegion *sysmem = get_system_memory();
diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c
index 2b94750..81a06d3 100644
--- a/hw/ppc/ppc440_bamboo.c
+++ b/hw/ppc/ppc440_bamboo.c
@@ -156,13 +156,13 @@ static void main_cpu_reset(void *opaque)
mmubooke_create_initial_mapping(env, 0, 0);
}
-static void bamboo_init(MachineState *ms)
+static void bamboo_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
unsigned int pci_irq_nrs[4] = { 28, 27, 26, 25 };
MemoryRegion *address_space_mem = get_system_memory();
MemoryRegion *isa = g_new(MemoryRegion, 1);
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 62b845f..2383254 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -364,14 +364,14 @@ static const MemoryRegionPortio prep_portio_list[] = {
static PortioList prep_port_list;
/* PowerPC PREP hardware initialisation */
-static void ppc_prep_init(MachineState *ms)
+static void ppc_prep_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
- const char *boot_device = ms->boot_order;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
+ const char *boot_device = machine->boot_order;
MemoryRegion *sysmem = get_system_memory();
PowerPCCPU *cpu = NULL;
CPUPPCState *env = NULL;
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 6b2dfd5..57e9578 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1140,14 +1140,14 @@ static SaveVMHandlers savevm_htab_handlers = {
};
/* pSeries LPAR / sPAPR hardware init */
-static void ppc_spapr_init(MachineState *ms)
+static void ppc_spapr_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
- const char *boot_device = ms->boot_order;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
+ const char *boot_device = machine->boot_order;
PowerPCCPU *cpu;
CPUPPCState *env;
PCIHostState *phb;
diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
index b816b3c..02b4f82 100644
--- a/hw/ppc/virtex_ml507.c
+++ b/hw/ppc/virtex_ml507.c
@@ -194,12 +194,12 @@ static int xilinx_load_device_tree(hwaddr addr,
return fdt_size;
}
-static void virtex_init(MachineState *ms)
+static void virtex_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
hwaddr initrd_base = 0;
int initrd_size = 0;
MemoryRegion *address_space_mem = get_system_memory();
@@ -275,14 +275,14 @@ static void virtex_init(MachineState *ms)
boot_info.ima_size = kernel_size;
/* Load initrd. */
- if (ms->initrd_filename) {
+ if (machine->initrd_filename) {
initrd_base = high = ROUND_UP(high, 4);
- initrd_size = load_image_targphys(ms->initrd_filename,
+ initrd_size = load_image_targphys(machine->initrd_filename,
high, ram_size - high);
if (initrd_size < 0) {
error_report("couldn't load ram disk '%s'",
- ms->initrd_filename);
+ machine->initrd_filename);
exit(1);
}
high = ROUND_UP(high + initrd_size, 4);
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 3d28045..42f5cec 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -79,9 +79,9 @@ static void virtio_ccw_register_hcalls(void)
virtio_ccw_hcall_early_printk);
}
-static void ccw_init(MachineState *ms)
+static void ccw_init(MachineState *machine)
{
- ram_addr_t my_ram_size = ms->ram_size;
+ ram_addr_t my_ram_size = machine->ram_size;
MemoryRegion *sysmem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
int shift = 0;
@@ -102,8 +102,8 @@ static void ccw_init(MachineState *ms)
/* get a BUS */
css_bus = virtual_css_bus_init();
s390_sclp_init();
- s390_init_ipl_dev(ms->kernel_filename, ms->kernel_cmdline,
- ms->initrd_filename, "s390-ccw.img");
+ s390_init_ipl_dev(machine->kernel_filename, machine->kernel_cmdline,
+ machine->initrd_filename, "s390-ccw.img");
s390_flic_init();
/* register hypercalls */
@@ -118,7 +118,7 @@ static void ccw_init(MachineState *ms)
storage_keys = g_malloc0(my_ram_size / TARGET_PAGE_SIZE);
/* init CPUs */
- s390_init_cpus(ms->cpu_model, storage_keys);
+ s390_init_cpus(machine->cpu_model, storage_keys);
if (kvm_enabled()) {
kvm_s390_enable_css_support(s390_cpu_addr2state(0));
diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c
index 19443d2..93c7ace 100644
--- a/hw/s390x/s390-virtio.c
+++ b/hw/s390x/s390-virtio.c
@@ -224,9 +224,9 @@ void s390_create_virtio_net(BusState *bus, const char *name)
}
/* PC hardware initialisation */
-static void s390_init(MachineState *ms)
+static void s390_init(MachineState *machine)
{
- ram_addr_t my_ram_size = ms->ram_size;
+ ram_addr_t my_ram_size = machine->ram_size;
MemoryRegion *sysmem = get_system_memory();
MemoryRegion *ram = g_new(MemoryRegion, 1);
int shift = 0;
@@ -248,8 +248,8 @@ static void s390_init(MachineState *ms)
/* get a BUS */
s390_bus = s390_virtio_bus_init(&my_ram_size);
s390_sclp_init();
- s390_init_ipl_dev(ms->kernel_filename, ms->kernel_cmdline,
- ms->initrd_filename, ZIPL_FILENAME);
+ s390_init_ipl_dev(machine->kernel_filename, machine->kernel_cmdline,
+ machine->initrd_filename, ZIPL_FILENAME);
s390_flic_init();
/* register hypercalls */
@@ -273,7 +273,7 @@ static void s390_init(MachineState *ms)
storage_keys = g_malloc0(my_ram_size / TARGET_PAGE_SIZE);
/* init CPUs */
- s390_init_cpus(ms->cpu_model, storage_keys);
+ s390_init_cpus(machine->cpu_model, storage_keys);
/* Create VirtIO network adapters */
s390_create_virtio_net((BusState *)s390_bus, "virtio-net-s390");
diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
index 298c7a2..95c0246 100644
--- a/hw/sh4/r2d.c
+++ b/hw/sh4/r2d.c
@@ -219,12 +219,12 @@ static struct QEMU_PACKED
char kernel_cmdline[256];
} boot_params;
-static void r2d_init(MachineState *ms)
+static void r2d_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
SuperHCPU *cpu;
CPUSH4State *env;
ResetData *reset_info;
diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
index 1c2c744..7c152b4 100644
--- a/hw/sh4/shix.c
+++ b/hw/sh4/shix.c
@@ -39,9 +39,9 @@
#define BIOS_FILENAME "shix_bios.bin"
#define BIOS_ADDRESS 0xA0000000
-static void shix_init(MachineState *ms)
+static void shix_init(MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
+ const char *cpu_model = machine->cpu_model;
int ret;
SuperHCPU *cpu;
struct SH7750State *s;
diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index 2a283a3..827383b 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -101,11 +101,11 @@ static void leon3_set_pil_in(void *opaque, uint32_t pil_in)
}
}
-static void leon3_generic_hw_init(MachineState *ms)
+static void leon3_generic_hw_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
SPARCCPU *cpu;
CPUSPARCState *env;
MemoryRegion *address_space_mem = get_system_memory();
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index 534e10a..4e793c2 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -867,9 +867,9 @@ static void dummy_fdc_tc(void *opaque, int irq, int level)
}
static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,
- MachineState *ms)
+ MachineState *machine)
{
- const char *cpu_model = ms->cpu_model;
+ const char *cpu_model = machine->cpu_model;
unsigned int i;
void *iommu, *espdma, *ledma, *nvram;
qemu_irq *cpu_irqs[MAX_CPUS], slavio_irq[32], slavio_cpu_irq[MAX_CPUS],
@@ -895,10 +895,10 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,
/* set up devices */
- ram_init(0, ms->ram_size, hwdef->max_mem);
+ ram_init(0, machine->ram_size, hwdef->max_mem);
/* models without ECC don't trap when missing ram is accessed */
if (!hwdef->ecc_base) {
- empty_slot_init(ms->ram_size, hwdef->max_mem - ms->ram_size);
+ empty_slot_init(machine->ram_size, hwdef->max_mem - machine->ram_size);
}
prom_init(hwdef->slavio_base, bios_name);
@@ -1051,14 +1051,14 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,
empty_slot_init(hwdef->bpp_base, 0x20);
}
- kernel_size = sun4m_load_kernel(ms->kernel_filename,
- ms->initrd_filename,
- ms->ram_size);
+ kernel_size = sun4m_load_kernel(machine->kernel_filename,
+ machine->initrd_filename,
+ machine->ram_size);
- nvram_init(nvram, (uint8_t *)&nd_table[0].macaddr, ms->kernel_cmdline,
- ms->boot_order, ms->ram_size, kernel_size, graphic_width,
- graphic_height, graphic_depth, hwdef->nvram_machine_id,
- "Sun4m");
+ nvram_init(nvram, (uint8_t *)&nd_table[0].macaddr, machine->kernel_cmdline,
+ machine->boot_order, machine->ram_size, kernel_size,
+ graphic_width, graphic_height, graphic_depth,
+ hwdef->nvram_machine_id, "Sun4m");
if (hwdef->ecc_base)
ecc_init(hwdef->ecc_base, slavio_irq[28],
@@ -1074,20 +1074,20 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,
fw_cfg_add_i16(fw_cfg, FW_CFG_SUN4M_HEIGHT, graphic_height);
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_ADDR, KERNEL_LOAD_ADDR);
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_SIZE, kernel_size);
- if (ms->kernel_cmdline) {
+ if (machine->kernel_cmdline) {
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_CMDLINE, CMDLINE_ADDR);
pstrcpy_targphys("cmdline", CMDLINE_ADDR, TARGET_PAGE_SIZE,
- ms->kernel_cmdline);
- fw_cfg_add_string(fw_cfg, FW_CFG_CMDLINE_DATA, ms->kernel_cmdline);
+ machine->kernel_cmdline);
+ fw_cfg_add_string(fw_cfg, FW_CFG_CMDLINE_DATA, machine->kernel_cmdline);
fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_SIZE,
- strlen(ms->kernel_cmdline) + 1);
+ strlen(machine->kernel_cmdline) + 1);
} else {
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_CMDLINE, 0);
fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_SIZE, 0);
}
fw_cfg_add_i32(fw_cfg, FW_CFG_INITRD_ADDR, INITRD_LOAD_ADDR);
fw_cfg_add_i32(fw_cfg, FW_CFG_INITRD_SIZE, 0); // not used
- fw_cfg_add_i16(fw_cfg, FW_CFG_BOOT_DEVICE, ms->boot_order[0]);
+ fw_cfg_add_i16(fw_cfg, FW_CFG_BOOT_DEVICE, machine->boot_order[0]);
qemu_register_boot_set(fw_cfg_boot_set, fw_cfg);
}
@@ -1349,57 +1349,57 @@ static const struct sun4m_hwdef sun4m_hwdefs[] = {
};
/* SPARCstation 5 hardware initialisation */
-static void ss5_init(MachineState *ms)
+static void ss5_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[0], ms);
+ sun4m_hw_init(&sun4m_hwdefs[0], machine);
}
/* SPARCstation 10 hardware initialisation */
-static void ss10_init(MachineState *ms)
+static void ss10_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[1], ms);
+ sun4m_hw_init(&sun4m_hwdefs[1], machine);
}
/* SPARCserver 600MP hardware initialisation */
-static void ss600mp_init(MachineState *ms)
+static void ss600mp_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[2], ms);
+ sun4m_hw_init(&sun4m_hwdefs[2], machine);
}
/* SPARCstation 20 hardware initialisation */
-static void ss20_init(MachineState *ms)
+static void ss20_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[3], ms);
+ sun4m_hw_init(&sun4m_hwdefs[3], machine);
}
/* SPARCstation Voyager hardware initialisation */
-static void vger_init(MachineState *ms)
+static void vger_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[4], ms);
+ sun4m_hw_init(&sun4m_hwdefs[4], machine);
}
/* SPARCstation LX hardware initialisation */
-static void ss_lx_init(MachineState *ms)
+static void ss_lx_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[5], ms);
+ sun4m_hw_init(&sun4m_hwdefs[5], machine);
}
/* SPARCstation 4 hardware initialisation */
-static void ss4_init(MachineState *ms)
+static void ss4_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[6], ms);
+ sun4m_hw_init(&sun4m_hwdefs[6], machine);
}
/* SPARCClassic hardware initialisation */
-static void scls_init(MachineState *ms)
+static void scls_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[7], ms);
+ sun4m_hw_init(&sun4m_hwdefs[7], machine);
}
/* SPARCbook hardware initialisation */
-static void sbook_init(MachineState *ms)
+static void sbook_init(MachineState *machine)
{
- sun4m_hw_init(&sun4m_hwdefs[8], ms);
+ sun4m_hw_init(&sun4m_hwdefs[8], machine);
}
static QEMUMachine ss5_machine = {
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 036e8c9..33c311b 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -811,7 +811,7 @@ static SPARCCPU *cpu_devinit(const char *cpu_model, const struct hwdef *hwdef)
}
static void sun4uv_init(MemoryRegion *address_space_mem,
- MachineState *ms,
+ MachineState *machine,
const struct hwdef *hwdef)
{
SPARCCPU *cpu;
@@ -826,10 +826,10 @@ static void sun4uv_init(MemoryRegion *address_space_mem,
FWCfgState *fw_cfg;
/* init CPUs */
- cpu = cpu_devinit(ms->cpu_model, hwdef);
+ cpu = cpu_devinit(machine->cpu_model, hwdef);
/* set up devices */
- ram_init(0, ms->ram_size);
+ ram_init(0, machine->ram_size);
prom_init(hwdef->prom_addr, bios_name);
@@ -875,15 +875,15 @@ static void sun4uv_init(MemoryRegion *address_space_mem,
initrd_size = 0;
initrd_addr = 0;
- kernel_size = sun4u_load_kernel(ms->kernel_filename,
- ms->initrd_filename,
+ kernel_size = sun4u_load_kernel(machine->kernel_filename,
+ machine->initrd_filename,
ram_size, &initrd_size, &initrd_addr,
&kernel_addr, &kernel_entry);
- sun4u_NVRAM_set_params(nvram, NVRAM_SIZE, "Sun4u", ms->ram_size,
- ms->boot_order,
+ sun4u_NVRAM_set_params(nvram, NVRAM_SIZE, "Sun4u", machine->ram_size,
+ machine->boot_order,
kernel_addr, kernel_size,
- ms->kernel_cmdline,
+ machine->kernel_cmdline,
initrd_addr, initrd_size,
/* XXX: need an option to load a NVRAM image */
0,
@@ -897,16 +897,16 @@ static void sun4uv_init(MemoryRegion *address_space_mem,
fw_cfg_add_i16(fw_cfg, FW_CFG_MACHINE_ID, hwdef->machine_id);
fw_cfg_add_i64(fw_cfg, FW_CFG_KERNEL_ADDR, kernel_entry);
fw_cfg_add_i64(fw_cfg, FW_CFG_KERNEL_SIZE, kernel_size);
- if (ms->kernel_cmdline) {
+ if (machine->kernel_cmdline) {
fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_SIZE,
- strlen(ms->kernel_cmdline) + 1);
- fw_cfg_add_string(fw_cfg, FW_CFG_CMDLINE_DATA, ms->kernel_cmdline);
+ strlen(machine->kernel_cmdline) + 1);
+ fw_cfg_add_string(fw_cfg, FW_CFG_CMDLINE_DATA, machine->kernel_cmdline);
} else {
fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_SIZE, 0);
}
fw_cfg_add_i64(fw_cfg, FW_CFG_INITRD_ADDR, initrd_addr);
fw_cfg_add_i64(fw_cfg, FW_CFG_INITRD_SIZE, initrd_size);
- fw_cfg_add_i16(fw_cfg, FW_CFG_BOOT_DEVICE, ms->boot_order[0]);
+ fw_cfg_add_i16(fw_cfg, FW_CFG_BOOT_DEVICE, machine->boot_order[0]);
fw_cfg_add_i16(fw_cfg, FW_CFG_SPARC64_WIDTH, graphic_width);
fw_cfg_add_i16(fw_cfg, FW_CFG_SPARC64_HEIGHT, graphic_height);
@@ -946,21 +946,21 @@ static const struct hwdef hwdefs[] = {
};
/* Sun4u hardware initialisation */
-static void sun4u_init(MachineState *ms)
+static void sun4u_init(MachineState *machine)
{
- sun4uv_init(get_system_memory(), ms, &hwdefs[0]);
+ sun4uv_init(get_system_memory(), machine, &hwdefs[0]);
}
/* Sun4v hardware initialisation */
-static void sun4v_init(MachineState *ms)
+static void sun4v_init(MachineState *machine)
{
- sun4uv_init(get_system_memory(), ms, &hwdefs[1]);
+ sun4uv_init(get_system_memory(), machine, &hwdefs[1]);
}
/* Niagara hardware initialisation */
-static void niagara_init(MachineState *ms)
+static void niagara_init(MachineState *machine)
{
- sun4uv_init(get_system_memory(), ms, &hwdefs[2]);
+ sun4uv_init(get_system_memory(), machine, &hwdefs[2]);
}
static QEMUMachine sun4u_machine = {
diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c
index 532f196..08dd4d0 100644
--- a/hw/unicore32/puv3.c
+++ b/hw/unicore32/puv3.c
@@ -101,12 +101,12 @@ static void puv3_load_kernel(const char *kernel_filename)
graphic_console_init(NULL, 0, &no_ops, NULL);
}
-static void puv3_init(MachineState *ms)
+static void puv3_init(MachineState *machine)
{
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *initrd_filename = ms->initrd_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *initrd_filename = machine->initrd_filename;
CPUUniCore32State *env;
if (initrd_filename) {
diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c
index fb7a817..3150064 100644
--- a/hw/xenpv/xen_machine_pv.c
+++ b/hw/xenpv/xen_machine_pv.c
@@ -28,11 +28,11 @@
#include "xen_domainbuild.h"
#include "sysemu/blockdev.h"
-static void xen_init_pv(MachineState *ms)
+static void xen_init_pv(MachineState *machine)
{
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
- const char *initrd_filename = ms->initrd_filename;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
+ const char *initrd_filename = machine->initrd_filename;
DriveInfo *dinfo;
int i;
diff --git a/hw/xtensa/xtensa_lx60.c b/hw/xtensa/xtensa_lx60.c
index 6168a5c..507dd88 100644
--- a/hw/xtensa/xtensa_lx60.c
+++ b/hw/xtensa/xtensa_lx60.c
@@ -159,7 +159,7 @@ static void lx60_reset(void *opaque)
cpu_reset(CPU(cpu));
}
-static void lx_init(const LxBoardDesc *board, MachineState *ms)
+static void lx_init(const LxBoardDesc *board, MachineState *machine)
{
#ifdef TARGET_WORDS_BIGENDIAN
int be = 1;
@@ -172,9 +172,9 @@ static void lx_init(const LxBoardDesc *board, MachineState *ms)
MemoryRegion *ram, *rom, *system_io;
DriveInfo *dinfo;
pflash_t *flash = NULL;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
- const char *kernel_cmdline = ms->kernel_cmdline;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
+ const char *kernel_cmdline = machine->kernel_cmdline;
int n;
if (!cpu_model) {
@@ -198,7 +198,7 @@ static void lx_init(const LxBoardDesc *board, MachineState *ms)
}
ram = g_malloc(sizeof(*ram));
- memory_region_init_ram(ram, NULL, "lx60.dram", ms->ram_size);
+ memory_region_init_ram(ram, NULL, "lx60.dram", machine->ram_size);
vmstate_register_ram_global(ram);
memory_region_add_subregion(system_memory, 0, ram);
@@ -275,7 +275,7 @@ static void lx_init(const LxBoardDesc *board, MachineState *ms)
}
}
-static void xtensa_lx60_init(MachineState *ms)
+static void xtensa_lx60_init(MachineState *machine)
{
static const LxBoardDesc lx60_board = {
.flash_base = 0xf8000000,
@@ -283,10 +283,10 @@ static void xtensa_lx60_init(MachineState *ms)
.flash_sector_size = 0x10000,
.sram_size = 0x20000,
};
- lx_init(&lx60_board, ms);
+ lx_init(&lx60_board, machine);
}
-static void xtensa_lx200_init(MachineState *ms)
+static void xtensa_lx200_init(MachineState *machine)
{
static const LxBoardDesc lx200_board = {
.flash_base = 0xf8000000,
@@ -294,10 +294,10 @@ static void xtensa_lx200_init(MachineState *ms)
.flash_sector_size = 0x20000,
.sram_size = 0x2000000,
};
- lx_init(&lx200_board, ms);
+ lx_init(&lx200_board, machine);
}
-static void xtensa_ml605_init(MachineState *ms)
+static void xtensa_ml605_init(MachineState *machine)
{
static const LxBoardDesc ml605_board = {
.flash_base = 0xf8000000,
@@ -305,10 +305,10 @@ static void xtensa_ml605_init(MachineState *ms)
.flash_sector_size = 0x20000,
.sram_size = 0x2000000,
};
- lx_init(&ml605_board, ms);
+ lx_init(&ml605_board, machine);
}
-static void xtensa_kc705_init(MachineState *ms)
+static void xtensa_kc705_init(MachineState *machine)
{
static const LxBoardDesc kc705_board = {
.flash_base = 0xf0000000,
@@ -316,7 +316,7 @@ static void xtensa_kc705_init(MachineState *ms)
.flash_sector_size = 0x20000,
.sram_size = 0x2000000,
};
- lx_init(&kc705_board, ms);
+ lx_init(&kc705_board, machine);
}
static QEMUMachine xtensa_lx60_machine = {
diff --git a/hw/xtensa/xtensa_sim.c b/hw/xtensa/xtensa_sim.c
index 3470087..89da43c 100644
--- a/hw/xtensa/xtensa_sim.c
+++ b/hw/xtensa/xtensa_sim.c
@@ -46,14 +46,14 @@ static void sim_reset(void *opaque)
cpu_reset(CPU(cpu));
}
-static void xtensa_sim_init(MachineState *ms)
+static void xtensa_sim_init(MachineState *machine)
{
XtensaCPU *cpu = NULL;
CPUXtensaState *env = NULL;
MemoryRegion *ram, *rom;
- ram_addr_t ram_size = ms->ram_size;
- const char *cpu_model = ms->cpu_model;
- const char *kernel_filename = ms->kernel_filename;
+ ram_addr_t ram_size = machine->ram_size;
+ const char *cpu_model = machine->cpu_model;
+ const char *kernel_filename = machine->kernel_filename;
int n;
if (!cpu_model) {
next prev parent reply other threads:[~2014-05-16 18:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 14:42 [Qemu-devel] [Qemu-detvel] [PATCH 0/4] machine: QemuOpts per machine Marcel Apfelbaum
2014-05-07 14:42 ` [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState Marcel Apfelbaum
2014-05-12 16:00 ` Laszlo Ersek
2014-05-13 13:25 ` Cornelia Huck
2014-05-13 15:44 ` Michael S. Tsirkin
2014-05-13 17:34 ` Andreas Färber
2014-05-15 15:04 ` Markus Armbruster
2014-05-18 8:37 ` Marcel Apfelbaum
2014-05-16 14:39 ` Igor Mammedov
2014-05-16 18:33 ` Andreas Färber [this message]
2014-05-18 8:51 ` Marcel Apfelbaum
2014-05-16 16:20 ` Igor Mammedov
2014-05-16 18:38 ` Andreas Färber
2014-05-18 8:48 ` Marcel Apfelbaum
2014-05-07 14:42 ` [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value Marcel Apfelbaum
2014-05-13 17:36 ` Andreas Färber
2014-05-13 19:08 ` Eric Blake
2014-05-14 17:00 ` Andreas Färber
2014-05-14 17:29 ` Marcel Apfelbaum
2014-05-14 18:25 ` Luiz Capitulino
2014-05-14 19:51 ` Markus Armbruster
2014-05-14 20:38 ` Michael Roth
2014-05-18 8:42 ` Marcel Apfelbaum
2014-05-14 20:26 ` Andreas Färber
2014-05-15 16:13 ` Markus Armbruster
2014-05-15 16:27 ` Michael Roth
2014-05-15 17:19 ` Markus Armbruster
2014-05-15 17:55 ` Michael Roth
2014-05-07 14:42 ` [Qemu-devel] [PATCH 3/4] vl.c: do not set 'type' property in obj_set_property Marcel Apfelbaum
2014-05-13 17:39 ` Andreas Färber
2014-05-15 16:15 ` Markus Armbruster
2014-05-15 16:38 ` Andreas Färber
2014-05-15 17:13 ` Paolo Bonzini
2014-05-07 14:43 ` [Qemu-devel] [PATCH 4/4] hw/machine: qemu machine opts as properties to QemuMachineState Marcel Apfelbaum
2014-05-13 17:54 ` Andreas Färber
2014-05-13 13:13 ` [Qemu-devel] [Qemu-detvel] [PATCH 0/4] machine: QemuOpts per machine Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537659F6.3090705@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=chouteau@adacore.com \
--cc=cornelia.huck@de.ibm.com \
--cc=edgar.iglesias@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jcmvbkbc@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=michael@walle.cc \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.crosthwaite@xilinx.com \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=robh@kernel.org \
--cc=scottwood@freescale.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.