From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WlZUI-00070S-RT for mharc-qemu-trivial@gnu.org; Sat, 17 May 2014 03:56:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlZUB-0006ra-HJ for qemu-trivial@nongnu.org; Sat, 17 May 2014 03:56:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlZU5-0006Cn-Dh for qemu-trivial@nongnu.org; Sat, 17 May 2014 03:56:51 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:40708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlZTs-00066M-Mv; Sat, 17 May 2014 03:56:32 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id D62B64171A; Sat, 17 May 2014 11:56:31 +0400 (MSK) Message-ID: <5377162F.5060209@msgid.tls.msk.ru> Date: Sat, 17 May 2014 11:56:31 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Peter Maydell , qemu-devel@nongnu.org References: <1400245203-32005-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1400245203-32005-1-git-send-email-peter.maydell@linaro.org> X-Enigmail-Version: 1.6 OpenPGP: id=804465C5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, patches@linaro.org Subject: Re: [Qemu-trivial] [PATCH] iohandler.c: Properly initialize sigaction struct X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 May 2014 07:56:57 -0000 16.05.2014 17:00, Peter Maydell wrote: > The code in qemu_init_child_watch() wasn't clearing the 'struct > sigaction' before passing it to sigaction(); this meant that we > would block a random set of signals while executing the SIGCHLD > handler. Initialize properly by using memset() on the struct, > as we do in similar cases elsewhere Applied to -trivial, thank you! /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlZTz-0006lc-2m for qemu-devel@nongnu.org; Sat, 17 May 2014 03:56:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlZTs-00067h-Up for qemu-devel@nongnu.org; Sat, 17 May 2014 03:56:39 -0400 Message-ID: <5377162F.5060209@msgid.tls.msk.ru> Date: Sat, 17 May 2014 11:56:31 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1400245203-32005-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1400245203-32005-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] iohandler.c: Properly initialize sigaction struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, patches@linaro.org 16.05.2014 17:00, Peter Maydell wrote: > The code in qemu_init_child_watch() wasn't clearing the 'struct > sigaction' before passing it to sigaction(); this meant that we > would block a random set of signals while executing the SIGCHLD > handler. Initialize properly by using memset() on the struct, > as we do in similar cases elsewhere Applied to -trivial, thank you! /mjt