All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com,
	arybchenko@solarflare.com, jerin.jacob@caviumnetworks.com,
	hemant.agrawal@nxp.com, gaetan.rivet@6wind.com
Subject: Re: [PATCH v2] doc: announce kvargs API change
Date: Thu, 22 Nov 2018 15:02:28 +0100	[thread overview]
Message-ID: <5377378.MItyz4mTKp@xps> (raw)
In-Reply-To: <20181122132212.brq3ifximbtu5c5d@platinum>

22/11/2018 14:22, Olivier Matz:
> On Thu, Nov 22, 2018 at 11:32:23AM +0100, Thomas Monjalon wrote:
> > After processing a kvlist in rte_kvargs_process(),
> > it may be needed to loop again over kvlist in order to know
> > whether the key is matched or not.
> > In order to simplify implementation of kvargs checks,
> > a new pointer parameter may be used to get the match count.
> > 
> > The change of the function prototype would be as below:
> > 
> >  int
> >  rte_kvargs_process(const struct rte_kvargs *kvlist,
> >  		const char *key_match,
> > +		int *match_count,
> >  		arg_handler_t handler,
> >  		void *opaque_arg)
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Maybe "unsigned int" instead of "int".

Yes we will discuss such detail during review of the code patch.

> Apart from this,
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks
I will consider the deprecation notice as approved when there will be 3 acks.

  reply	other threads:[~2018-11-22 14:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 15:45 [PATCH] doc: announce kvargs API change Thomas Monjalon
2018-11-22 10:32 ` [PATCH v2] " Thomas Monjalon
2018-11-22 13:22   ` Olivier Matz
2018-11-22 14:02     ` Thomas Monjalon [this message]
2018-11-22 17:08     ` Ferruh Yigit
2018-11-23 16:31       ` Jerin Jacob
2018-11-24 17:12         ` Thomas Monjalon
2018-11-23 13:17 ` [PATCH] " Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5377378.MItyz4mTKp@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaetan.rivet@6wind.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.