From: Gianluca Gennari <gennarone@gmail.com>
To: Martin Kepplinger <martink@posteo.de>,
Antti Palosaari <crope@iki.fi>,
gregkh@linuxfoundation.org,
Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: m.chehab@samsung.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg()
Date: Sat, 17 May 2014 20:43:49 +0200 [thread overview]
Message-ID: <5377ADE5.1030304@gmail.com> (raw)
In-Reply-To: <5377A1CC.7020104@posteo.de>
Il 17/05/2014 19:52, Martin Kepplinger ha scritto:
> Am 2014-05-17 19:21, schrieb Antti Palosaari:
>> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
>>> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
>>> use the common kernel coding style.
>>>
>>> Signed-off-by: Martin Kepplinger <martink@posteo.de>
>>
>> Reviewed-by: Antti Palosaari <crope@iki.fi>
>>
>>> ---
>>> this applies to next-20140516. any more suggestions?
>>> more cleanup can be done when dprintk() is completely gone.
>>
>> Do you have the device? I am a bit reluctant patching that driver
>> without any testing as it has happened too many times something has gone
>> totally broken.
> I don't have the device and will, at most, change such style issues.
>
>>
>> IIRC Devin said it is in staging because of style issues and nothing
>> more. Is that correct?
> I haven't heard anything. A TODO file would help.
Hi Antti, Martin,
if I remember correctly, the main issue with this driver is that the
device does not work anymore after a reboot: it needs a power cycle to
start working again. Probably this issue is enough to keep the driver in
staging.
Regards,
Gianluca
>
>>
>> regards
>> Antti
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-05-17 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 13:16 [PATCH] staging: media: as102: replace custom dprintk() with dev_dbg() Martin Kepplinger
2014-05-17 13:59 ` Antti Palosaari
2014-05-17 16:05 ` [PATCHv2] " Martin Kepplinger
2014-05-17 17:21 ` Antti Palosaari
2014-05-17 17:52 ` Martin Kepplinger
2014-05-17 18:43 ` Gianluca Gennari [this message]
2014-05-17 19:22 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2014-08-04 9:10 [PATCH] " Dan Carpenter
2014-08-04 10:17 ` [PATCHv2] " Martin Kepplinger
2014-08-04 10:40 ` Dan Carpenter
2014-08-04 11:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5377ADE5.1030304@gmail.com \
--to=gennarone@gmail.com \
--cc=crope@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=dheitmueller@kernellabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=martink@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.