From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH v3 0/9] SRP initiator patches for kernel 3.16 Date: Sun, 18 May 2014 10:01:33 +0300 Message-ID: <53785ACD.90101@dev.mellanox.co.il> References: <53761628.8030701@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53761628.8030701-HInyCGIudOg@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche , Roland Dreier Cc: Sagi Grimberg , Vu Pham , Sebastian Parschauer , David Dillow , linux-rdma List-Id: linux-rdma@vger.kernel.org On 5/16/2014 4:44 PM, Bart Van Assche wrote: > Changes compared to v2: > - Reconnect to the SRP target if a local invalidation work request > fails. > - Swapped the state->next_fmr / next_fr assignments to improve code > readability. > - Clarified a comment in patch 1/9. > - Fixed error handling in srp_create_target() (was broken in v2). > - Added a missing "PFX" in two shost_printk() statements in patch 9/9. > > Changes compared to v1: > - Modified the FMR code such that one FMR pool is allocated per > connection instead of one pool per HCA. > - Dropped the patch "Make srp_alloc_req_data() reallocate request data". > - Moved introduction of the register_always kernel module parameter > into a separate patch. > - Removed the loop from around ib_create_fmr_pool() and > srp_create_fr_pool(). max_pages_per_mr is now computed from > max_mr_size and max_fast_reg_page_list_len. > - Reduced fast registration pool size from 1024 to scsi_host->can_queue. > - Added a patch that should fix a crash that had been reported by Sagi > but that I have not yet been able to reproduce myself. > > This patch series consists of the following nine patches: > > 0001-IB-srp-Fix-a-sporadic-crash-triggered-by-cable-pulli.patch > 0002-IB-srp-Fix-kernel-doc-warnings.patch > 0003-IB-srp-Introduce-an-additional-local-variable.patch > 0004-IB-srp-Introduce-srp_map_fmr.patch > 0005-IB-srp-Introduce-srp_finish_mapping.patch > 0006-IB-srp-Introduce-the-register_always-kernel-module-p.patch > 0007-IB-srp-One-FMR-pool-per-SRP-connection.patch > 0008-IB-srp-Rename-FMR-related-variables.patch > 0009-IB-srp-Add-fast-registration-support.patch The series looks good to me. Reviewed-by: Sagi Grimberg Sagi. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html