From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
gxt@mprc.pku.edu.cn, Matan Barak <matanb@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Eyal Perry <eyalpe@mellanox.com>, Amir Vadai <amirv@mellanox.com>,
Shawn Bohrer <sbohrer@rgmadvisors.com>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
Date: Sun, 18 May 2014 18:08:27 +0800 [thread overview]
Message-ID: <5378869B.2070102@gmail.com> (raw)
In-Reply-To: <CAJZOPZJN9YG2uAw0rSDkU0rQG=0FFDgSMnFDHpWS6hwZEqdwfA@mail.gmail.com>
On 05/18/2014 03:55 AM, Or Gerlitz wrote:
> On Sat, May 17, 2014 at 8:36 AM, David Miller <davem@davemloft.net> wrote:
>>
>> From: Chen Gang <gang.chen.5i5j@gmail.com>
>> Date: Sat, 17 May 2014 13:26:16 +0800
>>
>>> 'struct irq_affinity_notify' and the related functions are only defined
>>> when SMP enabled, so at present, mlx4 has to only run under SMP.
>>>
>>> The related error (allmodconfig under unicore32):
>>
>> Making the entire driver depend upon SMP is not the answer,
>
>
> Indeed, we would do that just for the relevant portion,
>
Thank you for your work.
And next, when I meet the case like this again, instead of sending
patch, I shall send suggestion message to the related members/experts.
Thanks.
--
Chen Gang
Open, share and attitude like air, water and life which God blessed
prev parent reply other threads:[~2014-05-18 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 5:26 [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP Chen Gang
2014-05-17 5:26 ` Chen Gang
2014-05-17 5:36 ` David Miller
[not found] ` <20140517.013655.349586284786993619.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-05-17 5:42 ` Chen Gang
2014-05-17 5:42 ` Chen Gang
2014-05-17 19:55 ` Or Gerlitz
2014-05-18 10:08 ` Chen Gang
2014-05-18 10:08 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5378869B.2070102@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=eyalpe@mellanox.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=or.gerlitz@gmail.com \
--cc=roland@kernel.org \
--cc=sbohrer@rgmadvisors.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.