From: Amir Vadai <amirv@mellanox.com>
To: Christian Engelmayer <cengelma@gmx.at>, <netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels()
Date: Sun, 18 May 2014 14:43:45 +0300 [thread overview]
Message-ID: <53789CF1.5040402@mellanox.com> (raw)
In-Reply-To: <1400363523-18371-1-git-send-email-cengelma@gmx.at>
On 5/18/2014 12:52 AM, Christian Engelmayer wrote:
> Function mlx4_en_set_channels() stops running ports before performing the
> requested action. In that case local variable 'port_up' is set so that the
> port is restarted at the end of the function, however, in case the port was
> not stopped, variable 'port_up' is left uninitialized and the behaviour is
> undetermined. Detected by Coverity - CID 751497.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
Acked-By: Amir Vadai <amirv@mellanox.com>
next prev parent reply other threads:[~2014-05-18 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 21:52 [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels() Christian Engelmayer
2014-05-18 11:43 ` Amir Vadai [this message]
2014-05-19 1:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53789CF1.5040402@mellanox.com \
--to=amirv@mellanox.com \
--cc=cengelma@gmx.at \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.