From: "Toralf Förster" <toralf.foerster@gmx.de>
To: sparclinux@vger.kernel.org
Subject: Re: format string mismatch in arch/sparc/kernel/sysfs.c
Date: Sun, 18 May 2014 17:45:52 +0000 [thread overview]
Message-ID: <5378F1D0.1010704@gmx.de> (raw)
In-Reply-To: <5378BB37.2000402@gmx.de>
On 05/18/2014 07:32 PM, Sam Ravnborg wrote:
> Hi Torlaf.
>
>> I'm just wondering if the format mismatch error is intentionally left in the code or not :
>>
>> [arch/sparc/kernel/sysfs.c:154]: (warning) %ld in format string (no. 1) requires 'long *' but the argument type is 'unsigned long *'.
>
> This is something we should fix.
patch will be send out soon.
> My gcc does not give this warning - how did you produce the warning above?
Well, I got it with cppcheck - a nifty tool for static code checkin. I
stumbled over it a while ago - it still under development ofc.
> Also we use -Werror on purpose to catch warnings so they get fixed - so
> your build should have errored out.
>
great
> Do you care to send a patch so you get proper attribution.
>
> Sam
>
--
Toralf
prev parent reply other threads:[~2014-05-18 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 13:52 format string mismatch in arch/sparc/kernel/sysfs.c Toralf Förster
2014-05-18 17:32 ` Sam Ravnborg
2014-05-18 17:45 ` Toralf Förster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5378F1D0.1010704@gmx.de \
--to=toralf.foerster@gmx.de \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.