From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Mon, 23 Apr 2018 13:56:53 +0000 Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Message-Id: <5379683.QunLsIS18Z@amdc3058> List-Id: References: <2542100.cElVns0SR0@amdc3058> In-Reply-To: <2542100.cElVns0SR0@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , Laurent Pinchart , Linux Media Mailing List On Monday, April 23, 2018 02:47:28 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > Add stubs for omapfb_dss.h, in the case it is included by > > some driver when CONFIG_FB_OMAP2 is not defined, with can > > happen on ARM when DRM_OMAP is not 'n'. > > > > That allows building such driver(s) with COMPILE_TEST. > > > > Signed-off-by: Mauro Carvalho Chehab > > This patch should be dropped (together with patch #6/7) as it was > superseded by a better solution suggested by Laurent: > > https://patchwork.kernel.org/patch/10325193/ > > ACK-ed by Tomi: > > https://www.spinics.net/lists/dri-devel/msg171918.html > > and already merged by you (commit 7378f1149884 "media: omap2: > omapfb: allow building it with COMPILE_TEST").. Hmm, I see now while this patch is still included: menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB depends on DRM_OMAP = n Ideally we should be able to build both drivers in the same kernel (especially as modules). I was hoping that it could be fixed easily but then I discovered the root source of the problem: drivers/gpu/drm/omapdrm/dss/display.o: In function `omapdss_unregister_display': display.c:(.text+0x2c): multiple definition of `omapdss_unregister_display' drivers/video/fbdev/omap2/omapfb/dss/display.o:display.c:(.text+0x198): first defined here ... I need some more time to think about this.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Mon, 23 Apr 2018 15:56:53 +0200 Message-ID: <5379683.QunLsIS18Z@amdc3058> References: <2542100.cElVns0SR0@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97BDD89E36 for ; Mon, 23 Apr 2018 13:57:00 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180423135657euoutp0104862de5f3c373514e86e29afc66e8b0~oFTs0Rqir1538215382euoutp01Z for ; Mon, 23 Apr 2018 13:56:57 +0000 (GMT) In-Reply-To: <2542100.cElVns0SR0@amdc3058> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , Laurent Pinchart , Linux Media Mailing List List-Id: dri-devel@lists.freedesktop.org T24gTW9uZGF5LCBBcHJpbCAyMywgMjAxOCAwMjo0NzoyOCBQTSBCYXJ0bG9taWVqIFpvbG5pZXJr aWV3aWN6IHdyb3RlOgo+IE9uIEZyaWRheSwgQXByaWwgMjAsIDIwMTggMDE6NDI6NTEgUE0gTWF1 cm8gQ2FydmFsaG8gQ2hlaGFiIHdyb3RlOgo+ID4gQWRkIHN0dWJzIGZvciBvbWFwZmJfZHNzLmgs IGluIHRoZSBjYXNlIGl0IGlzIGluY2x1ZGVkIGJ5Cj4gPiBzb21lIGRyaXZlciB3aGVuIENPTkZJ R19GQl9PTUFQMiBpcyBub3QgZGVmaW5lZCwgd2l0aCBjYW4KPiA+IGhhcHBlbiBvbiBBUk0gd2hl biBEUk1fT01BUCBpcyBub3QgJ24nLgo+ID4gCj4gPiBUaGF0IGFsbG93cyBidWlsZGluZyBzdWNo IGRyaXZlcihzKSB3aXRoIENPTVBJTEVfVEVTVC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTWF1 cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFiQHMtb3BlbnNvdXJjZS5jb20+Cj4gCj4gVGhpcyBw YXRjaCBzaG91bGQgYmUgZHJvcHBlZCAodG9nZXRoZXIgd2l0aCBwYXRjaCAjNi83KSBhcyBpdCB3 YXMKPiBzdXBlcnNlZGVkIGJ5IGEgYmV0dGVyIHNvbHV0aW9uIHN1Z2dlc3RlZCBieSBMYXVyZW50 Ogo+IAo+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvMTAzMjUxOTMvCj4gCj4g QUNLLWVkIGJ5IFRvbWk6Cj4gCj4gaHR0cHM6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMvZHJpLWRl dmVsL21zZzE3MTkxOC5odG1sCj4gCj4gYW5kIGFscmVhZHkgbWVyZ2VkIGJ5IHlvdSAoY29tbWl0 IDczNzhmMTE0OTg4NCAibWVkaWE6IG9tYXAyOgo+IG9tYXBmYjogYWxsb3cgYnVpbGRpbmcgaXQg d2l0aCBDT01QSUxFX1RFU1QiKS4uCgpIbW0sIEkgc2VlIG5vdyB3aGlsZSB0aGlzIHBhdGNoIGlz IHN0aWxsIGluY2x1ZGVkOgoKbWVudWNvbmZpZyBGQl9PTUFQMgogICAgICAgIHRyaXN0YXRlICJP TUFQMisgZnJhbWUgYnVmZmVyIHN1cHBvcnQiCiAgICAgICAgZGVwZW5kcyBvbiBGQgogICAgICAg IGRlcGVuZHMgb24gRFJNX09NQVAgPSBuCgpJZGVhbGx5IHdlIHNob3VsZCBiZSBhYmxlIHRvIGJ1 aWxkIGJvdGggZHJpdmVycyBpbiB0aGUgc2FtZSBrZXJuZWwKKGVzcGVjaWFsbHkgYXMgbW9kdWxl cykuCgpJIHdhcyBob3BpbmcgdGhhdCBpdCBjb3VsZCBiZSBmaXhlZCBlYXNpbHkgYnV0IHRoZW4g SSBkaXNjb3ZlcmVkCnRoZSByb290IHNvdXJjZSBvZiB0aGUgcHJvYmxlbToKCmRyaXZlcnMvZ3B1 L2RybS9vbWFwZHJtL2Rzcy9kaXNwbGF5Lm86IEluIGZ1bmN0aW9uIGBvbWFwZHNzX3VucmVnaXN0 ZXJfZGlzcGxheSc6CmRpc3BsYXkuYzooLnRleHQrMHgyYyk6IG11bHRpcGxlIGRlZmluaXRpb24g b2YgYG9tYXBkc3NfdW5yZWdpc3Rlcl9kaXNwbGF5Jwpkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAy L29tYXBmYi9kc3MvZGlzcGxheS5vOmRpc3BsYXkuYzooLnRleHQrMHgxOTgpOiBmaXJzdCBkZWZp bmVkIGhlcmUKLi4uCgpJIG5lZWQgc29tZSBtb3JlIHRpbWUgdG8gdGhpbmsgYWJvdXQgdGhpcy4u CgpCZXN0IHJlZ2FyZHMsCi0tCkJhcnRsb21pZWogWm9sbmllcmtpZXdpY3oKU2Ftc3VuZyBSJkQg SW5zdGl0dXRlIFBvbGFuZApTYW1zdW5nIEVsZWN0cm9uaWNzCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:53568 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755417AbeDWN5A (ORCPT ); Mon, 23 Apr 2018 09:57:00 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180423135657euoutp02b88108adf78ba79a313d8c154d8e03ea~oFTs5YghW0275902759euoutp02N for ; Mon, 23 Apr 2018 13:56:57 +0000 (GMT) From: Bartlomiej Zolnierkiewicz To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Laurent Pinchart , Tomi Valkeinen Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Mon, 23 Apr 2018 15:56:53 +0200 Message-ID: <5379683.QunLsIS18Z@amdc3058> In-Reply-To: <2542100.cElVns0SR0@amdc3058> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" References: <2542100.cElVns0SR0@amdc3058> Sender: linux-media-owner@vger.kernel.org List-ID: On Monday, April 23, 2018 02:47:28 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > Add stubs for omapfb_dss.h, in the case it is included by > > some driver when CONFIG_FB_OMAP2 is not defined, with can > > happen on ARM when DRM_OMAP is not 'n'. > > > > That allows building such driver(s) with COMPILE_TEST. > > > > Signed-off-by: Mauro Carvalho Chehab > > This patch should be dropped (together with patch #6/7) as it was > superseded by a better solution suggested by Laurent: > > https://patchwork.kernel.org/patch/10325193/ > > ACK-ed by Tomi: > > https://www.spinics.net/lists/dri-devel/msg171918.html > > and already merged by you (commit 7378f1149884 "media: omap2: > omapfb: allow building it with COMPILE_TEST").. Hmm, I see now while this patch is still included: menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB depends on DRM_OMAP = n Ideally we should be able to build both drivers in the same kernel (especially as modules). I was hoping that it could be fixed easily but then I discovered the root source of the problem: drivers/gpu/drm/omapdrm/dss/display.o: In function `omapdss_unregister_display': display.c:(.text+0x2c): multiple definition of `omapdss_unregister_display' drivers/video/fbdev/omap2/omapfb/dss/display.o:display.c:(.text+0x198): first defined here ... I need some more time to think about this.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics