Re: [RFC PATCH bpf-next v3 04/10] bpf: Add common attr support for prog_load

[Leon Hwang <leon.hwang@linux.dev>]

On 3/10/25 07:51, Alexei Starovoitov wrote:
> On Thu, Oct 2, 2025 at 8:49 AM Leon Hwang <leon.hwang@linux.dev> wrote:
>>

[...]

>> +
>> +       if (!attr->log_buf && common_attrs->log_buf) {
>> +               *log_common_attrs = true;
> 
> I feel like a broken record.
> Do not use 'bool' arguments. There is always a better option.
> 'bool *' is even worse.

Got it — I now understand that using 'bool' here (especially as a
pointer) is a code smell and generally discouraged.

I'll remove log_common_attrs and reimplement this part to avoid the
'bool' argument altogether. I'll look for a cleaner alternative in the
next revision.

Thanks,
Leon