All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Wolfgang Grandegger <wg@grandegger.com>,
	"Max S." <max@schneidersoft.net>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH v1] can: gs_usb: Added support for the GS_USB CAN devices.
Date: Mon, 19 May 2014 08:49:52 +0200	[thread overview]
Message-ID: <5379A990.1060308@pengutronix.de> (raw)
In-Reply-To: <5342C225.7070907@grandegger.com>

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On 04/07/2014 05:20 PM, Wolfgang Grandegger wrote:
> On 12/24/2013 08:29 PM, Max S. wrote:
>> >From 11d702dac3ec1b5eadffa3435cade7fdd853c91f Mon Sep 17 00:00:00 2001
>> From: Maximilian Schneider <max@schneidersoft.net>
>> Date: Sun, 3 Nov 2013 16:57:06 +0000
>> Subject: [PATCH] Added support for the GS_USB CAN devices.
>>
>> ---
>> The patch is against the 'linux-can-next.git' repo.
>>
>> The Geschwister Schneider Family of devices are galvanically isolated USB2.0 to CAN2.0A/B adapters.
>> Currently two form factors are available, a tethered dongle in a rugged enclosure, and mini-pci-e card.
>>
>> Signed-off-by: Maximilian Schneider <max@schneidersoft.net>
> 
> Acked-by: Wolfgang Grandegger <wg@grandegger.com>
> 
> Marc, I reviewed the patch again over the weekend and did find just a
> few minor issues (see below) which I could fix with a subsequent patch.
> From my point of view the driver can go in.

Thanks for the review. I've addressed your remarks while applying this
patch to can-next.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

      reply	other threads:[~2014-05-19  6:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-24 19:29 [PATCH v1] can: gs_usb: Added support for the GS_USB CAN devices Max S.
2014-04-03 19:44 ` Wolfgang Grandegger
2014-04-03 19:46   ` Wolfgang Grandegger
2014-04-07 15:20 ` Wolfgang Grandegger
2014-05-19  6:49   ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5379A990.1060308@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=max@schneidersoft.net \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.