All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stephane Grosjean <s.grosjean@peak-system.com>
Cc: "Christopher R. Baker" <cbaker@rec.ri.cmu.edu>,
	linux-can@vger.kernel.org
Subject: Re: [PATCH] peak_pci: fix use after free in netdev teardown
Date: Mon, 19 May 2014 11:20:31 +0200	[thread overview]
Message-ID: <5379CCDF.90809@pengutronix.de> (raw)
In-Reply-To: <5379CB87.20106@peak-system.com>

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

On 05/19/2014 11:14 AM, Stephane Grosjean wrote:
> Hi All,
> 
> So I finally had a look to the diff file. It clearly does what
> Christopher says, that is, it fixes some memory access order issues when
> the CAN devices have to be removed from the system, either when probing
> has failed or when the driver is unloaded from the system.
> 
> The diff file has to be re-written into a Linux-coding style patch, and
> yes, maybe all this removing stuff could be put into a (new) single
> function made for that.
> 
> So, how do we proceed, please ?

Make it so.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

  reply	other threads:[~2014-05-19  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 19:45 [PATCH] peak_pci: fix use after free in netdev teardown Christopher R. Baker
2014-05-19  7:11 ` Marc Kleine-Budde
2014-05-19  7:16   ` Stephane Grosjean
2014-05-19  7:18     ` Marc Kleine-Budde
2014-05-19  9:14   ` Stephane Grosjean
2014-05-19  9:20     ` Marc Kleine-Budde [this message]
2014-05-19 12:06       ` Stephane Grosjean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5379CCDF.90809@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=cbaker@rec.ri.cmu.edu \
    --cc=linux-can@vger.kernel.org \
    --cc=s.grosjean@peak-system.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.