Re: [PATCH] KVM: vmx: DR7 masking on task switch emulation is wrong

[Paolo Bonzini <pbonzini@redhat.com>]

Il 19/05/2014 08:50, Nadav Amit ha scritto:
> The DR7 masking which is done on task switch emulation should be in hex format
> (clearing the local breakpoints enable bits 0,2,4 and 6).
>
> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
> ---
>  arch/x86/kvm/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 138ceff..286d510 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -5439,7 +5439,7 @@ static int handle_task_switch(struct kvm_vcpu *vcpu)
>  	}
>
>  	/* clear all local breakpoint enable flags */
> -	vmcs_writel(GUEST_DR7, vmcs_readl(GUEST_DR7) & ~55);
> +	vmcs_writel(GUEST_DR7, vmcs_readl(GUEST_DR7) & ~0x55);
>
>  	/*
>  	 * TODO: What about debug traps on tss switch?
>

Thanks, applying to kvm/queue.

Paolo